X11 on Windows

2015-10-11 Thread Martin Graesslin
Hi frameworks and windows devs, from the release announcement of the latest frameworks release I learned that there were multiple changes to disable finding X11 on Windows (e.g. [1]). I think such changes are wrong and I have spoken against such changes (they are wrong, CMake supports disabling

Re: Problem investigating a heap-use-after-free in kwindowsystem

2015-10-03 Thread Martin Graesslin
On Friday, October 2, 2015 8:38:20 PM CEST Michael Pyne wrote: > On Fri, October 2, 2015 23:59:00 Albert Astals Cid wrote: > > El Friday 02 October 2015, a les 22:24:00, Martin Graesslin va escriure: > > > Hi all, > > > > > > I added a new unit test to kw

Problem investigating a heap-use-after-free in kwindowsystem

2015-10-02 Thread Martin Graesslin
Hi all, I added a new unit test to kwin today [1] and it failed on the CI system due to the enabled ASAN with an error in kwindowsystem. I'm able to reproduce it locally, but fail to understand it. To me the code and the test conditions looks correct. Relevant part of the bt: #0 0x7f5198ac2c84

Re: Review Request 125083: Move X11 related find_package under X11_FOUND

2015-09-13 Thread Martin Graesslin
On Sunday, September 13, 2015 11:55:22 AM CEST David Faure wrote: > On Tuesday 08 September 2015 07:25:14 Martin Gräßlin wrote: > > From our CI system: > > cmake -DCMAKE_DISABLE_FIND_PACKAGE_X11=TRUE > > I was just looking at problems in the CI right now, and it seems this was > set for kwindowsys

Re: ksycoca improvements (Re: assert in kservicetypefactory.cpp)

2015-08-24 Thread Martin Graesslin
On Monday, August 24, 2015 11:08:08 AM CEST Martin Graesslin wrote: > > > I think that kglobalaccel5 is invoked as soon as KXmlGui gets involved > > > (which KDevelop makes use of). > > > > > > Code in kxmlgui.git somewhat agrees: There are references to >

Re: ksycoca improvements (Re: assert in kservicetypefactory.cpp)

2015-08-24 Thread Martin Graesslin
On Monday, August 24, 2015 10:58:30 AM CEST Martin Graesslin wrote: > On Monday, August 24, 2015 10:39:57 AM CEST you wrote: > > On Monday 24 August 2015 10:00:43 Martin Gräßlin wrote: > > > Am 2015-08-24 01:03, schrieb Kevin Funk: > > > > Right now whenever I star

Re: ksycoca improvements (Re: assert in kservicetypefactory.cpp)

2015-08-24 Thread Martin Graesslin
On Monday, August 24, 2015 10:39:57 AM CEST you wrote: > On Monday 24 August 2015 10:00:43 Martin Gräßlin wrote: > > Am 2015-08-24 01:03, schrieb Kevin Funk: > > > Right now whenever I start kdevelop I get the following daemons up and > > > running > > > on Windows: > > > - dbus-daemon > > > - kded

Re: Where are my systray icons cont'd

2014-11-27 Thread Martin Graesslin
On Thursday 27 November 2014 21:28:21 Jan Grulich wrote: > On Thursday 27 of November 2014 21:10 Kevin Funk wrote: > > Heya, > > > > I'm still missing my beloved systray icons for a few applications in > > Plasma > > 5 on Ubuntu 14.10 (using distro provided packages). > > > > I have every package

Re: Supporting MSVC2010 in ktexteditor framework

2014-11-04 Thread Martin Graesslin
On Wednesday 05 November 2014 08:53:42 Mirko Boehm wrote: > Hi, > > > On 05 Nov 2014, at 04:33, Nicolás Alvarez > > wrote: > > > > So, I hereby propose making an exception and bumping the minimum > > compiler version *for ktexteditor only* to MSVC2012. Opinions? > > I propose to bump the requir

Whoopsie in KF5::WindowSystem 5.3.0

2014-10-10 Thread Martin Graesslin
Hi all, unfortunately we have an embarrassing bug [1] in KWindowSystem 5.3.0 which can crash any application making use of KWindowSystem on the X11 Platform. This is fixed with commit [2]. I recommend to either do a 5.3.1 release for KWindowSystem with just that commit added or at least that d

Re: Loading Qt 5 translations

2014-06-09 Thread Martin Graesslin
On Monday 09 June 2014 00:04:03 Albert Astals Cid wrote: > El Dimarts, 27 de maig de 2014, a les 07:08:45, Aurélien Gâteau va escriure: > > On Mon, May 26, 2014, at 9:41, Alexander Potashev wrote: > > > 2014-05-26 18:17 GMT+04:00 Aurélien Gâteau : > > > > Not sure where we could put this. Framework

Re: Issues for Qt5/KF5/KDE/CI system on OSX/MacPorts

2014-05-24 Thread Martin Graesslin
On Saturday 24 May 2014 12:28:52 mk-li...@email.de wrote: > 2) > KGlobalAccel is also marked invalid for OSX: > > This framework also builds and deploys, but we had quite a discussion > lately about kglobalaccel integration on MacPorts/KDE 4.12.* in order to > get KDE build fine on MacPorts

Re: Writing a Frameworks book at Randa

2014-05-04 Thread Martin Graesslin
On Saturday 03 May 2014 23:56:53 Valorie Zimmerman wrote: > I know I said > > On Sat, May 3, 2014 at 2:14 AM, Valorie Zimmerman > > wrote: > > Time is short, so this is the last time I'll write. Think about what > > you want in your Frameworks book and commit to making it happen. > > > > Valori

Re: ki18n_wrap_ui and libraries

2014-04-29 Thread Martin Graesslin
On Tuesday 29 April 2014 21:27:29 Chusslove Illich wrote: > > [: Martin Gräßlin :] > > If my understanding is correct one needs to define TRANSLATION_DOMAIN > > before including KLocalizedString for library code. But the CMake macro > > ki18n_wrap_ui does not allow to define the TRANSLATION_DOMAIN.

Re: kcmshell4 in frameworks and workspace repos

2014-04-29 Thread Martin Graesslin
On Tuesday 29 April 2014 21:27:04 Burkhard Lück wrote: > Hi, > > grepping for kcmshell4 in all frameworks and workspace repos gives me 4 hits > in frameworks and 14 hits in workspace in 6 different repos. > > That is obviously wrong and should be fixed, right? > > If so, should I file a RR for e

Re: KDE(Libs)4Support rename

2014-04-09 Thread Martin Graesslin
On Wednesday 09 April 2014 19:33:20 Alex Merry wrote: > On 09/04/14 18:38, Aleix Pol wrote: > > What happens with the cmake side? are we going to have to rename all > > KF5::KDE4Support for KF5::KDELibs4Support? > > Yes, that's what the changes I've got queued up require. wouldn't it be possible

Re: KLibrary: what is it good for?

2014-03-19 Thread Martin Graesslin
On Wednesday 19 March 2014 15:19:12 Alex Merry wrote: > On 19/03/14 14:29, Alex Merry wrote: > > While trying to clean up KDE 4 references in KService, I've been looking > > at KLibrary. > > > > This basically does two things: it has a factory() method that has been > > deprecated since before kde

Re: Runtime conflict with KF5Plasma and KDE 4 in same prefix

2014-02-23 Thread Martin Graesslin
On Monday 24 February 2014 05:33:37 Michael Palimaka wrote: > Hi, > > I have run into a strange issue when KDE 4 and KF5Plasma are installed > into the same prefix (I can reliably reproduce the issue by > installing/uninstalling KF5Plasma and restarting KDE). > > Simply, the vertical bar key "|"

Re: kguiaddons uses qpa headers?

2014-02-23 Thread Martin Graesslin
On Sunday 23 February 2014 17:47:48 David Faure wrote: > On Sunday 23 February 2014 17:02:55 John Layt wrote: > > Hi, > > > > I'm building all of Frameworks from scratch for the first time, using the > > openSUSE packages for Qt 5.2, and qguiaddons fails with: > > > > [ 24%] Building CXX object >

Re: KDE Frameworks: Moving toward 5.0 final and Governance

2014-01-06 Thread Martin Graesslin
On Monday 06 January 2014 07:52:50 Kevin Ottens wrote: > The current list of modules is there: > http://community.kde.org/Frameworks/List > > As you can see there's quite some holes in the table, and quite a few > entries marked unmaintained. KDE Frameworks as a set of technologies will > only be

Re: KDE-wide Animation settings

2014-01-05 Thread Martin Graesslin
On Sunday 05 January 2014 10:10:48 you wrote: > On 01/05/2014 09:57 AM, Hugo Pereira Da Costa wrote: > > On 01/05/2014 09:42 AM, Martin Graesslin wrote: > >> On Saturday 04 January 2014 20:52:43 David Faure wrote: > >>> On Saturday 04 January 2014 20:19:43 Hugo Pere

Re: KTextEditor & Frameworks question

2014-01-05 Thread Martin Graesslin
On Saturday 04 January 2014 19:40:46 Christoph Cullmann wrote: > > On Saturday 04 January 2014 19:18:56 Christoph Cullmann wrote: > > > Hi, > > > > > > I cleanup the frameworks branch in kate.git to only have libktexteditor > > > lib > > > and the KTextEditor/ktexteditor includes to be installed a

Re: KDE-wide Animation settings

2014-01-05 Thread Martin Graesslin
On Saturday 04 January 2014 20:52:43 David Faure wrote: > On Saturday 04 January 2014 20:19:43 Hugo Pereira Da Costa wrote: > > The first problem is that with kf5, the style configuration kcm expects > > a libkstyle_oxygen_config.so *plugin* for this configuration, whereas it > > was "kstyle_oxygen

Re: KF5 include problems on the build.kde.org?

2014-01-04 Thread Martin Graesslin
On Saturday 04 January 2014 15:04:58 Friedrich W. H. Kossebau wrote: > Hi, > > I am currently struggling to have the KF5 port of Okteta not only build > locally (what it does fine), but also on KDE's build server: > could anybody hint to me why on the build server the file KLocalizedString > is no

Re: Framework licenses

2013-12-27 Thread Martin Graesslin
On Monday 23 December 2013 19:45:36 Alex Merry wrote: > On 23/12/13 18:46, Aurélien Gâteau wrote: > > - plasma-framework: this framework uses multiple licenses, but majority is > > LGPL (this is the case for many other frameworks). Should we use a LGPL > > 2.1 > > COPYING.LIB file? > > A quick att

Re: Macro naming

2013-12-23 Thread Martin Graesslin
On Monday 23 December 2013 10:36:22 Alex Merry wrote: > On 23/12/13 01:42, Alex Merry wrote: > > On 23/12/13 01:27, Aleix Pol wrote: > >> On Mon, Dec 23, 2013 at 1:17 AM, Alex Merry >> > >> > wrote: > >> Currently, we are not consistent about CMake macro naming i

Re: Framework metadata

2013-12-19 Thread Martin Graesslin
On Thursday 19 December 2013 14:35:29 Aurélien Gâteau wrote: > On Thu, 19 Dec 2013 12:13:08 +0200, Giorgos Tsiapaliokas wrote: > > I definitely like the idea but I don't like xml/rdf. Why don't we > > just > > use json? > > Because DOAP is an existing format, so it avoids reinventing the wheel. R

Re: Framework metadata

2013-12-19 Thread Martin Graesslin
On Thursday 19 December 2013 21:22:36 you wrote: > On Thu, Dec 19, 2013 at 9:15 PM, Martin Graesslin wrote: > > On Wednesday 18 December 2013 21:35:33 Christophe Giboudeaux wrote: > >> On Wednesday 18 December 2013 19:50:58 Alex Merry wrote: > >> > On 18/12/1

Re: Framework metadata

2013-12-19 Thread Martin Graesslin
On Wednesday 18 December 2013 21:35:33 Christophe Giboudeaux wrote: > On Wednesday 18 December 2013 19:50:58 Alex Merry wrote: > > On 18/12/13 17:54, Aurélien Gâteau wrote: > > > We need to have at least a COPYING file in there, with the full content > > > of > > > the license. > > > > I believe t

Re: Fwd: Tracking bugs in Frameworks

2013-12-16 Thread Martin Graesslin
On Monday 16 December 2013 19:01:25 David Edmundson wrote: > On Mon, Dec 16, 2013 at 6:08 PM, Martin Graesslin wrote: > > On Monday 16 December 2013 11:58:35 David Edmundson wrote: > >> I think if we did that it would be a good idea to prefix the names > >>

Re: Fwd: Tracking bugs in Frameworks

2013-12-16 Thread Martin Graesslin
On Monday 16 December 2013 11:58:35 David Edmundson wrote: > I think if we did that it would be a good idea to prefix the names > with a common element like > "frameworks-coreaddons" "frameworks-kio" etc. I don't think it needs the prefix. For a description, we have the product description in bugz

Re: KPageDialog - What happened to source compatibility?

2013-12-14 Thread Martin Graesslin
On Saturday 14 December 2013 16:40:23 Albert Astals Cid wrote: > El Dissabte, 14 de desembre de 2013, a les 16:30:04, Martin Graesslin va > > escriure: > > On Saturday 14 December 2013 16:18:44 Albert Astals Cid wrote: > > > I think to remember one of the goals was that th

Re: KPageDialog - What happened to source compatibility?

2013-12-14 Thread Martin Graesslin
On Saturday 14 December 2013 16:18:44 Albert Astals Cid wrote: > I think to remember one of the goals was that the KF5 would be as source > compatible as possible. > > Now i see that KPageDialog is not a KDialog anymore and thus setButtons, > setDefaultButton, setButtonGuiItem, etc are not availab

Re: [Important] Breaking change - Changing framworks lib and package names

2013-12-11 Thread Martin Graesslin
On Wednesday 11 December 2013 17:35:33 Alex Merry wrote: > On 11/12/13 17:12, David Faure wrote: > > On Wednesday 11 December 2013 14:12:38 Alex Merry wrote: > >> On 11/12/13 13:43, Martin Klapetek wrote: > >>> ***) These are the Qt Designer widgets, no need to tinker with it at all > >> > >> I li

Re: Suggestion: create an own framework for KGlobalAccel

2013-12-08 Thread Martin Graesslin
On Sunday 08 December 2013 18:42:25 Kevin Ottens wrote: > On Sunday 08 December 2013 10:16:36 Martin Graesslin wrote: > > Hi, > > > > at the moment KGlobalAccel is part of XmlGui which I consider semantically > > wrong. Global shortcuts have nothing to do with XmlGui a

Re: Suggestion: create an own framework for KGlobalAccel

2013-12-08 Thread Martin Graesslin
On Sunday 08 December 2013 18:04:45 Albert Astals Cid wrote: > El Diumenge, 8 de desembre de 2013, a les 10:16:36, Martin Graesslin va > > escriure: > > Hi, > > > > at the moment KGlobalAccel is part of XmlGui which I consider semantically > > wrong. Global

Suggestion: create an own framework for KGlobalAccel

2013-12-08 Thread Martin Graesslin
Hi, at the moment KGlobalAccel is part of XmlGui which I consider semantically wrong. Global shortcuts have nothing to do with XmlGui and there are quite some examples for applications which need global shortcuts but do not use xml gui (e.g. everything in the desktop shell). My suggestion is to m

Re: Framework diagrams

2013-12-04 Thread Martin Graesslin
On Wednesday 04 December 2013 18:36:25 Aurélien Gâteau wrote: > Hi, > > I worked on generating diagrams for KF5 frameworks. The current output can > be browsed here: > > http://agateau.com/tmp/kf5 I think I found a bug :-) The diagram for ki18n doesn't show the dependency to kjs. It looks pre

Re: KToolInvokation

2013-12-01 Thread Martin Graesslin
On Sunday 01 December 2013 18:42:58 Dominik Haumann wrote: > Hi Aleix, > > > KToolInvocation::invokeHelp() was removed. We used it like this: > > KToolInvocation::invokeHelp("advanced-editing-tools-commandline","kate"); > > According to https://git.reviewboard.kde.org/r/111298/, is the prefer

Re: Accessing the private of KGlobalShortcut in kglobalaccel

2013-11-22 Thread Martin Graesslin
On Friday 22 November 2013 15:39:35 Nicolás Alvarez wrote: > Why is the daemon needed? Why can't global shortcuts handling be done > in-process by the library? a) not all window systems allow to read the keyboard. b) The daemon does handling like only one application can take a global shortcut. If

Re: workspace fails in dateandtime kcm

2013-10-20 Thread Martin Graesslin
On Sunday 20 October 2013 11:44:48 Christoph Feck wrote: > Hi, > > I am getting this weird error during "make" (not "make install"): > > /bin/sh: /local/git/KDE/base/kde-workspace- > frameworks/kcontrol/dateandtime/kcmclock_actions.actions: Permission > denied > make[2]: *** [kcontrol/dateandtime

Re: EcmQt4To5Porting

2013-10-07 Thread Martin Graesslin
On Friday 04 October 2013 10:51:07 Martin Klapetek wrote: > On Fri, Oct 4, 2013 at 9:22 AM, David Faure wrote: > > On Wednesday 02 October 2013 14:07:31 Martin Klapetek wrote: > > > There were 2 files recently removed from ECM which broke attica's build, > > > this puts the removed files as local

Re: Splitting out a KX11Extras frameworks from KWindowSystems

2013-09-16 Thread Martin Graesslin
On Monday 16 September 2013 16:51:45 Aurélien Gâteau wrote: > On Monday 16 September 2013 15:07:37 Martin Graesslin wrote: > > Hi, > > > > KWindowSystems is a framework which looks to me like a KX11Extras > > framework. Most of the things inside this framework are X11

Splitting out a KX11Extras frameworks from KWindowSystems

2013-09-16 Thread Martin Graesslin
Hi, KWindowSystems is a framework which looks to me like a KX11Extras framework. Most of the things inside this framework are X11 specific. Some API even has XLib/XCB specific data types as arguments or return values (e.g. netwm.h). The only class which has a non-X11 implementation is KWindowSy

Re: kinterprocesswindowing, drop it or not?

2013-09-12 Thread Martin Graesslin
On Thursday 12 September 2013 16:18:12 Aurélien Gâteau wrote: > Hi, > > I started working on the KInterProcessWindowing (kiw) framework, which is > expected to go into tier2 because it depends on KWindowSystem (tier1). > > kiw is made of two set of files: > > kmessagebox_kiw.*: KMessageBox funct

Re: Plugin locator performance ballpark

2013-09-09 Thread Martin Graesslin
On Monday 09 September 2013 16:48:05 David Faure wrote: > On Monday 09 September 2013 14:23:10 Sebastian Kügler wrote: > > Martin Grässlin asked if we could offer an async API for this. Opinions? > > This task is mostly I/O, and a bit of CPU. > Portable async I/O requires doing it in a thread. > T

Re: XCB vs. KModifierKeyInfoProvider

2013-09-02 Thread Martin Graesslin
On Monday 02 September 2013 10:39:53 you wrote: > On Monday 02 September 2013 09:05:27 Martin Gräßlin wrote: > > 3) I just don't like it and would feel very uncomfortable given that we > > don't have unit tests and that this could break in future if xkb.h > > becomes > > available. > > Why not de

Re: Is this task done?

2013-09-01 Thread Martin Graesslin
On Saturday 31 August 2013 15:59:41 Albert Astals Cid wrote: > Hi guys, been browsing > http://community.kde.org/Frameworks/Epics/kdelibs_cleanups and seen > > Update QCommandLineParser from the version that landed in qtbase dev and fix > compilation (including plasma-framework). At least one thin

Re: Concerns about deprecating KFileDialog

2013-08-23 Thread Martin Graesslin
On Saturday 24 August 2013 00:12:09 Andrius da Costa Ribas wrote: > Hello, > > (crosspost between kde-frameworks-devel and kde-windows) > > I've posted a question in a recent review request that deprecates > KFileDialog in favor of QFileDialog for KF5, however this question got > probably unnotic

Re: Updating CMake requirement to 2.8.12 RC 1

2013-08-23 Thread Martin Graesslin
On Friday 23 August 2013 09:14:05 David Faure wrote: > On Friday 23 August 2013 06:51:23 Martin Graesslin wrote: > > Given that it's already lots of work to keep up with the constant breakage > > due to changes in frameworks the outlook of also having breakage in cmake &

Re: Updating CMake requirement to 2.8.12 RC 1

2013-08-22 Thread Martin Graesslin
On Wednesday 21 August 2013 08:40:43 Kevin Ottens wrote: > Hello, > > On Tuesday 20 August 2013 23:23:30 Alexander Neundorf wrote: > > On Tuesday 20 August 2013, Stephen Kelly wrote: > > > Alexander Neundorf wrote: > > > > please wait with updating the required version until 2.8.12 final is > > >

Re: Ki18n mostly ready

2013-08-05 Thread Martin Graesslin
On Monday 05 August 2013 20:57:33 Chusslove Illich wrote: > My notion of source compatibility was that it builds and works, not only > that it builds :) Is there really a point of leaving in dummy methods just > so that the build can proceed, even if they do nothing? As I mentioned, my > intention

Re: Ki18n mostly ready

2013-08-05 Thread Martin Graesslin
On Monday 05 August 2013 16:19:07 Sebastian Kügler wrote: > Hi Chusslove, > > On Friday, August 02, 2013 12:00:50 Chusslove Illich wrote: > > > [: David Faure :] > > > There's no way to keep the [insertCatalog] method for source > > > compatibility > > > and implement it somehow on top of the new

Re: symbol lookup error in each application linking KDE4Support

2013-07-29 Thread Martin Graesslin
On Monday 29 July 2013 11:13:32 David Faure wrote: > 2) check your LD_LIBRARY_PATH (empty is ok), and check thanks, that was the trick. LD_LIBRARY_PATH had of course my normal kde (4) setup included. After unsetting the variable kdeinit5 works and now I'm scared as I don't have an excuse anymore

Re: symbol lookup error in each application linking KDE4Support

2013-07-29 Thread Martin Graesslin
On Saturday 27 July 2013 12:47:53 you wrote: > On Wednesday 24 July 2013 12:01:07 Martin Graesslin wrote: > > Hi, > > > > when I try to run binaries which links KDE4Support (e.g. kdeinit5) I get > > the following symbol lookup error: > > > > [...]l

Re: find_package(XCB ...) ?

2013-07-28 Thread Martin Graesslin
On Sunday 28 July 2013 13:43:50 Sebastian Kügler wrote: > Hi Martin, > > I'm facing some challenges building kde-workspace on top of Frameworks. XCB > is not found, do you know which packages I need to have it found through > find_package? Same as kde-workspace on Qt4. Do you have an error message

Re: Oxygen + KF5 + Qt5

2013-07-12 Thread Martin Graesslin
On Thursday 11 July 2013 10:52:02 Hugo Pereira Da Costa wrote: > - the code that pass menu shadows (in the form of pixmap handles as X > properties) to kwin has been disabled because: I do not know how to > paint on an X11 pixmap with Qt5, and anyway this will likely be > rewritten in kwin I recomm

[RFC] Fixing fixx11h.h

2013-03-11 Thread Martin Graesslin
Hi all, as mentioned in my feedback mail fixx11h.h is currently broken. There are two independent issues. 1. fixx11h.h includes which doesn't get installed. 2. KWindowSystem has a copy as fixx11h_p.h which is included in e.g. netwm.h and doesn't get installed. Currently fixx11h.h is in kdeui/u

Re: KJavaAppletWidget's usage of KWindowSystem

2013-02-04 Thread Martin Graesslin
On Monday 04 February 2013 19:04:47 David Faure wrote: > On Monday 04 February 2013 17:47:45 Aaron J. Seigo wrote: > > On Saturday, February 2, 2013 13:05:15 David Faure wrote: > > > I tried removing the doNotManage() call, and... > > > > if you replace them with: > > setWindowFlags(Qt::X11Byp

<    1   2