D17797: Include applets/22

nicolasfella updated this revision to Diff 49294. nicolasfella added a comment. - Rebase - add to Breeze dark REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17797?vs=48191&id=49294 BRANCH fix REVISION DETAIL https://phabricator.kde.org/D17797

D17973: [Android] Fail more gracefully when building with API < 23

This revision was automatically updated to reflect the committed changes. Closed by commit R289:0430c577f963: [Android] Fail more gracefully when building with API < 23 (authored by nicolasfella). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17973?vs=

D17973: [Android] Fail more gracefully when building with API < 23

nicolasfella created this revision. nicolasfella added reviewers: vkrause, apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Building the Android backend with SDK < 23 is successful but fail

D17851: Add Android notification backend

nicolasfella added a comment. Please note that all apps uploaded to the Play Store need to have a target API level >= 26 (Oreo). This means (among other things) that notifications need to have a channel (see https://developer.android.com/training/notify-user/channels). The current code will

D17851: Add Android notification backend

nicolasfella added a comment. By using AndroidX (formerly known as the support library) we could enable it for Android version older than 23 (which is about 29% of all active devices). That would require adding the appropriate jar to the build. REPOSITORY R289 KNotifications REVISION DETA

D7700: Show list of tags in PlacesView

nicolasfella updated this revision to Diff 48246. nicolasfella added a comment. - Fix REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7700?vs=48245&id=48246 BRANCH arcpatch-D7700 REVISION DETAIL https://phabricator.kde.org/D7700 AFFECTED FILES src/filew

D7700: Show list of tags in PlacesView

nicolasfella updated this revision to Diff 48245. nicolasfella added a comment. - Whitespace-- REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7700?vs=48244&id=48245 BRANCH arcpatch-D7700 REVISION DETAIL https://phabricator.kde.org/D7700 AFFECTED FILES

D7700: Show list of tags in PlacesView

nicolasfella requested review of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7700 To: nicolasfella, #dolphin, #kde_applications, alexeymin, ngraham Cc: kde-frameworks-devel, bruns, rkflx, mmustac, spoorun, michaelh, renatoo, anthonyfieroni, cfeck, elvisan

D7700: Show list of tags in PlacesView

nicolasfella reopened this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D7700 To: nicolasfella, #dolphin, #kde_applications, alexeymin, ngraham Cc: kde-frameworks-devel, bruns, rkflx, mmustac, spoorun, michaelh, re

D7700: Show list of tags in PlacesView

nicolasfella updated this revision to Diff 48244. nicolasfella added a comment. Tags List v2.0 Deleted tags are automatically removed from the panel REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7700?vs=45426&id=48244 BRANCH arcpatch-D7700 REVISION DE

D17816: Initial support for xattrs on kio copy/move

nicolasfella added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: cochise, dfaure Cc: nicolasfella, kde-frameworks-devel, michaelh, ngraham, bruns

D17806: Add Itinerary plugin

nicolasfella edited the summary of this revision. nicolasfella added a dependency: D17805: Allow specifying multiple mimetypes as constraints. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D17806 To: nicolasfella, apol, vkrause Cc: kde-frameworks-devel, michael

D17805: Allow specifying multiple mimetypes as constraints

nicolasfella added a dependent revision: D17806: Add Itinerary plugin. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D17805 To: nicolasfella, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17806: Add Itinerary plugin

nicolasfella created this revision. nicolasfella added reviewers: apol, vkrause. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Useful for importing reservation from PDF, Apple Wallet or JSON-L

D17805: Allow specifying multiple mimetypes as constraints

nicolasfella created this revision. nicolasfella added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Allow specifying multiple mimetypes separated by ';'. When one of them m

D17797: Include applets/22

nicolasfella added a comment. Thinking about it, is there a particular reason why those icons are in the 22 folder in the first place? They are all svgs after all REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D17797 To: nicolasfella, #breeze Cc: kde-frameworks

D17797: Include applets/22

nicolasfella created this revision. nicolasfella added a reviewer: Breeze. nicolasfella added a project: Breeze. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY I noticed that plasma-pa doesn't

D17178: Don't ask for confimation when reloading

This revision was automatically updated to reflect the committed changes. Closed by commit R39:82a1673746ea: Don't ask for confimation when reloading (authored by nicolasfella). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17178?vs=47740&id=47918 REVISIO

D17178: Don't ask for confimation when reloading

nicolasfella updated this revision to Diff 47740. nicolasfella added a comment. - delete m_modOnHdHandler REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17178?vs=46283&id=47740 BRANCH arcpatch-D17178 REVISION DETAIL https://phabricator.kde.org/D171

D17287: Enable sharing URLs via email

nicolasfella added a comment. In D17287#370993 , @apol wrote: > I'm not sure it makes a lot of sense to have the application include the title, isn't it better that the user writes it down on a config page or just the e-mail client? The

D17305: Add KDE Connect SMS plugin

nicolasfella updated this revision to Diff 47226. nicolasfella added a comment. - i18n REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17305?vs=46697&id=47226 BRANCH kdeconnectsms REVISION DETAIL https://phabricator.kde.org/D17305 AFFECTED FIL

D17285: Add plugin type for sharing URLs

This revision was automatically updated to reflect the committed changes. Closed by commit R495:74e0e9852637: Add plugin type for sharing URLs (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17285?vs=46635&id=46821 REVISION

D17305: Add KDE Connect SMS plugin

nicolasfella edited the summary of this revision. nicolasfella added a dependency: D17285: Add plugin type for sharing URLs. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D17305 To: nicolasfella, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17285: Add plugin type for sharing URLs

nicolasfella added a dependent revision: D17305: Add KDE Connect SMS plugin. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D17285 To: nicolasfella, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17305: Add KDE Connect SMS plugin

nicolasfella edited the summary of this revision. nicolasfella added a dependency: D17292: [SMS App] Allow passing a message via args. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D17305 To: nicolasfella, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17305: Add KDE Connect SMS plugin

nicolasfella created this revision. nicolasfella added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Enable sharing links via KDE Connect SMS TEST PLAN Send a page from Fa

D17285: Add plugin type for sharing URLs

nicolasfella added a dependent revision: D17287: Enable sharing URLs via email. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D17285 To: nicolasfella, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17287: Enable sharing URLs via email

nicolasfella edited the summary of this revision. nicolasfella added a dependency: D17285: Add plugin type for sharing URLs. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D17287 To: nicolasfella, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17287: Enable sharing URLs via email

nicolasfella created this revision. nicolasfella added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Share URLs via email. Add title to input data TEST PLAN Send page via

D17285: Add plugin type for sharing URLs

nicolasfella added a dependent revision: D17286: Enable page sharing. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D17285 To: nicolasfella, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17285: Add plugin type for sharing URLs

nicolasfella edited the test plan for this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D17285 To: nicolasfella, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17285: Add plugin type for sharing URLs

nicolasfella created this revision. nicolasfella added a reviewer: apol. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Add a plugin type for sharing URLs and adapt KDE Connect plugin to suppor

D17178: Don't ask for confimation when reloading

nicolasfella edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D17178 To: nicolasfella, #kate, ngraham Cc: kwrite-devel, kde-frameworks-devel, michaelh, ngraham, bruns, demsking, cullmann, sars, dhaumann

D17178: Don't ask for confimation when reloading

nicolasfella created this revision. nicolasfella added reviewers: Kate, ngraham. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. nicolasfella requested review of this revision. REVISION SUMMARY When reloading the document it is unnecessary t

D16951: Resolve merge conflict

nicolasfella accepted this revision. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D16951 REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, kde-frameworks-devel, mic

D16951: Resolve merge conflict

nicolasfella edited the summary of this revision. nicolasfella edited the test plan for this revision. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D16951 REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect Cc: cfeck, trickyricky26, abe

D16951: Add mouse button icons

nicolasfella added a comment. In D16951#363898 , @ndavis wrote: > So now I have 2 commits and one of them is already on master, but they're both called "Add mouse button icons" and use the same description. Should I update this diff to describe

D16951: Add mouse button icons

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D16951_1 REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect Cc: cfeck, trickyricky26, abetts, ngraham, r

D16951: Add mouse button icons

nicolasfella added a comment. This assumes the files that you uploaded before the merge are all correct. - Save the correct icons somewhere. - Checkout the old diff: arc patch --diff 45755 - Begin rebase: git rebase master - Override the files with conflicts with the files you saved

D16951: Add mouse button icons

nicolasfella added a comment. In D16951#363878 , @ndavis wrote: > Save what or how? Doesn't `arc diff --update D16951` save things? I know I added the right files and there were only 2 conflicts (`icons/actions/16/dialog-input-devices.svg` and

D16951: Add mouse button icons

nicolasfella added a comment. I any case, try again and check the files for merge conflict markers REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello,

D16951: Add mouse button icons

nicolasfella added a comment. In D16951#363875 , @ndavis wrote: > I thought I did this already. I rebased onto master, then added the version of the file I wanted, then continued the rebase, then updated the diff. Is there something I missed?

D16951: Add mouse button icons

nicolasfella reopened this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolasfella, kd

D16951: Add mouse button icons

nicolasfella requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect Cc: cfeck, trickyricky26, abetts, ngraham, rizzitello, nicolas

D16951: Add mouse button icons

nicolasfella accepted this revision. nicolasfella added a comment. Looks great! REPOSITORY R266 Breeze Icons BRANCH mouse-buttons (branched from master) REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg, ngraham, nicolasfella, #kde_connect Cc: trickyricky26, abetts,

D16951: Add mouse button icons

nicolasfella added a comment. Looks good! +1 REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D16951 To: ndavis, #vdg Cc: trickyricky26, abetts, ngraham, rizzitello, nicolasfella, kde-frameworks-devel, michaelh, bruns

T8349: Improve Places panel usability and presentation

nicolasfella updated the task description. TASK DETAIL https://phabricator.kde.org/T8349 To: ngraham, nicolasfella Cc: #frameworks, tomsk, bruns, michaelh, acrouthamel, sharvey, mmustac, jtamate, rkflx, #dolphin, ngraham, ggrysuk, alexde, IohannesPetros, sourabhboss, feverfew, trickyricky26,

D7700: Show list of tags in PlacesView

This revision was automatically updated to reflect the committed changes. Closed by commit R241:2ae8a0c374cd: Show list of tags in PlacesView (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D7700?vs=45414&id=45426#toc REPOSITORY R241 KIO CHANGES SINCE LAST UP

D7700: Show list of tags in PlacesView

nicolasfella added inline comments. INLINE COMMENTS > ngraham wrote in kfileplacesmodel.cpp:187 > const. But in fact, does this even need to be a variable? It's only used once. Will fix on push REPOSITORY R241 KIO BRANCH arcpatch-D7700 REVISION DETAIL https://phabricator.kde.org/D7700

D7700: Show list of tags in PlacesView

nicolasfella updated this revision to Diff 45414. nicolasfella added a comment. - Merge branch 'master' into arcpatch-D7700 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7700?vs=38100&id=45414 BRANCH arcpatch-D7700 REVISION DETAIL https://phabricator.kde

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

nicolasfella added a comment. Probably related: D16189 REPOSITORY R224 KDE Connect REVISION DETAIL https://phabricator.kde.org/D16692 To: eduisters, #kde_connect, #frameworks, albertvaka Cc: nicolasfella, albertvaka, kdeconnect, shivanshukantprasad, s

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

nicolasfella added a reviewer: Frameworks. REPOSITORY R224 KDE Connect REVISION DETAIL https://phabricator.kde.org/D16692 To: eduisters, #kde_connect, #frameworks Cc: kdeconnect, shivanshukantprasad, skymoore, wistak, dvalencia, rmenezes, julioc, Leptopoda, timothyc, jdvr, yannux, Danial0_0

D14472: Set Dialog flag for JobDialog

This revision was automatically updated to reflect the committed changes. Closed by commit R495:b82b62e87a4e: Set Dialog flag for JobDialog (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14472?vs=38729&id=44468 REVISION DET

D16145: Adapt autotest to new menu structure

This revision was automatically updated to reflect the committed changes. Closed by commit R304:34e50636dd7b: Adapt autotest to new menu structure (authored by nicolasfella). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16145?vs=43433&id=43541 REVISION DE

D16145: Adapt autotest to new menu structure

nicolasfella created this revision. nicolasfella added reviewers: gregormi, dhaumann. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY D13880 changed the menu

D15931: [Places panel] use more appropriate network icon

nicolasfella accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH better-network-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D15931 To: ngraham, #vdg, nicolasfella Cc: broulik, acrouthamel, kde-frameworks-devel, mi

D14472: Set Dialog flag for JobDialog

nicolasfella added a comment. Ping? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D14472 To: nicolasfella, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13880: [KMoreTools] Reduce menu hierarchy

This revision was automatically updated to reflect the committed changes. Closed by commit R304:9f54611a472d: [KMoreTools] Reduce menu hierarchy (authored by nicolasfella). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13880?vs=41581&id=41716 REVISION DETA

D13880: [KMoreTools] Reduce menu hierarchy

nicolasfella updated this revision to Diff 41581. nicolasfella added a comment. - Address comments REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13880?vs=41575&id=41581 BRANCH arcpatch-D13880 REVISION DETAIL https://phabricator.kde.org/D13880 AFFE

D13880: [KMoreTools] Reduce menu hierarchy

nicolasfella updated this revision to Diff 41575. nicolasfella added a comment. - Move method to private REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13880?vs=37136&id=41575 BRANCH arcpatch-D13880 REVISION DETAIL https://phabricator.kde.org/D13880

D15375: Exclude genome files from indexing

This revision was automatically updated to reflect the committed changes. Closed by commit R293:1f7ac8433e12: Exclude genome files from indexing (authored by nicolasfella). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15375?vs=41261&id=41262 REVISION DETAIL

D15375: Exclude genome files from indexing

nicolasfella updated this revision to Diff 41261. nicolasfella added a comment. - Bump version REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15375?vs=41259&id=41261 BRANCH genome REVISION DETAIL https://phabricator.kde.org/D15375 AFFECTED FILES src/

D15375: Exclude genome files from indexing

nicolasfella created this revision. nicolasfella added a reviewer: Baloo. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Those files contain huge amounts of genome data that is uninterest

D13880: [KMoreTools] Reduce menu hierarchy

nicolasfella added a comment. In D13880#307597 , @dhaumann wrote: > What is the current state of this? > The new private functions should move to the pimpl class behind the d-pointer. > > In general: Looking at the public classes, /all/ th

D14397: Support libcanberra for audio notification

nicolasfella added a comment. +1 for Canberra REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D14397 To: broulik, #frameworks, dfaure, davidedmundson, sitter, drosca, kfunk, rjvbb Cc: alexeymin, ngraham, nicolasfella, kde-frameworks-devel, michaelh, bruns

D14472: Set Dialog flag for JobDialog

nicolasfella edited the test plan for this revision. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D14472 To: nicolasfella, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14472: Set Dialog flag for JobDialog

nicolasfella created this revision. nicolasfella added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY The JobDialog window is treated as a "nor

D14397: Support libcanberra for audio notification

nicolasfella added a comment. Not using something because it's from a "rival GUI" is not a valid argument. FWIW plasma-pa already uses Glib and Canberra. QtMultimedia uses GStreamer as backend on Unix, so it pulls in glib anyway. The only advantage, if any, of using QtMultimedia is that it u

D7700: Show list of tags in PlacesView

nicolasfella updated this revision to Diff 38100. nicolasfella added a comment. Actually save tag bookmark and check if it already exists before adding REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7700?vs=37300&id=38100 BRANCH tags REVISION DETAIL https

D14052: Add bluetooth plugin

This revision was automatically updated to reflect the committed changes. Closed by commit R495:0c9bf25e18a8: Add bluetooth plugin (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14052?vs=37583&id=37969 REVISION DETAIL htt

D14052: Add bluetooth plugin

nicolasfella added inline comments. INLINE COMMENTS > apol wrote in CMakeLists.txt:1 > Maybe should have `find_qmlmodule(org.kde.bluezqt 1.0)`? Makes sense. When I include it cmake tells me it's not found, although /usr/lib/qt/qml/org/kde/bluezqt exists. Am I missing something? REPOSITORY R

D14052: Add bluetooth plugin

nicolasfella added a comment. @apol I would like your opinion before merging REPOSITORY R495 Purpose Library BRANCH bluetooth REVISION DETAIL https://phabricator.kde.org/D14052 To: nicolasfella, apol, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14107: [Telegram] Don't wait for Telegram to be closed

This revision was automatically updated to reflect the committed changes. Closed by commit R495:6803b1203e46: [Telegram] Don't wait for Telegram to be closed (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14107?vs=37723&id=3

D14107: [Telegram] Don't wait for Telegram to be closed

nicolasfella created this revision. nicolasfella added a reviewer: apol. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Unlike e.g. kdeconnect-cli telegram stays

D14052: Add bluetooth plugin

nicolasfella added a dependent revision: D14056: Remove FileItemActionPlugin in favor of Purpose plugin. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D14052 To: nicolasfella, apol, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14052: Add bluetooth plugin

nicolasfella updated this revision to Diff 37583. nicolasfella added a comment. - Revert unintended change REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14052?vs=37582&id=37583 BRANCH bluetooth REVISION DETAIL https://phabricator.kde.org/D140

D14052: Add bluetooth plugin

nicolasfella created this revision. nicolasfella added reviewers: apol, ngraham. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Replace Bluedevil's FileItemActio

D7700: Show list of tags in PlacesView

nicolasfella updated this revision to Diff 37300. nicolasfella added a comment. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. Add tags places in KIO REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde

D13880: [KMoreTools] Reduce menu hierarchy

nicolasfella added a comment. In D13880#287481 , @gregormi wrote: > +1 for your suggestions. Downside: higher implementation effort. I like it, too, and I am willing to put effort in it, as soon as we agree on a way forward. > A bit

D13880: [KMoreTools] Reduce menu hierarchy

nicolasfella added a comment. In D13880#286816 , @ngraham wrote: > Or even this: > > Open SimpleScreenRecorder > - > Install Peek > Install Vokoscreen > - > Configur

D13880: [KMoreTools] Reduce menu hierarchy

nicolasfella added a comment. In D13880#286820 , @ngraham wrote: > In D13880#286818 , @nicolasfella wrote: > > > Do you know if/how we can check if there is a handler for appstream://? So we can fal

D13880: [KMoreTools] Reduce menu hierarchy

nicolasfella added a comment. In D13880#286800 , @ngraham wrote: > You are the most awesome person in the world today. Yay! > Here's a radical thought: get rid of the More menu entirely and move all of its content inline, like so:

D13880: [KMoreTools] Reduce menu hierarchy

nicolasfella edited the test plan for this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D13880 To: nicolasfella, gregormi, dhaumann, ngraham Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13880: [KMoreTools] Reduce menu hierarchy

nicolasfella created this revision. nicolasfella added reviewers: gregormi, dhaumann, ngraham. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. nicolasfella requested review of this revision. REVISION SUMMARY Skip 'More' submenu

D13124: Add Share action to Dolphin context menu

This revision was automatically updated to reflect the committed changes. Closed by commit R495:efbb952f10b3: Add Share action to Dolphin context menu (authored by nicolasfella). REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13124?vs=37052&id=37102 R

D13124: Add Share action to Dolphin context menu

nicolasfella added a reviewer: Dolphin. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, apol, #dolphin Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, michaelh, spoorun, navarromorales, isido

D13124: Add Share action to Dolphin context menu

nicolasfella retitled this revision from "[RFC] Add Share action to Dolphin context menu" to "Add Share action to Dolphin context menu". REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, apol Cc: markg, broulik, kde-frameworks-devel, elvisa

D13124: [RFC] Add Share action to Dolphin context menu

nicolasfella updated this revision to Diff 37052. nicolasfella added a comment. - Rename to ShareFileItemAction REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13124?vs=36578&id=37052 BRANCH fiap REVISION DETAIL https://phabricator.kde.org/D131

D13124: [RFC] Add Share action to Dolphin context menu

nicolasfella added a comment. @apol ping? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, apol Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, michaelh, spoorun, navarromorales, isidorov,

D13706: [KMoreTools] Enable installing tools via appstream url

This revision was automatically updated to reflect the committed changes. Closed by commit R304:84432a55e969: [KMoreTools] Enable installing tools via appstream url (authored by nicolasfella). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13706?vs=36652&id=36655#toc REPOSITORY R304 KN

D13706: [KMoreTools] Enable installing tools via appstream url

nicolasfella marked 9 inline comments as done. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D13706 To: nicolasfella, #frameworks, gregormi, ngraham Cc: ngraham, dhaumann, kde-frameworks-devel, michaelh, bruns

D13706: [KMoreTools] Enable installing tools via appstream url

nicolasfella updated this revision to Diff 36652. nicolasfella added a comment. o - Even more appstream ids. Thanks Nate REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13706?vs=36651&id=36652 BRANCH appstream REVISION DETAIL https://phabricator.kde

D13706: [KMoreTools] Enable installing tools via appstream url

nicolasfella updated this revision to Diff 36651. nicolasfella added a comment. - Add more appstream ids REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13706?vs=36650&id=36651 BRANCH appstream REVISION DETAIL https://phabricator.kde.org/D13706 AFFE

D13706: [KMoreTools] Enable installing tools via appstream url

nicolasfella updated this revision to Diff 36650. nicolasfella added a comment. - doc++ REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13706?vs=36620&id=36650 BRANCH appstream REVISION DETAIL https://phabricator.kde.org/D13706 AFFECTED FILES src/

D13706: [KMoreTools] Enable installing tools via appstream url

nicolasfella added inline comments. INLINE COMMENTS > nicolasfella wrote in kmoretools_p.h:394 > + would give the same result. What % does is acting as a QStringBuilder, > which is more performant in theory (not that it really matters in this case) See http://doc.qt.io/qt-5/qstring.html#more-ef

D13706: [KMoreTools] Enable installing tools via appstream url

nicolasfella added inline comments. INLINE COMMENTS > gregormi wrote in kmoretools_p.h:394 > What does the % sign do here? Can this be used to concatenate strings? Did > not try it myself. > > Otherwise ready to land. + would give the same result. What % does is acting as a QStringBuilder, whi

D13706: [KMoreTools] Enable installing tools via appstream url

nicolasfella updated this revision to Diff 36620. nicolasfella added a comment. - Replace appstreamUrl with appstreamId REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13706?vs=36617&id=36620 BRANCH appstream REVISION DETAIL https://phabricator.kde.o

D13706: [KMoreTools] Enable installing tools via appstream url

nicolasfella updated this revision to Diff 36617. nicolasfella added a comment. - Add documentation REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13706?vs=36612&id=36617 BRANCH appstream REVISION DETAIL https://phabricator.kde.org/D13706 AFFECTED

D13706: [KMoreTools] Enable installing tools via appstream url

nicolasfella marked 2 inline comments as done. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D13706 To: nicolasfella, #frameworks, gregormi, dhaumann Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D13706: [KMoreTools] Enable installing tools via appstream url

nicolasfella updated this revision to Diff 36612. nicolasfella added a comment. - Add kmousetool url REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13706?vs=36609&id=36612 BRANCH appstream REVISION DETAIL https://phabricator.kde.org/D13706 AFFECTED

<    3   4   5   6   7   8   9   >