D28542: Add 16px LibreOffice icons

2020-04-03 Thread Noah Davis
ndavis accepted this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28542 To: manueljlin, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-03-31 Thread Noah Davis
ndavis added a comment. Somehow I missed the notification that this was updated. Thanks for the horizontal alignment. Could you also add a left margin to the column of reset buttons? It should be the same as the spacing between the labels and the controls, which is

D28203: Move corner fold to top right in 24 icons

2020-03-30 Thread Noah Davis
ndavis added inline comments. INLINE COMMENTS > davidhurka wrote in filename-title-amarok.svg:8 > I realized that http://notmart.org/blog/2016/05/icon-colors/ and > https://community.kde.org/Guidelines_and_HOWTOs/Icon_Workflow_Tips#Stylesheets > contratict in the class names. One uses

T12855: [Breeze Icons] Get rid of redundancy in icons-dark/

2020-03-28 Thread Noah Davis
ndavis added a comment. In T12855#224570 , @davidhurka wrote: > Can anyone explain why rating-unrated and semi-starred-symbolic[-rtl] have 50% transparency, while rating has 100% opacity? That makes my compare script go wild, and I think it

D28362: Fix stylesheet linking in 8 icons

2020-03-28 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:1bbf2a546894: Fix stylesheet linking in 8 icons (authored by davidhurka, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D28362: Fix stylesheet linking in 8 icons

2020-03-28 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R266 Breeze Icons BRANCH fix-some-style-attributes REVISION DETAIL https://phabricator.kde.org/D28362 To: davidhurka, ndavis Cc: ndavis, kde-frameworks-devel,

D28323: Fix some stylesheet colors in 2 icon files

2020-03-27 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:0b834e41640f: Fix some stylesheet colors in 2 icon files (authored by davidhurka, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D27983: Make find-location show a magnifier on a map, to be different to mark-location

2020-03-27 Thread Noah Davis
ndavis added a comment. Not sure how I missed this. LGTM! REPOSITORY R266 Breeze Icons BRANCH create-find-location REVISION DETAIL https://phabricator.kde.org/D27983 To: davidhurka, #vdg, ngraham, ndavis Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D27983: Make find-location show a magnifier on a map, to be different to mark-location

2020-03-27 Thread Noah Davis
ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH create-find-location REVISION DETAIL https://phabricator.kde.org/D27983 To: davidhurka, #vdg, ngraham, ndavis Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28323: Fix some stylesheet colors in 2 icon files

2020-03-27 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH fix-some-stylesheet-colors REVISION DETAIL https://phabricator.kde.org/D28323 To: davidhurka, #vdg, ndavis Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28203: Move corner fold to top right in 24 icons

2020-03-25 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH move-corner-fold-to-top REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg, ndavis Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D28203: Move corner fold to top right in 24 icons

2020-03-25 Thread Noah Davis
ndavis added a comment. LGTM REPOSITORY R266 Breeze Icons BRANCH move-corner-fold-to-top REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg, ndavis Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28203: Move corner fold to top right in 24 icons

2020-03-24 Thread Noah Davis
ndavis requested changes to this revision. ndavis added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > document-preview.svg:1 > +/home/david/kde/breeze-icons/icons/actions/32/document-preview-archive.svg This needs to be a relative symlink (`ln -sr

D28203: Move corner fold to top right in 24 icons

2020-03-24 Thread Noah Davis
ndavis added a comment. Eh, I'm not going to make a big fuss about the copy icon. In D28203#633041 , @davidhurka wrote: > There are 172 icons in 16px but not in 22px, and 348 icons in 22px but not in 16px. There are 1561 icons in 22px but

D28228: Update window-pin, Add more sizes, Remove redundant edit-delete

2020-03-23 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R242:f363a06ae697: Update window-pin, Add more sizes, Remove redundant edit-delete (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D28228: Update window-pin, Add more sizes, Remove redundant edit-delete

2020-03-23 Thread Noah Davis
ndavis added a comment. In D28228#633141 , @cblack wrote: > Pin icon looks good, but I fail to see how removing edit-delete is a related change in this patch. eh, it's not. I guess I could do it in a separate patch. It's just a pain to

D28228: Update window-pin, Add more sizes, Remove redundant edit-delete

2020-03-23 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D28228 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28228: Update window-pin, Add more sizes, Remove redundant edit-delete

2020-03-23 Thread Noah Davis
ndavis created this revision. ndavis added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY 16 and 22px sizes added for window-pin and unpin. Style was also updated for

D28203: Move corner fold to top right in 24 icons

2020-03-23 Thread Noah Davis
ndavis added a comment. In D28203#632917 , @ngraham wrote: > Why do you think we shouldn't change the copy icon? Then it would be the only one not using the new style. Admittedly, my justification isn't rock solid. I just think it looks

D28203: Move corner fold to top right in 24 icons

2020-03-23 Thread Noah Davis
ndavis added a comment. I don't think we should change the copy icon. Other than that, this patch looks great. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28203 To: davidhurka, #vdg, ndavis Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2,

D28163: Add input-dialpad and call-voicemail

2020-03-22 Thread Noah Davis
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:214dcc72f020: Add input-dialpad and call-voicemail (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES

D28163: Add input-dialpad and call-voicemail

2020-03-20 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28163 To: ndavis, #vdg Cc: ngraham, bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D28163: Add input-dialpad and call-voicemail

2020-03-20 Thread Noah Davis
ndavis updated this revision to Diff 78136. ndavis added a comment. - Use evenly distributed and proportioned style for dialpad REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28163?vs=78107=78136 BRANCH dialpad-voicemail (branched from master)

D28163: Add input-dialpad and call-voicemail

2020-03-20 Thread Noah Davis
ndavis added a comment. In D28163#631474 , @ngraham wrote: > Maybe we could keep the dots 2x2 for the 22px version? You can't get even spacing unless you make it way smaller than a normal 22px icon. REPOSITORY R266 Breeze Icons

D28163: Add input-dialpad and call-voicemail

2020-03-20 Thread Noah Davis
ndavis added a comment. In D28163#631346 , @ngraham wrote: > I thought the margins were maximums. Making the icon skinnier seems fine to me. they are maximums. those guides are at the canvas size. At the correct proportion, it's 22px

D28163: Add input-dialpad and call-voicemail

2020-03-20 Thread Noah Davis
ndavis added a comment. In D28163#631343 , @ngraham wrote: > The 22px dialpad icon looks a bit stretched horizontally to me to my eyes. The others look fine. I agree, but it's really hard to get the proportions right and have it respect

D28163: Add input-dialpad and call-voicemail

2020-03-20 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28163 To: ndavis, #vdg Cc: bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28163: Add input-dialpad and call-voicemail

2020-03-20 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Requested by @bshah for Plasma Mobile REPOSITORY R266 Breeze Icons BRANCH

D27246: add buho icon

2020-03-20 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:01354ce40243: add buho icon (authored by mbruchert, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27246?vs=78086=78088 REVISION DETAIL

D27246: add buho icon

2020-03-20 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R266 Breeze Icons BRANCH buho (branched from master) REVISION DETAIL https://phabricator.kde.org/D27246 To: mbruchert, camiloh, #vdg, ndavis Cc: cblack, ndavis,

D27235: add calindori icon in the new pm style

2020-03-20 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:e715ff69549e: add calindori icon in the new pm style (authored by mbruchert, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D27235: add calindori icon in the new pm style

2020-03-20 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH calindori (branched from master) REVISION DETAIL https://phabricator.kde.org/D27235 To: mbruchert, dkardarakos, #vdg, ndavis Cc: ngraham, kde-frameworks-devel, LeGast00n,

D27210: add KDEconnect Icons

2020-03-20 Thread Noah Davis
ndavis added a comment. Hmm. I'm not into the color icon. These combinations of colors and shapes just seem very foreign to Breeze. If KDE Connect wants to change its icon branding, maybe they should have some elements that are a bit more abstract/stylized than the current color icon? I

D27255: Add nota icon

2020-03-20 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:c40434acbf70: Add nota icon (authored by mbruchert, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27255?vs=78083=78084 REVISION DETAIL

D27255: Add nota icon

2020-03-20 Thread Noah Davis
ndavis retitled this revision from "nota" to "Add nota icon". REPOSITORY R266 Breeze Icons BRANCH nota (branched from master) REVISION DETAIL https://phabricator.kde.org/D27255 To: mbruchert, camiloh, #vdg, ngraham, ndavis Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack,

D27255: nota

2020-03-20 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R266 Breeze Icons BRANCH nota (branched from master) REVISION DETAIL https://phabricator.kde.org/D27255 To: mbruchert, camiloh, #vdg, ngraham, ndavis Cc: ngraham,

D27255: nota

2020-03-19 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. The dotted lines are placed on half pixels, which we should avoid doing. Depending on the look you're going for, you could do either one of the following: - Align the 1px

D27617: [breeze-icons] Add telegram-desktop tray icons

2020-03-18 Thread Noah Davis
ndavis added a subscriber: broulik. ndavis added a comment. In D27617#629987 , @ngraham wrote: > Would it help this use case if we moved the Telegram icon into the Plasma theme for now, pending a fix in Telegram itself? On that subject, has

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

2020-03-18 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:f4a6bf060b0c: [breeze-icons] fix shadow in some user (applets/128) icons (authored by rocka, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

2020-03-18 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. lgtm REPOSITORY R266 Breeze Icons BRANCH fix-user-icon-shadow_2 (branched from master) REVISION DETAIL https://phabricator.kde.org/D28094 To: rocka, #vdg, ndavis Cc: ndavis,

D28114: Add call-incoming/missed/outgoing

2020-03-18 Thread Noah Davis
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:3e095e86bfae: Add call-incoming/missed/outgoing (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE

D28114: Add call-incoming/missed/outgoing

2020-03-18 Thread Noah Davis
ndavis added a comment. In D28114#629728 , @broulik wrote: > Leave the phone in, please. I'm having a hard time grasping the pure arrow icons Android uses in the dialer. I knew I couldn't be the only one :) REPOSITORY R266 Breeze

D28114: Add call-incoming/missed/outgoing

2020-03-18 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28114 To: ndavis, #vdg, cblack Cc: cblack, jbbgameich, bshah, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D28114: Add call-incoming/missed/outgoing

2020-03-18 Thread Noah Davis
ndavis updated this revision to Diff 77889. ndavis added a comment. - Move to status category - Make phone size better and more consistent at 16px REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28114?vs=77877=77889 BRANCH call-history (branched

D28114: Add call-incoming/missed/outgoing

2020-03-18 Thread Noah Davis
ndavis edited the summary of this revision. ndavis edited the test plan for this revision. ndavis added a subscriber: bshah. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28114 To: ndavis, #vdg Cc: bshah, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh,

D28114: Add call-incoming/missed/outgoing

2020-03-18 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH call-history (branched from master) REVISION DETAIL

D25815: Transmission-Qt tray icon added

2020-03-17 Thread Noah Davis
ndavis abandoned this revision. ndavis added a comment. This icon has been added to breeze-icons REVISION DETAIL https://phabricator.kde.org/D25815 To: ndavis, #vdg, ngraham, vinzenzv Cc: broulik, ndavis, ngraham, iasensio, kde-frameworks-devel, LeGast00n, cblack, fbampaloukas, GB_2,

D28111: Add transmission-tray-icon

2020-03-17 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:9895e572d730: Add transmission-tray-icon (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28111?vs=77872=77873 REVISION DETAIL

D28111: Add transmission-tray-icon

2020-03-17 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28111 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28111: Add transmission-tray-icon

2020-03-17 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH transmission (branched from master) REVISION DETAIL

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

2020-03-17 Thread Noah Davis
ndavis added a comment. BTW, you can use this website to search for text in the code of all KDE software: https://lxr.kde.org/search REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28094 To: rocka, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, LeGast00n,

D27617: [breeze-icons] Add telegram-desktop tray icons

2020-03-17 Thread Noah Davis
ndavis added a comment. Unfortunately, it looks like I'll have to revert this patch because when people use a light colorscheme with a dark plasma theme, the icons turn black because the icon is rendered as a pixmap when it has the red counter badge. REPOSITORY R266 Breeze Icons REVISION

D27617: [breeze-icons] Add telegram-desktop tray icons

2020-03-17 Thread Noah Davis
ndavis added a comment. In D27617#629023 , @IlyaBizyaev wrote: > This breaks for people using Breeze for apps and Breeze Dark for Plasma: > F8180783: image.png > > > pass environemnt variable

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

2020-03-17 Thread Noah Davis
ndavis added a comment. In D28094#629427 , @rocka wrote: > Weird, I edited them in Inkscape … > > Aren't those icons used as default avatar in user manager? Nope. Those were actually kept in the user-manager repo until they were

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

2020-03-17 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Can you fix the files for inkscape? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28094 To: rocka, #vdg, ndavis Cc: ndavis, kde-frameworks-devel,

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

2020-03-17 Thread Noah Davis
ndavis added a comment. Hmm. The shadows no longer work correctly in Inkscape, but they work fine in the Qt SVG renderer, which is unusual since usually the Qt SVG renderer is the picky one. REPOSITORY R266 Breeze Icons BRANCH fix-user-icon-shadow (branched from master) REVISION

D28094: [breeze-icons] fix shadow in some user (applets/128) icons

2020-03-17 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I'm not sure if we actually use these anywhere, but the patch looks good to me. REPOSITORY R266 Breeze Icons BRANCH fix-user-icon-shadow (branched from master) REVISION DETAIL

D27416: Add small icons for KeePassXC

2020-03-17 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. LGTM REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27416 To: wsdfhjxc, #vdg, cblack, ndavis Cc: ndavis, cblack, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D28093: [breeze-icons] add TeamViewer tray icons

2020-03-17 Thread Noah Davis
ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH teamviewer-tray (branched from master) REVISION DETAIL https://phabricator.kde.org/D28093 To: rocka, #vdg, ngraham, ndavis Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-03-17 Thread Noah Davis
ndavis added a comment. Is it possible to align all of the reset buttons like a column? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg, ndavis Cc: alexde, ndavis, iasensio, davidre,

D27416: Add small icons for KeePassXC

2020-03-16 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. Since this is a systray icon, you don't actually need to do the 16px version, but I guess there's no harm in having a 16px version. As @cblack said, this needs some work on the pixel alignment. If you don't do the 16px

D25815: Transmission-Qt tray icon added

2020-03-16 Thread Noah Davis
ndavis added a comment. In D25815#628429 , @ngraham wrote: > Does this have to live in the plasma theme? Could it live in the Breeze icon theme? yes, I think I'll move this patch to breeze-icons since there is no longer a name conflict

D25815: Transmission-Qt tray icon added

2020-03-15 Thread Noah Davis
ndavis commandeered this revision. ndavis edited reviewers, added: vinzenzv; removed: ndavis. REVISION DETAIL https://phabricator.kde.org/D25815 To: ndavis, #vdg, ngraham, vinzenzv Cc: broulik, ndavis, ngraham, iasensio, kde-frameworks-devel, LeGast00n, cblack, fbampaloukas, GB_2,

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-03-14 Thread Noah Davis
ndavis added a comment. In D27540#627615 , @ngraham wrote: > @ndavis I know you had some idea for which icon to use, and an idea to make it a clickable button, right? Right, it's like MuseScore: F8176442:

D28050: Add edit-reset

2020-03-14 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:27683f464437: Add edit-reset (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28050?vs=77634=77637 REVISION DETAIL

D28050: Add edit-reset

2020-03-14 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28050 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28050: Add edit-reset

2020-03-14 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY Use this for buttons that reset to the default value REPOSITORY R266 Breeze Icons

D28046: Change document-revert style to be more like edit-undo

2020-03-14 Thread Noah Davis
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:db3092cd945b: Change document-revert style to be more like edit-undo (authored by ndavis). REPOSITORY R266 Breeze

D27444: Added plasmoid heading svg

2020-03-14 Thread Noah Davis
ndavis accepted this revision. REPOSITORY R242 Plasma Framework (Library) BRANCH top_area (branched from master) REVISION DETAIL https://phabricator.kde.org/D27444 To: niccolove, #vdg, ngraham, ndavis Cc: mart, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28046: Change document-revert style to be more like edit-undo

2020-03-14 Thread Noah Davis
ndavis edited the summary of this revision. ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D28046 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D28046: Change document-revert style to be more like edit-undo

2020-03-14 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH document-revert (branched from master) REVISION DETAIL

D27444: Added plasmoid heading svg

2020-03-13 Thread Noah Davis
ndavis added a comment. Why do the outside edges have different opacity from the center part? BTW, this patch is saying it depends on a commit that doesn't exist in git master. REPOSITORY R242 Plasma Framework (Library) BRANCH top_area (branched from master) REVISION DETAIL

D27223: add kirigami-gallery icon

2020-03-12 Thread Noah Davis
ndavis added a comment. In D27223#626722 , @ngraham wrote: > Sorry this got lost. > > Still looks kinda jaggy to me though, especially at 48px.: F8172949: Screenshot_20200312_204742.png > > Do you

T11950: Reduce the pain of working on monochrome Breeze icons

2020-03-10 Thread Noah Davis
ndavis added a comment. @davidhurka pretty impressive. I'll have to try it myself. If the dependencies are minimal and it's easy to use, it might be worth it to have the tool in the breeze icons repo. TASK DETAIL https://phabricator.kde.org/T11950 To: ngraham, ndavis Cc: davidhurka,

D27913: Icons for emoji categories

2020-03-10 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I think I'll want to update some of these icons in the future, particularly the animal icon since that's using another project's mascot. Still, I don't think it'll be a problem since the

D27926: [breeze-icons] Add flameshot tray icons

2020-03-08 Thread Noah Davis
ndavis accepted this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27926 To: axionl, #vdg, ngraham, ndavis Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27926: [breeze-icons] Add flameshot tray icons

2020-03-08 Thread Noah Davis
ndavis added a comment. It's a systray icon, so it doesn't need to have a 16px version REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27926 To: axionl, #vdg, ngraham Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D26595: Add network-wireless-hotspot icon

2020-03-06 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:659e184c49d7: Add network-wireless-hotspot icon (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26595?vs=77142=77151 REVISION DETAIL

D26595: Add network-wireless-hotspot icon

2020-03-06 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D26595 To: ndavis, #vdg, cblack Cc: ndavis, ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D26595: Add network-wireless-hotspot icon

2020-03-06 Thread Noah Davis
ndavis updated this revision to Diff 77142. ndavis added a comment. - Update style REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26595?vs=73316=77142 BRANCH arcpatch-D26595 (branched from master) REVISION DETAIL

D27617: [breeze-icons] Add telegram-desktop tray icons

2020-03-04 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:27740ce26135: [breeze-icons] Add telegram-desktop tray icons (authored by rocka, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D27617: [breeze-icons] Add telegram-desktop tray icons

2020-03-04 Thread Noah Davis
ndavis updated this revision to Diff 76987. ndavis edited the test plan for this revision. ndavis added a comment. Update author info REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27617?vs=76946=76987 BRANCH arcpatch-D27617_1 REVISION DETAIL

D27842: [breeze-icons] New 48px telegram icon

2020-03-04 Thread Noah Davis
ndavis added a comment. In D27842#622396 , @rocka wrote: > Yes, I submitted it via the Web UI. :/ that happens when people submit via the web UI for whatever reason. It'll no longer be an issue when we move KF5 to GitLab, but try to use

D27842: [breeze-icons] New 48px telegram icon

2020-03-04 Thread Noah Davis
ndavis added a comment. That's weird. It should say authored by @rocka, not me. @rocka, how did you submit this patch? Did you submit it via the web UI? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27842 To: rocka, #vdg, ngraham, ndavis Cc: ngraham,

D27842: [breeze-icons] New 48px telegram icon

2020-03-04 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:38dc1aa148d7: [breeze-icons] New 48px telegram icon (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27842?vs=76956=76986 REVISION DETAIL

D27617: [breeze-icons] Add telegram-desktop tray icons

2020-03-04 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. You're pretty good at this. Most newbies struggle with all the little things that can bite you when making breeze icons. REPOSITORY R266 Breeze Icons REVISION DETAIL

D27842: [breeze-icons] New 48px telegram icon

2020-03-04 Thread Noah Davis
ndavis accepted this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27842 To: rocka, #vdg, ngraham, ndavis Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D27851: Add rss icons in action

2020-03-04 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. In D27851#622296 , @cblack wrote: > SVG-wise, optimization here seems suboptimal. There's excess elements that could be removed. > >

D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Noah Davis
ndavis added a subscriber: plasma-devel. ndavis added a comment. It's strange that the plasma-devel mailing list isn't automatically added, even when it's a reviewer group. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D27807 To: niccolove,

D27807: Changed style of pressed list item to be consistent

2020-03-03 Thread Noah Davis
ndavis added a comment. Wouldn't it make more sense to use different pressed and hovered states instead of designing the pressed state to be used as a hover state because the hover state isn't used? Also, it's strange that listitem.svg and viewitem.svg both exist and are both used for

D27787: Remove 48px telegram icons

2020-03-03 Thread Noah Davis
ndavis added a comment. In D27787#621050 , @rocka wrote: > Could we please not remove this icon, or at least keep it available as an alternative? It fits the general style so well. The only way to have alternative icons is to make an

D27794: Fix symlink problem because of using relative path instead of full path

2020-03-02 Thread Noah Davis
ndavis added a comment. Example: F8146162: Screenshot_20200302_233811.PNG I renamed the original breeze-icons repo to breeze-icons2 and the symlinks broke because they were pointing to the source folder instead of the installation folder.

D27794: Fix symlink problem because of using relative path instead of full path

2020-03-02 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Relative links are actually necessary. Otherwise, they won't work when the source repository isn't present. REPOSITORY R266 Breeze Icons REVISION DETAIL

D27787: Remove 48px telegram icons

2020-03-02 Thread Noah Davis
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:8fb85eb7cca0: Remove 48px telegram icons (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST

D27557: Auto-generate 24px monochrome icons

2020-03-02 Thread Noah Davis
ndavis added a comment. Sorry for all the trouble. Unfortunately, neither Nate or I have much experience with CMake or the gotchas of cross platform shellscript and Unix tool support. We'll have to be a lot more careful next time and stick to something with fewer gotchas like Python.

D27617: [breeze-icons] Add telegram-desktop tray icons

2020-03-02 Thread Noah Davis
ndavis added a comment. Sorry, I've been busy lately. I noticed some issues: 1. The distinguishing part of the icon doesn't take up much space, so too much of it gets hidden behind the notification badge. - I'd suggest removing the circle and making the distinguishing part

D27787: Remove 48px telegram icons

2020-03-02 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The style doesn't preserve the original branding very well and the official telegram icon

D27540: KCModule: Indicate when a setting has been changed from the default or previous value

2020-02-25 Thread Noah Davis
ndavis added a comment. I can see the utility in indicating non-default values in some cases, particularly with software that has a lot of necessary complexity in the settings or where non-default values can cause problems (see SVG Cleaner GUI for an example of both). However, I don't think

D27617: [breeze-icons] Add telegram-desktop tray icons

2020-02-24 Thread Noah Davis
ndavis added a comment. In D27617#616925 , @ngraham wrote: > Thanks for the patch! > > But...it's blue: :) > > F8128783: Screenshot_20200224_073346.png Weird. I can't see anything obviously

D27557: Auto-generate 24px monochrome icons

2020-02-24 Thread Noah Davis
ndavis added a comment. Should we just revert for now? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D27557 To: ngraham, #vdg, ndavis, #frameworks, sitter Cc: bcooksley, kossebau, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

<    1   2   3   4   5   6   7   8   9   10   >