D24612: Use the text rather than highlight color for rating/star emblem

2019-10-14 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. This icon never needed to be blue. I think I just kept it blue because that's what it was originally. REPOSITORY R266 Breeze Icons BRANCH monochrome-rating-emblem (branched from

D24621: [RFC] New Konsole and Yakuake icons

2019-10-13 Thread Noah Davis
ndavis added a comment. The Yakuake icon is a major improvement. The little angled rectangle making the prompt arrow look like a Y is a little distracting, but also kind of charming and helps to distinguish it from Konsole. I kind of still prefer the plainer ">_" version though. I

D24537: Icons for windy weather

2019-10-13 Thread Noah Davis
ndavis added a comment. In D24537#546733 , @cblack wrote: > I think cyan is an appropriate choice considering that people tend to associate air with shades of blue, even if air is transparent and that's just the colour of the sky. The shade

D24537: Icons for windy weather

2019-10-11 Thread Noah Davis
ndavis added a comment. In D24537#545451 , @kossebau wrote: > BTW, when it come to weather status icon, I dream of the possibility to simply compose the current status from base elements, instead of having pre-rendered icons. > > So there

D24555: Add draw-arrow icons

2019-10-11 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. > The design is based on `draw-line` with an arrowhead. I think this is a good design. I noticed that LibreOffice already uses a different icon for drawing arrows, but I think this one

D24537: Icons for windy weather

2019-10-11 Thread Noah Davis
ndavis requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24537 To: cblack, #vdg, ndavis Cc: ndavis, kossebau, ngraham, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24537: Icons for windy weather

2019-10-11 Thread Noah Davis
ndavis added a comment. That cyan looks odd. It sticks out way too much and AFAIK, it isn't commonly used to represent wind. Gray on more gray is going to be tricky as well though, especially when you've got partly cloudy vs cloudy. What if the wind was a bit more monochromatic? Wind is

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

2019-10-10 Thread Noah Davis
ndavis added a comment. In D24453#543063 , @ngraham wrote: > Nice. Is there any way to make it touch the edges of its parent view rather than having those small margins? I would like this. I'm not aware of any place where we use margins

D24453: [RFC] Unify style of new Kirigami.ListSectionHeader and CategoryDrawer

2019-10-10 Thread Noah Davis
ndavis added a comment. Why do the gray rectangles have margins around them? I don't like the look very much. REPOSITORY R276 KItemViews BRANCH newcategorystyle (branched from master) REVISION DETAIL https://phabricator.kde.org/D24453 To: davidre, #frameworks, #vdg, #konversation,

D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

2019-10-09 Thread Noah Davis
ndavis added a comment. Thanks REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24477 To: masonm, #vdg, ndavis Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

2019-10-09 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:7fea43c57c59: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24477?vs=67456=67586

D24477: Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

2019-10-09 Thread Noah Davis
ndavis retitled this revision from "[PATCH] Add PATH/LD_LIBRARY_PATH to qrcAlias invocation" to "Add PATH/LD_LIBRARY_PATH to qrcAlias invocation". REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24477 To: masonm, #vdg, ndavis Cc: kde-frameworks-devel, #vdg,

D24477: [PATCH] Add PATH/LD_LIBRARY_PATH to qrcAlias invocation

2019-10-09 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24477 To: masonm, #vdg, ndavis Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D24493: Add draw-highlight action icons

2019-10-08 Thread Noah Davis
ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH add-highlight-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D24493 To: trickyricky26, #vdg, ngraham, ndavis Cc: ngraham, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D24436: Add applications-network icon for renaming Internet category to Network

2019-10-06 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. Eh, it doesn't bother me that much. If you think this is the right thing to do, go ahead. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL

D24436: Add applications-network icon for renaming Internet category to Network

2019-10-06 Thread Noah Davis
ndavis added a comment. If we're just renaming the category, we don't need to also rename the icon in this case. It would break compatibility with 3rd party icon themes and the only upside is a semantically better name. REPOSITORY R266 Breeze Icons REVISION DETAIL

D24412: Add edit-line-width icons

2019-10-05 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH add-line-width-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D24412 To: trickyricky26, #vdg, ndavis Cc: ngraham, ndavis, kde-frameworks-devel,

D24415: Add standard icons to support to all entries in QDialogButtonBox

2019-10-04 Thread Noah Davis
ndavis added inline comments. INLINE COMMENTS > kstyle.cpp:428 > +case QStyle::SP_DialogSaveAllButton: > +return QIcon::fromTheme(QStringLiteral("document-save")); > +case QStyle::SP_DialogAbortButton: why not `document-save-all`? REPOSITORY R252 Framework Integration

D24412: Add edit-line-width icons

2019-10-04 Thread Noah Davis
ndavis added a comment. I think something similar to this line width icon would work well: F6304104: Lines.png Inkscape uses a similar icon, but for all line styles: F7517386: Screenshot_20191004_143517.png

D24318: Make 32px document-save icon colorful

2019-10-04 Thread Noah Davis
ndavis added a comment. In D24318#541952 , @churaev wrote: > In D24318#541839 , @ndavis wrote: > > > How about this? > > F7513643: document-save.svg > >

D24318: Make 32px document-save icon colorful

2019-10-04 Thread Noah Davis
ndavis added a comment. In D24318#542043 , @ngraham wrote: > @ndavis You wanna just submit a patch with that and I'll abandon this? Alright REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24318 To:

D24318: Make 32px document-save icon colorful

2019-10-04 Thread Noah Davis
ndavis added a comment. How about this? F7513643: document-save.svg F7513644: montage.png REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24318 To: ngraham, #vdg, ndavis Cc:

D24253: Make 22px squiggle more like 16px squiggle

2019-10-01 Thread Noah Davis
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R266:e0ef6b7ed41a: Make 22px squiggle more like 16px squiggle (authored by ndavis). REPOSITORY R266 Breeze Icons

D24318: Make 32px document-save icon colorful

2019-09-30 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. - I think this doesn't look enough like the monochrome versions and it looks too much like the KFloppy icon. - Make the label area more similar to the monochrome icons. -

D24314: Improve KFloppy icon

2019-09-30 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. LGTM REPOSITORY R266 Breeze Icons BRANCH better-kfloppy-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D24314 To: ngraham, #vdg, ndavis Cc: ndavis,

D24253: Make 22px squiggle more like 16px squiggle

2019-09-27 Thread Noah Davis
ndavis added a comment. In D24253#538662 , @trickyricky26 wrote: > Visually I think this is fine and a good improvement. > > I wonder why your SVGs have two seperate paths as opposed to unifying them into one path (as I usually do)? Just

D24253: Make 22px squiggle more like 16px squiggle

2019-09-26 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24253 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24253: Make 22px squiggle more like 16px squiggle

2019-09-26 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D24253 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24253: Make 22px squiggle more like 16px squiggle

2019-09-26 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REPOSITORY R266 Breeze Icons BRANCH squiggle (branched from master) REVISION DETAIL

D24185: Add format-text-underline-squiggle actions icons

2019-09-24 Thread Noah Davis
ndavis added a comment. 16px F7426808: format-text-underline-squiggle.svg REPOSITORY R266 Breeze Icons BRANCH format-text-underline-squiggle (branched from master) REVISION DETAIL https://phabricator.kde.org/D24185 To: trickyricky26, #vdg,

D24185: Add format-text-underline-squiggle actions icons

2019-09-24 Thread Noah Davis
ndavis added a comment. F7426794: Screenshot_20190924_222405.png F7426789: Screenshot_20190924_222520.png REPOSITORY R266 Breeze Icons BRANCH format-text-underline-squiggle (branched from master) REVISION

D24185: Add format-text-underline-squiggle actions icons

2019-09-24 Thread Noah Davis
ndavis added a comment. F7426757: Screenshot_20190924_221218.png F7426760: Screenshot_20190924_221251.png REPOSITORY R266 Breeze Icons BRANCH format-text-underline-squiggle (branched from master)

D24185: Add format-text-underline-squiggle actions icons

2019-09-24 Thread Noah Davis
ndavis added a comment. F7426754: 2019-09-24 22.15.33.jpg REPOSITORY R266 Breeze Icons BRANCH format-text-underline-squiggle (branched from master) REVISION DETAIL https://phabricator.kde.org/D24185 To: trickyricky26, #vdg, ngraham Cc: ndavis,

D24185: Add format-text-underline-squiggle actions icons

2019-09-24 Thread Noah Davis
ndavis added a comment. I have some improvement to the squiggle, but unfortunately, I have no internet in my house except on my phone until the 27th. REPOSITORY R266 Breeze Icons BRANCH format-text-underline-squiggle (branched from master) REVISION DETAIL

D12992: New elisa icon

2019-09-20 Thread Noah Davis
ndavis added a comment. icons/apps/22/elisa.svg does not apply cleanly. Not sure why. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D12992 To: lshoravi, #vdg, ngraham, #elisa Cc: trickyricky26, ndavis, KonqiDragon, abetts, paullesur, januz, mgallien, alex-l,

D24091: Move "Full Screen Mode" item from Settings menu to View menu

2019-09-19 Thread Noah Davis
ndavis added a comment. In D24091#534786 , @ngraham wrote: > Do you think I should always have a separator above the Full Screen menu item? This should generally work fine, but it means that in case the `MergeLocal` content is empty, there will

D24091: Move "Full Screen Mode" item from Settings menu to View menu

2019-09-19 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R263 KXmlGui BRANCH move_fullscreen_to_view_menu (branched from master) REVISION DETAIL https://phabricator.kde.org/D24091 To: ngraham, #vdg, #frameworks, cfeck, ndavis Cc: kde-frameworks-devel,

D24015: Added scripts to create a webfont out of all breeze action icons

2019-09-17 Thread Noah Davis
ndavis accepted this revision. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D24015 To: fabianr, ndavis, ognarb Cc: ognarb, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D23942 To: guoyunhe, #breeze, ndavis, GB_2 Cc: GB_2, ndavis, broulik, ngraham, kde-frameworks-devel, LeGast00n, michaelh,

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Noah Davis
ndavis added a comment. In D23942#531337 , @GB_2 wrote: > In D23942#531330 , @ngraham wrote: > > > Shouldn't the checkmark be green? > > > FWIW, both should be black/white. Disabling is not a

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Noah Davis
ndavis added a comment. In D23942#531279 , @guoyunhe wrote: > @ndavis, @broulik, @ngraham, I made some change. Can you have another look? I just noticed that the "No" symbol is backwards. Once you fix that and the hardcoded colors, this

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Noah Davis
ndavis added a comment. Oof, all of the font icons that contain an 'A' need to be cleaned up someday. The 'A's aren't even 16px tall and the line thickness and alignment is all over the place. I guess that's something for another patch. For now, we should maintain consistency with the

D23942: Add enablefont and disablefont icon for kfontinst KCM

2019-09-14 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. There's a bit too much space around the checkmark. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23942 To: guoyunhe, #breeze, ndavis Cc: ndavis,

D23879: Add Qt Designer icon symlink

2019-09-11 Thread Noah Davis
ndavis added a reviewer: ndavis. ndavis added a comment. We should probably redo or completely remove the current Qt icons since they're very Qt4 and look outdated. Unless the current Qt icons are updated, I don't think we should have this symlink. REPOSITORY R266 Breeze Icons REVISION

D23848: Add Breeze icons for Jupyter Notebook files

2019-09-10 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. The spheres around the planet need better pixel alignment, particularly on the 16, 22 and 32px versions. The planet itself could have better pixel alignment too, but it's not as

D10362: Change reveal password button logic

2019-09-08 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D10362 REVISION DETAIL https://phabricator.kde.org/D10362 To: GB_2, #plasma, #vdg, ngraham, broulik, ndavis Cc: ndavis, kde-frameworks-devel,

D23778: Remove superfluous >22px recent documents icons

2019-09-08 Thread Noah Davis
ndavis added a comment. For now In D23778#527622 , @ngraham wrote: > In D23778#527411 , @ndavis wrote: > > > I think we should still have 24px icons for compatibility, but since they're exactly

D23782: Add "edit-none-border" icon

2019-09-08 Thread Noah Davis
ndavis added a comment. This is kind of more like a selection icon than a No Borders icon TBH. I'm not sure if this is really more accurate than `edit-none`. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23782 To: GB_2, #vdg, ndavis Cc: trickyricky26,

D23782: Add "edit-none-border" icon

2019-09-08 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. I think it would be better if this icon had bits int he corners like many of the existing breeze icons: F7330296: Screenshot_20190908_074450.png

D23782: Add "edit-none-border" icon

2019-09-08 Thread Noah Davis
ndavis added a comment. What is this icon used for? REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23782 To: GB_2, #vdg Cc: ndavis, ngraham, broulik, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, bruns

D23778: Remove superfluous >22px recent documents icons

2019-09-07 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Keep the 24px icon for now. It's in Adwaita at 24px too, so there might be some app out there that uses 24px icons. When the repo is setup to generate 24px icons at build time,

D23778: Remove superfluous >22px recent documents icons

2019-09-07 Thread Noah Davis
ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I think we should still have 24px icons for compatibility, but since they're exactly the same as the 22px icons with wider margins, it might be better to generate 24px icons at build time.

D23761: Make small recent documents icons look like documents and improve clock emblems

2019-09-06 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH tweak-recent-document-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D23761 To: ngraham, #vdg, ndavis Cc: kde-frameworks-devel, meven, LeGast00n,

D23761: Make small recent documents icons look like documents and improve clock emblems

2019-09-06 Thread Noah Davis
ndavis added a comment. In D23761#526874 , @ngraham wrote: > While you're at it, we should auto-generate the dark monochrome versions at build-time. There's no good reason to duplicate all of them with only a single difference (changing the

D23761: Make small recent documents icons look like documents and improve clock emblems

2019-09-06 Thread Noah Davis
ndavis added a comment. In D23761#526872 , @ngraham wrote: > This is one of those monochrome action icons that happens to have a 24px version. The 24px version also has a small bug: the horizontal line at the bottom goes a bit too far into the

D23759: Remove unneeded media icons

2019-09-06 Thread Noah Davis
ndavis abandoned this revision. ndavis added a comment. In D23759#526814 , @broulik wrote: > -1 we've had do much trouble when we touched media icons last, and still get bug reports about "missing icons" so i prefer not touching them again for

D23760: Create new "Recent folders" icon

2019-09-06 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH recent-folder-icon (branched from master) REVISION DETAIL https://phabricator.kde.org/D23760 To: ngraham, #vdg, ndavis Cc: ndavis, kde-frameworks-devel, meven, LeGast00n,

D23760: Create new "Recent folders" icon

2019-09-06 Thread Noah Davis
ndavis added a comment. In D23760#526835 , @meven wrote: > Also it seems to me the icon is not very similar to > F7325279: Screenshot_20190906_224006.png > The thickness of the clock pen in

D23760: Create new "Recent folders" icon

2019-09-06 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. Use this 16px icon. It's more similar to the style of the 22px icon. F7325261: Screenshot_20190906_163400.png F7325259:

D23759: Remove unneeded media icons

2019-09-06 Thread Noah Davis
ndavis added a comment. In D23759#526784 , @Leon0402 wrote: > > unless all icons were removed from the desktop theme (all icons would come from the icon theme) > > What's the drawback with that? That not every icon theme has all icons?

D23759: Remove unneeded media icons

2019-09-06 Thread Noah Davis
ndavis added a comment. A few things to consider: If a user uses an icon theme besides Breeze (e.g., Papirus), but keeps using the Breeze desktop theme, they could see a mix of icons from their icon theme and icons from the desktop theme. This is actually already the case in different

D23759: Remove unneeded media icons

2019-09-06 Thread Noah Davis
ndavis created this revision. ndavis added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY These are already provided by most icon themes and there aren't enough sizes in

D23749: Add "preferences-desktop-navigation" icon

2019-09-06 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH master REVISION DETAIL https://phabricator.kde.org/D23749 To: GB_2, #vdg, ndavis Cc: kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, ngraham, bruns

D23738: Add 22px dialog-scripts, change script actions/places icons to match it

2019-09-05 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:939cbf897133: Add 22px dialog-scripts, change script actions/places icons to match it (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D23738: Add 22px dialog-scripts, change script actions/places icons to match it

2019-09-05 Thread Noah Davis
ndavis added a dependent revision: D23740: Change terminal panel icon to dialog-scripts. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23738 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23738: Add 22px dialog-scripts, change script actions/places icons to match it

2019-09-05 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23738 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23738: Add 22px dialog-scripts, change script actions/places icons to match it

2019-09-05 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23738 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23738: Add 22px dialog-scripts, change script actions/places icons to match it

2019-09-05 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY The old ">_" style without the box around it looked odd and the margins were wrong.

D23711: Improve "user-trash" icon

2019-09-04 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH arcpatch-D23711 REVISION DETAIL https://phabricator.kde.org/D23711 To: GB_2, #vdg, ngraham, ndavis Cc: ngraham, kde-frameworks-devel, #vdg, LeGast00n, GB_2, michaelh, bruns

D23711: Improve "user-trash" icon

2019-09-04 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. We're supposed to use 6px margins on the top and bottom, making the visible part of the icon 52px tall. Bottom line shadows are normally supposed to be 1px tall. Other than that,

D23705: Use empty/filled style for monochrome empty/full trash

2019-09-03 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:34fe98546fae: Use empty/filled style for monochrome empty/full trash (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23705?vs=65329=65335

D23627: Make notification icons use outline style

2019-09-03 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R242:db7837d5f5c1: Make notification icons use outline style (authored by ndavis). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D23658: Make notification icons use outline style

2019-09-03 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:e01013922cb9: Make notification icons use outline style (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23658?vs=65309=65333 REVISION

D23705: Use empty/filled style for monochrome empty/full trash

2019-09-03 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23705 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23705: Use empty/filled style for monochrome empty/full trash

2019-09-03 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY We shouldn't rely purely on color to indicate state and red is the wrong color in the

D23685: Make user-trash icons look like trashcans

2019-09-03 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:d970e61493a6: Make user-trash icons look like trashcans (authored by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23685?vs=65268=65322 REVISION

D23685: Make user-trash icons look like trashcans

2019-09-03 Thread Noah Davis
ndavis added a comment. In D23685#525085 , @ngraham wrote: > Actually, that's a great point. The current red appearance is indeed a constant annoyance to me and makes me want to keep it empty all the time, which, now that I think about it,

D23685: Make user-trash icons look like trashcans

2019-09-03 Thread Noah Davis
ndavis added a comment. In D23685#525072 , @ngraham wrote: > In D23685#524935 , @ndavis wrote: > > > > Before, the red folder background made it instantly recognizable that the trash was full--even

D23464: Add breeze icons for ROOT cern files

2019-09-03 Thread Noah Davis
This revision was automatically updated to reflect the committed changes. Closed by commit R266:018b67eff94c: Add breeze icons for ROOT cern files (authored by Marc Henning marc.henni...@rwth-aachen.de, committed by ndavis). REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE

D23464: Add breeze icons for ROOT cern files

2019-09-03 Thread Noah Davis
ndavis added a comment. Looks like you've got everything REPOSITORY R266 Breeze Icons BRANCH ROOT (branched from master) REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis, ngraham Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D23464: Add breeze icons for ROOT cern files

2019-09-03 Thread Noah Davis
ndavis accepted this revision. This revision is now accepted and ready to land. REPOSITORY R266 Breeze Icons BRANCH ROOT (branched from master) REVISION DETAIL https://phabricator.kde.org/D23464 To: alexde, #vdg, ndavis, ngraham Cc: trickyricky26, ndavis, kde-frameworks-devel, LeGast00n,

D23658: Make notification icons use outline style

2019-09-03 Thread Noah Davis
ndavis updated this revision to Diff 65309. ndavis added a comment. Move color preference clapper to center REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23658?vs=65195=65309 BRANCH notifications-outline (branched from master) REVISION DETAIL

D23685: Make user-trash icons look like trashcans

2019-09-03 Thread Noah Davis
ndavis added a comment. In D23685#524775 , @ngraham wrote: > Yay real trashcans The appearance is definitely more appropriate compared to before. I really like it. > > However I'm afraid the visual recognizability of the full state

D23464: Add breeze icons for ROOT cern files

2019-09-02 Thread Noah Davis
ndavis requested changes to this revision. ndavis added a comment. This revision now requires changes to proceed. You're getting there. - 16px: needs 2px margins on the top and bottom - 22px: needs 3px margins on the top and bottom - 32px: needs to be lined up with the pixel grid and

D23685: Make user-trash icons look like trashcans

2019-09-02 Thread Noah Davis
ndavis updated this revision to Diff 65268. ndavis added a comment. Add breeze dark icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23685?vs=65267=65268 BRANCH trash (branched from master) REVISION DETAIL https://phabricator.kde.org/D23685

D23685: Make user-trash icons look like trashcans

2019-09-02 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23685 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23685: Make user-trash icons look like trashcans

2019-09-02 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23685 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23685: Make user-trash icons look like trashcans

2019-09-02 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY BUG: 399613 REPOSITORY R266 Breeze Icons BRANCH trash (branched from master)

D23627: Make notification icons use outline style

2019-09-02 Thread Noah Davis
ndavis added a dependent revision: D23658: Make notification icons use outline style. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23627 To: ndavis, #vdg, #plasma Cc: ngraham, filipf, kde-frameworks-devel, LeGast00n, GB_2, michaelh, bruns

D23658: Make notification icons use outline style

2019-09-02 Thread Noah Davis
ndavis added a dependency: D23627: Make notification icons use outline style. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23658 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23658: Make notification icons use outline style

2019-09-02 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R266 Breeze Icons REVISION DETAIL https://phabricator.kde.org/D23658 To: ndavis, #vdg Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23658: Make notification icons use outline style

2019-09-02 Thread Noah Davis
ndavis updated this revision to Diff 65195. ndavis added a comment. Add breeze dark icons REPOSITORY R266 Breeze Icons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23658?vs=65194=65195 BRANCH notifications-outline (branched from master) REVISION DETAIL

D23658: Make notification icons use outline style

2019-09-02 Thread Noah Davis
ndavis created this revision. ndavis added a reviewer: VDG. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY They didn't quite fit in with the filled style REPOSITORY R266 Breeze Icons BRANCH

D23627: Make notification icons use outline style

2019-09-01 Thread Noah Davis
ndavis added a comment. I could use a modified version of the KAlarm systray icon F7307137: Screenshot_20190901_212547.png REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23627 To: ndavis, #vdg, #plasma Cc:

D23627: Make notification icons use outline style

2019-09-01 Thread Noah Davis
ndavis added a comment. In D23627#523987 , @ngraham wrote: > I kinda like the off-center clapper, but I understand how it might drive OCD people mildly insane. :) However the full-color icon theme notification preferences icon has an off-center

D23627: Make notification icons use outline style

2019-09-01 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23627 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23627: Make notification icons use outline style

2019-09-01 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23627 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23627: Make notification icons use outline style

2019-09-01 Thread Noah Davis
ndavis edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D23627 To: ndavis, #vdg, #plasma Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23627: Make notification icons use outline style

2019-09-01 Thread Noah Davis
ndavis created this revision. ndavis added reviewers: VDG, Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ndavis requested review of this revision. REVISION SUMMARY They didn't quite fit in with the filled style REPOSITORY R242 Plasma Framework

D23464: Add breeze icons for ROOT cern files

2019-08-30 Thread Noah Davis
ndavis added a comment. In D23464#522459 , @alexde wrote: > In D23464#522270 , @trickyricky26 wrote: > > > As @noahdvs mentioned above, the white background should be removed and the entire symbol

<    1   2   3   4   5   6   7   8   9   10   >