Re: Unusual behaviour in KDE Connect CMake

I'll get right on it On Wed, 7 Apr, 2021, 3:02 pm Ben Cooksley, wrote: > Hi all, > > Recently changes were made to kdeconnect-kde that introduced new > dependencies that broke the build on Windows. > > While this in itself is an issue, it has exposed a much more significant > issue which

Re: Unusual behaviour in KDE Connect CMake

On Wed, Apr 7, 2021 at 3:04 PM Piyush Aggarwal wrote: > I'll get right on it > > On Wed, 7 Apr, 2021, 3:02 pm Ben Cooksley, wrote: > >> Hi all, >> >> Recently changes were made to kdeconnect-kde that introduced new >> dependencies that broke the build o

D25119: KF5::BreezeIcons shared library to have all breeze/breeze-dark icons and default to breeze icons set

brute4s99 added subscribers: nicolasfella, brute4s99. brute4s99 added a comment. +1 to adding the breeze icons support for other OSes. (Thanks @nicolasfella for linking me to this diff). I have hit the same problem with the KDE Connect Windows port. Thank you for working on it!

D29258: Don't use notifybysnore.h on MSYS2

brute4s99 added inline comments. INLINE COMMENTS > CMakeLists.txt:75 > if (WIN32) > -find_package(LibSnoreToast REQUIRED) > -set_package_properties(LibSnoreToast PROPERTIES TYPE REQUIRED please maintain the REQUIRED call for normal Windows builds. You can use the OS specific build

D29258: Don't use notifybysnore.h on MSYS2

brute4s99 added a comment. I still do not understand the utility of this patch. What do you hope to fix by this patch exactly? > SnoreToast fails to build on MSYS2 due to missing > which apparently is not available for this compiler. which compiler are you referring to here?

D29461: Fix kio-extras build on Windows

brute4s99 closed this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29461 To: brute4s99, vonreth, meven Cc: sitter, meven, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack,

D29461: Fix kio-extras build on Windows

brute4s99 added a comment. updated libssh to use version 0.9.4 by default in Craft. We can merge this and get  for kio-extras builds. \o/ REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29461 To: brute4s99, vonreth, meven Cc: sitter, meven,

D29461: Fix kio-extras build on Windows

brute4s99 marked an inline comment as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29461 To: brute4s99, vonreth, meven Cc: sitter, meven, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov, iasensio, aprcela, fprice, LeGast00n, cblack,

D29461: Fix kio-extras build on Windows

brute4s99 marked 3 inline comments as done. brute4s99 added inline comments. INLINE COMMENTS > vonreth wrote in CMakeLists.txt:26 > yes pls update libssh Hi! Sorry, I got around to this patch quite late. I added a new patch for 0.9.4 release as parent revision to this revision, please take a

D29461: Fix kio-extras build on Windows

brute4s99 added a dependency: D29835: Add libssh 0.9.4 to fix kio-extras on windows. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29461 To: brute4s99, vonreth, meven Cc: sitter, meven, kde-frameworks-devel, kfm-devel, waitquietly, azyx, nikolaik, pberestov,

D29461: Fix kio-extras build on Windows

brute4s99 updated this revision to Diff 83159. REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29461?vs=82069=83159 BRANCH arcpatch-D29461 REVISION DETAIL https://phabricator.kde.org/D29461 AFFECTED FILES sftp/CMakeLists.txt sftp/kio_sftp.cpp To:

D29461: Fix kio-extras build on Windows

brute4s99 added inline comments. INLINE COMMENTS > sitter wrote in CMakeLists.txt:26 > Hm, I am a bit hazy on the details but I think this changes makes no sense. > libssh (upstream) introduced an imported target `ssh`. For backwards > compatibility we also inject this target when building

D29461: Fix kio-extras build on Windows

brute4s99 added a subscriber: sitter. brute4s99 added a comment. @sitter could you please review this change as well? REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D29461 To: brute4s99, vonreth, meven Cc: sitter, meven, kde-frameworks-devel, kfm-devel, azyx,

D29461: Fix kio-extras build on Windows

brute4s99 updated this revision to Diff 82069. brute4s99 added a comment. updated the diff REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29461?vs=82039=82069 BRANCH arcpatch-D29461 REVISION DETAIL https://phabricator.kde.org/D29461 AFFECTED

D29461: Fix kio-extras build on Windows

brute4s99 updated this revision to Diff 82039. brute4s99 added a comment. needs testing on windows, will update in a while REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29461?vs=82036=82039 BRANCH arcpatch-D29461 REVISION DETAIL

D29461: Fix kio-extras build on Windows

brute4s99 created this revision. brute4s99 added a reviewer: vonreth. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. brute4s99 requested review of this revision. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL

D22554: Finer No-Dbus on Windows

brute4s99 abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22554 To: brute4s99, nicolasfella, broulik Cc: andriusr, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D22554: Finer No-Dbus on Windows

brute4s99 added a comment. closing this diff. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D22554 To: brute4s99, nicolasfella, broulik Cc: andriusr, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29258: Don't use notifybysnore.h on MSYS2

brute4s99 added a comment. > SnoreToast fails to build on MSYS2 due to missing > which apparently is not available for this compiler. I'm sorry, missing what exactly? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D29258 To: wojnilowicz, broulik,

Re: Information regarding upcoming Gitlab Migration

re can be a redirect system that lets us do git clone kde:knotifications and manages to redirect it to kde/frameworks/tier3/knotifications.git So we can clone and tinker with stuff as we normally do while the sysadmin team goes with the recommended system of setting up the repos. I think this should be possible because Invent already redirects my URLs which don't end with .git to .git ones. I might be wrong about my assumption that both things can work similarly. Best Piyush Aggarwal >

D26888: work around to fully support the windows backend

brute4s99 marked 2 inline comments as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26888 To: brute4s99, vonreth, broulik, #kde_connect Cc: albertvaka, meven, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D26888: work around to fully support the windows backend

brute4s99 updated this revision to Diff 80333. brute4s99 added a comment. work around to fully support the windows backend REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26888?vs=74291=80333 BRANCH arcpatch-D26888 REVISION DETAIL

D26801: Really fix the Windows backend for KNotifications

brute4s99 added inline comments. INLINE COMMENTS > broulik wrote in notifybysnore.cpp:200 > Does the notification still end up with an `id` eventually? yes. I've used the id in the new patch REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26801 To: brute4s99,

D26801: Really fix the Windows backend for KNotifications

brute4s99 abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26801 To: brute4s99, vonreth, broulik, #kde_connect Cc: anthonyfieroni, kde-frameworks-devel, nalvarez, KunalRaghav, ankitbaluni, ankit, aliencode, Orage, ritwizsinha, LeGast00n,

D26888: work around to fully support the windows backend

brute4s99 reclaimed this revision. brute4s99 added a comment. sorry. abandoned wrong diff REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26888 To: brute4s99, vonreth, broulik, #kde_connect Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26888: work around to fully support the windows backend

brute4s99 added reviewers: vonreth, broulik, KDE Connect. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26888 To: brute4s99, vonreth, broulik, #kde_connect Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26801: Really fix the Windows backend for KNotifications

brute4s99 marked 2 inline comments as done. brute4s99 added a comment. I will be closing this diff as I recently formed a simpler patch. Inviting your reviews on that one! https://phabricator.kde.org/D26888 REPOSITORY R289 KNotifications REVISION DETAIL

D26888: work around to fully support the windows backend

brute4s99 abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26888 To: brute4s99, vonreth, broulik, #kde_connect Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26888: work around to fully support the windows backend

brute4s99 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REVISION SUMMARY really support the windows backend. REPOSITORY R289 KNotifications BRANCH windows (branched from master)

D26801: Really fix the Windows backend for KNotifications

brute4s99 updated this revision to Diff 74190. brute4s99 marked 2 inline comments as done. brute4s99 added a comment. updated REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26801?vs=74005=74190 BRANCH arcpatch-D26801 REVISION DETAIL

D26801: Really fix the Windows backend for KNotifications

brute4s99 marked an inline comment as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D26801 To: brute4s99, vonreth, broulik, #kde_connect Cc: anthonyfieroni, kde-frameworks-devel, nalvarez, KunalRaghav, ankitbaluni, ankit, aliencode, Orage, ritwizsinha,

D26801: Really fix the Windows backend for KNotifications

brute4s99 updated this revision to Diff 74005. brute4s99 marked 3 inline comments as done. brute4s99 added a comment. update the diff. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26801?vs=73983=74005 BRANCH master REVISION DETAIL

D26801: Really fix the Windows backend for KNotifications

brute4s99 added inline comments. INLINE COMMENTS > brute4s99 wrote in notifybysnore.cpp:143 > KNotif objects by default have `d->id = -1` > > `notify()` is invoked by the base with -1 ID and later updated with the > correct ID and the actions. > > Weirdly though, `pairingRequest`

D26801: Really fix the Windows backend for KNotifications

brute4s99 added inline comments. INLINE COMMENTS > notifybysnore.cpp:143 > { > -Q_UNUSED(config); > -// HACK work around that notification->id() is only populated after > returning from here > -// note that config will be invalid at that point, so we can't pass that > along > -

D26801: Really fix the Windows backend for KNotifications

brute4s99 created this revision. brute4s99 added reviewers: vonreth, broulik, KDE Connect. brute4s99 added a project: KDE Connect. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REVISION SUMMARY This patch fixes

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

brute4s99 added a comment. we need this because the symbols being currently used are Unix-only. Porting to Qt supplied ones allows this plugin to work on other OSes (my concern: Windows) as well.  REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22727 To:

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

brute4s99 added a comment. In D22727#513842 , @dfaure wrote: > The truth is stronger than "I would not recommend". > put() in SlaveBase-derived classes is called by the KIO library (TransferJob), so you CANNOT change the meaning of the

D23313: improve code in Snore backend

brute4s99 abandoned this revision. brute4s99 added a comment. in that case I should rather leave this diff. I agree this would be messy for the history. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D23313 To: brute4s99, broulik Cc: kde-frameworks-devel,

D23313: improve code in Snore backend

brute4s99 created this revision. brute4s99 added a reviewer: broulik. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REPOSITORY R289 KNotifications BRANCH master REVISION DETAIL

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

brute4s99 added a comment. landed it! F7262311: shufflefurtherparrot.gif REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D23133 To: brute4s99, #frameworks, broulik Cc: nicolasfella, ngraham, broulik,

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

This revision was automatically updated to reflect the committed changes. Closed by commit R289:a9b61d5b0cb8: avoid duplicate notifications from showing up on Windows and remove whitespaces (authored by brute4s99). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23133?vs=63846=64122#toc

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

brute4s99 added a subscriber: nicolasfella. brute4s99 added a comment. In D23133#515156 , @ngraham wrote: > Just on Windows, or does this fix the problem on Linux too? that problem has been fixed by @nicolasfella on master of

D23196: have 1024x1024 app icon as fallback icon in Snore

This revision was automatically updated to reflect the committed changes. Closed by commit R289:e96bf17d8cac: have 1024x1024 app icon as fallback icon in Snore (authored by brute4s99). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23196?vs=64119=64120

D23196: have 1024x1024 app icon as fallback icon in Snore

brute4s99 updated this revision to Diff 64119. brute4s99 added a comment. changed line endings to Unix style REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23196?vs=64115=64119 BRANCH arcpatch-D23196 REVISION DETAIL

D23291: have application's icon as fallback icon in Snore

brute4s99 updated this revision to Diff 64118. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23291?vs=64116=64118 BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23291 AFFECTED FILES src/notifybysnore.cpp To: brute4s99 Cc:

D23291: have application's icon as fallback icon in Snore

brute4s99 abandoned this revision. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D23291 To: brute4s99 Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D23291: have application's icon as fallback icon in Snore

brute4s99 created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REPOSITORY R289 KNotifications BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23291 AFFECTED FILES

D23196: have 1024x1024 app icon as fallback icon in Snore

brute4s99 added a comment. landing it! F7262311: shufflefurtherparrot.gif REPOSITORY R289 KNotifications BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23196 To: brute4s99, #frameworks, broulik, sredman Cc: sredman,

D23196: have 1024x1024 app icon as fallback icon in Snore

brute4s99 updated this revision to Diff 64115. brute4s99 retitled this revision from "have the app icon as fallback icon in Snore" to "have 1024x1024 app icon as fallback icon in Snore". brute4s99 added a comment. removed `actualSize` in favour of always passing an icon of size 1024x1024 to

D23196: have the app icon as fallback icon in Snore

brute4s99 updated this revision to Diff 64114. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23196?vs=64113=64114 BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23196 AFFECTED FILES src/notifybysnore.cpp To: brute4s99,

D23196: have the app icon as fallback icon in Snore

brute4s99 updated this revision to Diff 64113. brute4s99 added a comment. rebased REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23196?vs=63984=64113 BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23196 AFFECTED FILES

D23196: have the app icon as fallback icon in Snore

brute4s99 added a comment. landing it! F7262311: shufflefurtherparrot.gif REPOSITORY R289 KNotifications BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23196 To: brute4s99, #frameworks, broulik, sredman Cc: sredman,

D23282: add `-pid` parameter to Snore backend calls

This revision was automatically updated to reflect the committed changes. Closed by commit R289:ee5c3d12f965: add `-pid` parameter to Snore backend calls (authored by brute4s99). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23282?vs=64111=64112

D23282: add `-pid` parameter to Snore backend calls

brute4s99 updated this revision to Diff 64111. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23282?vs=64110=64111 BRANCH pid (branched from master) REVISION DETAIL https://phabricator.kde.org/D23282 AFFECTED FILES src/notifybysnore.cpp To:

D23282: add `-pid` parameter to Snore backend calls

brute4s99 updated this revision to Diff 64110. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23282?vs=64085=64110 BRANCH pid (branched from master) REVISION DETAIL https://phabricator.kde.org/D23282 AFFECTED FILES src/notifybysnore.cpp To:

D23282: add `-pid` parameter to Snore backend calls

brute4s99 added a comment. had some non-unix line endings, so updated the diff. REPOSITORY R289 KNotifications BRANCH pid (branched from master) REVISION DETAIL https://phabricator.kde.org/D23282 To: brute4s99, #kde_connect, #frameworks, vonreth Cc: kde-frameworks-devel, vonreth,

D23282: add `-pid` parameter to Snore backend calls

brute4s99 added a comment. landing it! F7262311: shufflefurtherparrot.gif REPOSITORY R289 KNotifications BRANCH pid (branched from master) REVISION DETAIL https://phabricator.kde.org/D23282 To: brute4s99, #kde_connect, #frameworks, vonreth Cc:

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

brute4s99 added a comment. can I merge this one?  REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D23133 To: brute4s99, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23282: add `-pid` parameter to Snore backend calls

brute4s99 added a dependency: D23273: Allow to pass pid in addition to appID try to deduce appID from pid. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D23282 To: brute4s99, #kde_connect, #frameworks Cc: kde-frameworks-devel, vonreth, LeGast00n, michaelh,

D23282: add `-pid` parameter to Snore backend calls

brute4s99 created this revision. brute4s99 added reviewers: KDE Connect, Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REVISION SUMMARY the upcoming change to SnoreToast also accepts `process id`.

D23196: have the app icon as fallback icon in Snore

brute4s99 added a comment. may I land this now?  REPOSITORY R289 KNotifications BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23196 To: brute4s99, #frameworks, broulik, sredman Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23196: have the app icon as fallback icon in Snore

brute4s99 updated this revision to Diff 63984. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23196?vs=63981=63984 BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23196 AFFECTED FILES src/notifybysnore.cpp To: brute4s99,

D23196: have the app icon as fallback icon in Snore

brute4s99 marked 2 inline comments as done. REPOSITORY R289 KNotifications BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23196 To: brute4s99, #frameworks, broulik, sredman Cc: sredman, broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23196: have the app icon as fallback icon in Snore

brute4s99 updated this revision to Diff 63981. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23196?vs=63888=63981 BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23196 AFFECTED FILES src/CMakeLists.txt

D23196: have the app icon as fallback icon in Snore

brute4s99 added a reviewer: broulik. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D23196 To: brute4s99, #frameworks, broulik Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D23196: have the app icon as fallback icon in Snore

brute4s99 updated this revision to Diff 63888. brute4s99 added a comment. updated REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23196?vs=63847=63888 BRANCH arcpatch-D23196 REVISION DETAIL https://phabricator.kde.org/D23196 AFFECTED FILES

D23196: have the app icon as fallback icon in Snore

brute4s99 marked 3 inline comments as done. brute4s99 added inline comments. INLINE COMMENTS > broulik wrote in notifybysnore.cpp:163 > The explicit call to `actualSize` shouldn't be neccessary just to be sure :) but if there's a check implemented already somewhere within QIcon, I'd happily

D23196: have the app icon as fallback icon in Snore

brute4s99 created this revision. brute4s99 added a reviewer: Frameworks. brute4s99 added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REVISION SUMMARY by this patch, apps with a set WindowIcon will have that icon as

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

brute4s99 updated this revision to Diff 63846. brute4s99 added a comment. took inspiration from NotifyByAndroid. Now I can see all types of notifications perfectly well! REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23133?vs=63674=63846 BRANCH

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

brute4s99 added a comment. the duplicate notification always has id= -1, so I think it's more an issue of KNotifications, I think REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D23133 To: brute4s99, #frameworks Cc: broulik, kde-frameworks-devel, LeGast00n,

D23133: avoid duplicate notifications from showing up on Windows and remove whitespaces

brute4s99 created this revision. brute4s99 added a reviewer: Frameworks. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. brute4s99 requested review of this revision. REVISION SUMMARY without this patch, most notifications show every notification twice. This

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 added a comment. In D21661#510813 , @vkrause wrote: > It looks like this made D-Bus and Phonon hard required dependencies on Android again!?

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

brute4s99 added a comment. In D22727#505540 , @dfaure wrote: > The Qt documentation says "Warning: Because of differences in the platforms supported by Qt, the semantics of ReadUser, WriteUser and ExeUser are platform-dependent: On Unix, the

D21661: add snoretoast backend for KNotifications on Windows

This revision was automatically updated to reflect the committed changes. Closed by commit R289:d00612351778: add snoretoast backend for KNotifications on Windows (authored by brute4s99). REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 marked an inline comment as done. REPOSITORY R289 KNotifications BRANCH arcpatch-D21661 REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 63558. brute4s99 added a comment. removed duplication REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=63551=63558 BRANCH arcpatch-D21661 REVISION DETAIL https://phabricator.kde.org/D21661

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 63551. brute4s99 added a comment. rebased. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=63549=63551 BRANCH arcpatch-D21661 REVISION DETAIL https://phabricator.kde.org/D21661 AFFECTED FILES

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 63549. brute4s99 added a comment. landing this one.  REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=63538=63549 BRANCH arcpatch-D21661 REVISION DETAIL https://phabricator.kde.org/D21661

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 marked 2 inline comments as done. brute4s99 added a comment. done. REPOSITORY R289 KNotifications BRANCH arcpatch-D21661 REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: nicolasfella, pino, kde-frameworks-devel,

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 added a comment. waiting for some green light(s) for now... REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 63538. brute4s99 added a comment. - removed the duplicate remover. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=62374=63538 BRANCH arcpatch-D21661 REVISION DETAIL

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 added a comment. landing it... REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

brute4s99 added inline comments. INLINE COMMENTS > pino wrote in kio_sftp.cpp:383 > sounds like you need to use the *User enums, not the *Owner ones https://www.gnu.org/software/libc/manual/html_node/Permission-Bits.html The link says these bits refer to the owner of the file. Should I still

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 added inline comments. INLINE COMMENTS > win32_defaults.notifyrc:90 > +Comment[zh_TW]=程式發生了嚴重錯誤，必須離開 > +Action=Snore > + Can someone please confirm if this file is correctly used? REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99,

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 added a comment. Please do a last minute review, I believe this patch is ready to merge now.  REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: nicolasfella, pino, kde-frameworks-devel,

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

brute4s99 added a comment. In D22727#501824 , @vonreth wrote: > Looks good. > Why not the first time  I was afraid of reverts  REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D22727 To:

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

brute4s99 created this revision. brute4s99 added a reviewer: vonreth. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. brute4s99 requested review of this revision. TEST PLAN should build on windows with mingw as compiler should build on

D22554: Finer No-Dbus on Windows

brute4s99 updated this revision to Diff 62383. brute4s99 added a comment. let's put a pin in this for a while until I get a better solution for DBus on Windows REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22554?vs=62069=62383 BRANCH

D21660: remove dbus for windows build and change audio dep logic

brute4s99 added a comment. sorry about that. I'll find a better solution that doesn't break builds  REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21660 To: brute4s99, broulik, nicolasfella Cc: aspotashev, bcooksley, apol, nicolasfella,

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 marked 2 inline comments as done. REPOSITORY R289 KNotifications REVISION DETAIL https://phabricator.kde.org/D21661 To: brute4s99, broulik, sredman, vonreth, albertvaka Cc: nicolasfella, pino, kde-frameworks-devel, LeGast00n, sbergeron, michaelh, ngraham, bruns

D21661: add snoretoast backend for KNotifications on Windows

brute4s99 updated this revision to Diff 62374. brute4s99 marked an inline comment as done. brute4s99 added a comment. updated and rebased. REPOSITORY R289 KNotifications CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21661?vs=61084=62374 BRANCH arcpatch-D21661 REVISION DETAIL

D22659: Fix bracket

brute4s99 accepted this revision. This revision is now accepted and ready to land. REPOSITORY R320 KIO Extras BRANCH master REVISION DETAIL https://phabricator.kde.org/D22659 To: vonreth, brute4s99 Cc: kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, fbampaloukas,

D22659: Fix bracket

brute4s99 added a comment. thanks Hannah! REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22659 To: vonreth, brute4s99 Cc: kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, fbampaloukas, alexde, feverfew, meven, michaelh, spoorun,

D22105: Fix SFTP Plugin of KIO for Windows

brute4s99 retitled this revision from "WIP : Fix SFTP Plugin of KIO for Windows" to "Fix SFTP Plugin of KIO for Windows". REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure Cc: pino, andriusr,

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 marked 2 inline comments as done. brute4s99 added a comment. I'll not leave it like this from next time, that's for sure. :p REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure Cc: pino,

D22105: Fix SFTP Plugin of KIO for Windows

brute4s99 added a comment. :p REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, fbampaloukas, alexde,

D22105: WIP : Fix SFTP Plugin of KIO for Windows

This revision was automatically updated to reflect the committed changes. Closed by commit R320:d6d724b9d4b9: WIP : Fix SFTP Plugin of KIO for Windows (authored by brute4s99). REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22105?vs=62254=62255 REVISION

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 added a comment. should've removed WIP before landing  REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n,

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 added a comment. yeah I can push! I'm a GSoCer lol REPOSITORY R320 KIO Extras BRANCH arcpatch-D22105 REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela,

D22105: WIP : Fix SFTP Plugin of KIO for Windows

brute4s99 marked an inline comment as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D22105 To: brute4s99, albertvaka, vonreth, sredman, sitter, dfaure Cc: pino, andriusr, kde-frameworks-devel, kfm-devel, aprcela, fprice, LeGast00n, sbergeron, fbampaloukas,

  1   2   >