D17425: Added DCB settings

pranavgade updated this revision to Diff 47338. pranavgade marked 7 inline comments as done. REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17425?vs=47282=47338 REVISION DETAIL https://phabricator.kde.org/D17425 AFFECTED FILES

D17474: A minor bug in ipv4 and ipv6 test

pranavgade added a comment. In D17474#374522 , @pranavgade wrote: > This change causes the ipv4 address test to fail due to a difference in size of list. > [F6468448 ] D17497: A minor typo in

D17497: A minor typo in ipv4 test

pranavgade created this revision. pranavgade added reviewers: jgrulich, cfeck. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pranavgade requested review of this revision. REVISION SUMMARY A minor typo in ipv4setting test was causing the test to fail after

D17425: Added DCB settings

pranavgade retitled this revision from "dcb settings" to "Added DCB settings". pranavgade edited the summary of this revision. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17425 To: pranavgade, jgrulich Cc: cfeck, kde-frameworks-devel, michaelh, ngraham,

D17425: dcb settings

pranavgade updated this revision to Diff 47282. pranavgade marked an inline comment as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17425?vs=47279=47282 REVISION DETAIL https://phabricator.kde.org/D17425 AFFECTED FILES autotests/settings/CMakeLists.txt

D17425: dcb settings

pranavgade updated this revision to Diff 47279. pranavgade marked 4 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17425?vs=47270=47279 REVISION DETAIL https://phabricator.kde.org/D17425 AFFECTED FILES autotests/settings/CMakeLists.txt

D17425: dcb settings

pranavgade added a comment. Sorry, I had forgot about that. REVISION DETAIL https://phabricator.kde.org/D17425 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17425: dcb settings

pranavgade updated this revision to Diff 47270. pranavgade marked 6 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17425?vs=47267=47270 REVISION DETAIL https://phabricator.kde.org/D17425 AFFECTED FILES autotests/settings/CMakeLists.txt

D17474: A minor bug in ipv4 and ipv6 test

pranavgade added a comment. This change causes the ipv4 address test to fail due to a difference in size of list. [F6468448 ] REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17474 To: pranavgade, jgrulich Cc:

D17474: A minor bug in ipv4 and ipv6 test

pranavgade created this revision. pranavgade added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pranavgade requested review of this revision. REVISION SUMMARY Some QCOMPAREs were comparing a value in a map with itself. Fixed.

D17425: dcb settings

pranavgade updated this revision to Diff 47267. pranavgade marked an inline comment as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17425?vs=47263=47267 REVISION DETAIL https://phabricator.kde.org/D17425 AFFECTED FILES autotests/settings/CMakeLists.txt

D17425: dcb settings

pranavgade updated this revision to Diff 47263. pranavgade marked 4 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17425?vs=47261=47263 REVISION DETAIL https://phabricator.kde.org/D17425 AFFECTED FILES autotests/settings/CMakeLists.txt

D17425: dcb settings

pranavgade added inline comments. INLINE COMMENTS > jgrulich wrote in dcbsetting.cpp:59 > Yes please. Okay, im on it But on the other hand, it will add 12 functions unnecessarily REVISION DETAIL https://phabricator.kde.org/D17425 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh,

D17425: dcb settings

pranavgade updated this revision to Diff 47261. pranavgade marked 2 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17425?vs=47253=47261 REVISION DETAIL https://phabricator.kde.org/D17425 AFFECTED FILES autotests/settings/CMakeLists.txt

D17425: dcb settings

pranavgade marked 12 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D17425 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17425: dcb settings

pranavgade updated this revision to Diff 47253. pranavgade marked 15 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17425?vs=47243=47253 REVISION DETAIL https://phabricator.kde.org/D17425 AFFECTED FILES autotests/settings/CMakeLists.txt

D17425: dcb settings

pranavgade added inline comments. INLINE COMMENTS > jgrulich wrote in dcbsetting.cpp:464 > Oh, right, you don't have methods for that. In that case you can again use > Q_D(const DcbSetting) and push there d->priorityFlowControl and others. I can use Q_D in fromMap, but i get this error in

D17425: dcb settings

pranavgade marked an inline comment as done. pranavgade added inline comments. INLINE COMMENTS > jgrulich wrote in dcbsetting.cpp:31 > You can initialize also all the lists here, because they have default values > as well. how do i do that? i am getting this error: error: class

D17425: dcb settings

pranavgade updated this revision to Diff 47243. pranavgade marked 7 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17425?vs=47235=47243 REVISION DETAIL https://phabricator.kde.org/D17425 AFFECTED FILES autotests/settings/CMakeLists.txt

D17425: dcb settings

pranavgade added a comment. Hey! Could you please check and let me know which of the first two commits you prefer? Thanks! REVISION DETAIL https://phabricator.kde.org/D17425 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17425: dcb settings

pranavgade updated this revision to Diff 47139. pranavgade added a comment. Alternate way to do a part of the task CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17425?vs=47092=47139 REVISION DETAIL https://phabricator.kde.org/D17425 AFFECTED FILES

D17425: dcb settings

pranavgade created this revision. pranavgade added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pranavgade requested review of this revision. REVISION SUMMARY added dcb settings according to :

D17381: macsec setting

pranavgade updated this revision to Diff 47027. pranavgade marked 7 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17381?vs=47021=47027 REVISION DETAIL https://phabricator.kde.org/D17381 AFFECTED FILES autotests/settings/CMakeLists.txt

D17381: macsec setting

pranavgade updated this revision to Diff 47021. pranavgade marked 8 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17381?vs=46975=47021 REVISION DETAIL https://phabricator.kde.org/D17381 AFFECTED FILES autotests/settings/CMakeLists.txt

D17381: macsec setting

pranavgade added inline comments. INLINE COMMENTS > pranavgade wrote in macsecsetting.h:58 > From where can I get the possible values? Because I cannot find them here: > https://developer.gnome.org/NetworkManager/stable/settings-macsec.html (I mean the default values to use in the defines)

D17381: macsec setting

pranavgade updated this revision to Diff 46975. pranavgade marked 3 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17381?vs=46958=46975 REVISION DETAIL https://phabricator.kde.org/D17381 AFFECTED FILES autotests/settings/CMakeLists.txt

D17381: macsec setting

pranavgade added inline comments. INLINE COMMENTS > jgrulich wrote in macsecsettingtest.cpp:29 > This required version is not true, please verify it properly, I'm not going > to do it every time :). I tried to get the version from here: F6459587: Screenshot from 2018-12-06 22-13-34.png

D17381: macsec setting

pranavgade updated this revision to Diff 46958. pranavgade added a comment. rebased on master CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17381?vs=46953=46958 REVISION DETAIL https://phabricator.kde.org/D17381 AFFECTED FILES autotests/settings/CMakeLists.txt

D17381: macsec setting

pranavgade created this revision. pranavgade added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pranavgade requested review of this revision. REVISION SUMMARY Added macsec setting according to:

D17342: team-port setting

pranavgade updated this revision to Diff 46946. pranavgade marked an inline comment as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17342?vs=46940=46946 REVISION DETAIL https://phabricator.kde.org/D17342 AFFECTED FILES autotests/settings/CMakeLists.txt

D17342: team-port setting

pranavgade updated this revision to Diff 46940. pranavgade marked 2 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17342?vs=46905=46940 REVISION DETAIL https://phabricator.kde.org/D17342 AFFECTED FILES autotests/settings/CMakeLists.txt

D17342: team-port setting

pranavgade updated this revision to Diff 46905. pranavgade marked 4 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17342?vs=46896=46905 REVISION DETAIL https://phabricator.kde.org/D17342 AFFECTED FILES autotests/settings/CMakeLists.txt

D17342: team-port setting

pranavgade updated this revision to Diff 46896. pranavgade marked 8 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17342?vs=46830=46896 REVISION DETAIL https://phabricator.kde.org/D17342 AFFECTED FILES autotests/settings/CMakeLists.txt

D17342: team-port setting

pranavgade updated this revision to Diff 46830. pranavgade added a comment. add missing indents CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17342?vs=46829=46830 REVISION DETAIL https://phabricator.kde.org/D17342 AFFECTED FILES autotests/settings/CMakeLists.txt

D17342: team-port setting

pranavgade created this revision. pranavgade added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pranavgade requested review of this revision. REVISION SUMMARY Added team-port setting according to:

D17317: match and tc setting

pranavgade updated this revision to Diff 46826. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17317?vs=46825=46826 REVISION DETAIL https://phabricator.kde.org/D17317 AFFECTED FILES autotests/settings/CMakeLists.txt autotests/settings/matchsettingtest.cpp

D17317: match and tc setting

pranavgade updated this revision to Diff 46825. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17317?vs=46824=46825 REVISION DETAIL https://phabricator.kde.org/D17317 AFFECTED FILES autotests/settings/CMakeLists.txt autotests/settings/matchsettingtest.cpp

D17317: match and tc setting

pranavgade added a comment. In D17317#371009 , @jgrulich wrote: > The tcsettingtest is failing. Why, exactly? REVISION DETAIL https://phabricator.kde.org/D17317 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham,

D17317: match and tc setting

pranavgade updated this revision to Diff 46824. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17317?vs=46792=46824 REVISION DETAIL https://phabricator.kde.org/D17317 AFFECTED FILES autotests/settings/CMakeLists.txt autotests/settings/matchsettingtest.cpp

D17317: match and tc setting

pranavgade updated this revision to Diff 46792. pranavgade marked an inline comment as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17317?vs=46789=46792 REVISION DETAIL https://phabricator.kde.org/D17317 AFFECTED FILES autotests/settings/CMakeLists.txt

D17317: match and tc setting

pranavgade updated this revision to Diff 46789. pranavgade marked 4 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17317?vs=46786=46789 REVISION DETAIL https://phabricator.kde.org/D17317 AFFECTED FILES autotests/settings/CMakeLists.txt

D17317: match and tc setting

pranavgade updated this revision to Diff 46786. pranavgade marked 3 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17317?vs=46785=46786 REVISION DETAIL https://phabricator.kde.org/D17317 AFFECTED FILES autotests/settings/CMakeLists.txt

D17317: match and tc setting

pranavgade updated this revision to Diff 46785. pranavgade marked 5 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17317?vs=46761=46785 REVISION DETAIL https://phabricator.kde.org/D17317 AFFECTED FILES autotests/settings/CMakeLists.txt

D17317: match and tc setting

pranavgade added inline comments. INLINE COMMENTS > jgrulich wrote in tcsettingtest.cpp:69 > I think that you cannot compare NMVariantMaps this way, that's why probably > the test for IPv4 and IPv6 didn't fail when we swapped values for route-data > and address-data. You will need to compare

D17317: match and tc setting

pranavgade updated this revision to Diff 46761. pranavgade marked 9 inline comments as done. REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17317?vs=46724=46761 REVISION DETAIL https://phabricator.kde.org/D17317 AFFECTED FILES

D17317: match and tc setting

pranavgade created this revision. pranavgade added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pranavgade requested review of this revision. REVISION SUMMARY Added match and tc setting according to:

D17252: ovs-patch and ovs-port setting

pranavgade updated this revision to Diff 46708. pranavgade marked 2 inline comments as done. REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17252?vs=46674=46708 REVISION DETAIL https://phabricator.kde.org/D17252 AFFECTED FILES

D17252: ovs-patch and ovs-port setting

pranavgade updated this revision to Diff 46674. pranavgade marked 4 inline comments as done. REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17252?vs=46543=46674 REVISION DETAIL https://phabricator.kde.org/D17252 AFFECTED FILES

D17258: Fixed a bug(error?) in ipv4 & ipv6 settings

pranavgade created this revision. pranavgade added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pranavgade requested review of this revision. REVISION SUMMARY Fixed a couple of misplaced lines of code REPOSITORY R282

D17252: ovs-patch and ovs-port setting

pranavgade created this revision. pranavgade added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pranavgade requested review of this revision. REVISION SUMMARY Added ovs-patch and ovs-port setting according to:

D17239: ovs-bridge and ovs-interface setting

pranavgade updated this revision to Diff 46542. pranavgade marked an inline comment as done. REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17239?vs=46537=46542 REVISION DETAIL https://phabricator.kde.org/D17239 AFFECTED FILES

D17239: ovs-bridge and ovs-interface setting

pranavgade updated this revision to Diff 46537. pranavgade marked 8 inline comments as done. pranavgade added a comment. Made the required changes REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17239?vs=46491=46537 REVISION DETAIL

D17251: Update Ip-tunnel settings

pranavgade created this revision. pranavgade added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pranavgade requested review of this revision. REVISION SUMMARY Fixed a few things in ip-tunnel settings REPOSITORY R282

D17239: ovs-bridge and ovs-interface setting

pranavgade created this revision. pranavgade added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pranavgade requested review of this revision. REVISION SUMMARY Added ovs-bridge and ovs-interface setting according to:

D17210: Added proxy and user settings

pranavgade updated this revision to Diff 46488. pranavgade marked 2 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17210?vs=46469=46488 REVISION DETAIL https://phabricator.kde.org/D17210 AFFECTED FILES autotests/settings/CMakeLists.txt

D17210: Added proxy and user settings

pranavgade set the repository for this revision to R282 NetworkManagerQt. REPOSITORY R282 NetworkManagerQt REVISION DETAIL https://phabricator.kde.org/D17210 To: pranavgade, jgrulich Cc: cfeck, ngraham, kde-frameworks-devel, michaelh, bruns

D17210: Added proxy and user settings

pranavgade marked 3 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D17210 To: pranavgade, jgrulich Cc: ngraham, kde-frameworks-devel, michaelh, bruns

D17210: Added proxy and user settings

pranavgade marked 3 inline comments as done. pranavgade added inline comments. INLINE COMMENTS > jgrulich wrote in proxysetting.cpp:25 > It looks that the proxy setting has been introduced in NetworkManager 1.6. > This means that for all property defines, you have to add ifdef the same way >

D17210: Added proxy and user settings

pranavgade updated this revision to Diff 46469. pranavgade added a comment. made some changes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17210?vs=46467=46469 REVISION DETAIL https://phabricator.kde.org/D17210 AFFECTED FILES autotests/settings/CMakeLists.txt

D17210: Added proxy and user settings

pranavgade updated this revision to Diff 46467. pranavgade marked 6 inline comments as done. pranavgade added a comment. Updated code as required, fixed a minor error in iptunnelsettings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17210?vs=46444=46467 REVISION DETAIL

D17210: Added proxy and user settings

pranavgade updated this revision to Diff 46444. pranavgade added a comment. Updated diff from prev commit->changes to latest commit->changes CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17210?vs=46392=46444 REVISION DETAIL https://phabricator.kde.org/D17210 AFFECTED FILES

D17210: Added proxy and user settings

pranavgade created this revision. pranavgade added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pranavgade requested review of this revision. REVISION SUMMARY Added proxy and user settings according to:

D17185: Added ip-tunnel settings

pranavgade updated this revision to Diff 46376. pranavgade removed a subscriber: kde-frameworks-devel. pranavgade added a comment. Made a few minor changes REPOSITORY R282 NetworkManagerQt CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17185?vs=46310=46376 REVISION DETAIL

D17185: Added ip-tunnel settings

pranavgade marked 5 inline comments as done. pranavgade added inline comments. INLINE COMMENTS > jgrulich wrote in iptunnelsettingtest.cpp:79 > Use NetworkManager defines, do not define your own new defines, there is no > reason for that. I tried to follow the way it is done in ipv6settings.

D17185: Added ip-tunnel settings

pranavgade created this revision. pranavgade added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pranavgade requested review of this revision. REVISION SUMMARY Added ip-tunnel settings according to