D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

sredman added a comment. In D22727#513842 , @dfaure wrote: > The truth is stronger than "I would not recommend". > put() in SlaveBase-derived classes is called by the KIO library (TransferJob), so you CANNOT change the meaning of the

D23196: have the app icon as fallback icon in Snore

sredman accepted this revision. sredman added a comment. This revision is now accepted and ready to land. Since KNotifications on Windows is so far only used by you anyway, I say it's fine to merge. @broulik, any objections? INLINE COMMENTS > notifybysnore.cpp:157 > +

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

sredman added a comment. In D22727#510698 , @brute4s99 wrote: > In D22727#505540 , @dfaure wrote: > > > But, wait, this code is mixing "int permissions" (*) with the QFileDevice enum, that doesn't

D21661: add snoretoast backend for KNotifications on Windows

sredman accepted this revision. sredman added a comment. This revision is now accepted and ready to land. I noticed a couple of places where the cmake file could be simplified so make those changes and then let's land this monster INLINE COMMENTS > CMakeLists.txt:76 > +if (NOT WIN32) > +

D21661: add snoretoast backend for KNotifications on Windows

sredman added a comment. In D21661#476571 , @pino wrote: > In D21661#476156 , @pino wrote: > > > how is snoretoast actually used here? you are requiring the library for building and linking, but

D21661: add snoretoast backend for KNotifications on Windows

sredman added inline comments. INLINE COMMENTS > CMakeLists.txt:43 > +if (WIN32) > + if (MSVC) > + find_package(LibSnoreToast REQUIRED) Do you know whether this requires MSVC, or can SnoreToast.exe be built with MSVC and KNotifications be built with an unspecified compiler? >

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

sredman added a comment. In D21369#469389 , @apol wrote: > Seems like a clear layer break to spill KContacts over KPeople :P. > Let's discuss it at the sprint? Or earlier. Let's discuss it? ^^' Sounds good REPOSITORY R307 KPeople

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

sredman edited the summary of this revision. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D21369 To: sredman, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

sredman updated this revision to Diff 58565. sredman added a comment. - Hack on QMetaType support REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21369?vs=58561=58565 BRANCH kcontacts-phonenumber REVISION DETAIL https://phabricator.kde.org/D21369

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

sredman added a dependent revision: D21374: WIP: Add support for KContacts::PhoneNumber-related custom data fields. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D21369 To: sredman, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

sredman updated this revision to Diff 58561. sredman added a comment. - Add link_library target to backends as well REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21369?vs=58556=58561 BRANCH kcontacts-phonenumber REVISION DETAIL

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

sredman added a reviewer: apol. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D21369 To: sredman, apol Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

sredman updated this revision to Diff 58556. sredman added a comment. - Move KF5::Contacts to PUBLIC library REPOSITORY R307 KPeople CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21369?vs=58553=58556 BRANCH kcontacts-phonenumber REVISION DETAIL

D21369: [WIP] Add AbstractContact properties for KContact::PhoneNumber objects

sredman created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. sredman requested review of this revision. REVISION SUMMARY - Add phone number getters to PersonData - Add KContact::PhoneNumber properties to AbstractContact Does not

D16692: A QApplication object needs to be instantiated for kio-kdeconnect to work on KDE Neon

sredman added a comment. This is going to be our cleanest patch ever once we've had everybody and their grandmother look at it. I guess this is what happens when you fix a hot bug!  In D16692#354783 , @jriddell wrote: > I can recreate the