D17816: Support for xattrs on kio copy/move

tmarshall added inline comments. INLINE COMMENTS > dfaure wrote in copyjob.cpp:1119 > That sounds racy; the subjob might not be finished by the time the main job > is finished, if you just "start and forget". > > I cannot accept this commit with an exec() in here. The easy and modern way > to

D17816: Support for xattrs on kio copy/move

tmarshall added inline comments. INLINE COMMENTS > tmarshall wrote in copyjob.cpp:1119 > Please help me understand for a moment. I'm not the original author of this > patch and am trying to bring it to completion. I just need to be caught up to > speed. In reading this piece of code over, I

D17816: Support for xattrs on kio copy/move

tmarshall updated this revision to Diff 72144. tmarshall added a comment. - Added helper functions to clean up tests REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=72135=72144 BRANCH arcpatch-D17816 REVISION DETAIL

D17816: Support for xattrs on kio copy/move

tmarshall marked 7 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: tmarshall, dfaure, chinmoyr, bruns, #frameworks, cochise Cc: tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham,

D17816: Support for xattrs on kio copy/move

tmarshall updated this revision to Diff 72135. tmarshall added a comment. - Addressed comments, changed xattr system calls to use file descriptors where possible REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=72131=72135 BRANCH arcpatch-D17816

D17816: Support for xattrs on kio copy/move

tmarshall added inline comments. INLINE COMMENTS > dfaure wrote in copyjob.cpp:1119 > That sounds racy; the subjob might not be finished by the time the main job > is finished, if you just "start and forget". > > I cannot accept this commit with an exec() in here. The easy and modern way > to

D17816: Support for xattrs on kio copy/move

tmarshall marked 9 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: tmarshall, dfaure, chinmoyr, bruns, #frameworks, cochise Cc: tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham,

D17816: Support for xattrs on kio copy/move

tmarshall marked 4 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: tmarshall, dfaure, chinmoyr, bruns, #frameworks, cochise Cc: tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham,

D17816: Support for xattrs on kio copy/move

tmarshall updated this revision to Diff 72131. tmarshall added a comment. - Addressed comments REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17816?vs=49487=72131 BRANCH arcpatch-D17816 REVISION DETAIL https://phabricator.kde.org/D17816 AFFECTED FILES

D17816: Support for xattrs on kio copy/move

tmarshall marked 7 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: tmarshall, dfaure, chinmoyr, bruns, #frameworks, cochise Cc: tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham,

D17816: Support for xattrs on kio copy/move

tmarshall marked 6 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: tmarshall, dfaure, chinmoyr, bruns, #frameworks, cochise Cc: tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham,

D17816: Support for xattrs on kio copy/move

tmarshall marked 9 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: tmarshall, dfaure, chinmoyr, bruns, #frameworks, cochise Cc: tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino, davidedmundson, ngraham,

D17816: Support for xattrs on kio copy/move

tmarshall commandeered this revision. tmarshall added a reviewer: cochise. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D17816 To: tmarshall, dfaure, chinmoyr, bruns, #frameworks, cochise Cc: tmarshall, arrowd, cfeck, bruns, phidrho, dhaumann, funkybomber, abika, pino,

D17816: Support for xattrs on kio copy/move

tmarshall added inline comments. INLINE COMMENTS > copyxattrjob.cpp:67 > + * The CopyXattrJob is a very simple job. Reads the list of keys > + * and copies each attribute. As a fast operation, don' need to > + * be able to suspend. "don'" -> "don't" REPOSITORY R241 KIO REVISION DETAIL

D13805: Present error dialog when user tries to create directory named "." or ".."

tmarshall added a comment. In D13805#299580 , @elvisangelaccio wrote: > @tmarshall Do you have commit access? I do not. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13805 To: tmarshall, #dolphin, #frameworks,

D13805: Present error dialog when user tries to create directory named "." or ".."

tmarshall updated this revision to Diff 38050. tmarshall marked 8 inline comments as done. tmarshall added a comment. I've made the requested changes. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13805?vs=36954=38050 REVISION DETAIL

D13805: Present error dialog when user tries to create directory named "." or ".."

tmarshall added a comment. Sorry for the delay @ngraham . I've been traveling. I'll have these changes complete by the end of today. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13805 To: tmarshall, #dolphin, #frameworks, ngraham, dfaure, elvisangelaccio Cc: cfeck,

D13805: Present error dialog when user tries to create directory named "." or ".."

tmarshall added a comment. @ngraham Name: Thomas Marshall Email: tmarshall7...@gmail.com REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13805 To: tmarshall, #dolphin, #frameworks, ngraham, dfaure Cc: cfeck, elvisangelaccio, dfaure, tmarshall, bruns, ngraham

D13805: Present error dialog when user tries to create directory named "." or ".."

tmarshall added a comment. @elvisangelaccio The check has to come before the check for `name.startsWith('.')` because that's what launches the "The name starts with a ." dialog. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13805 To: tmarshall, #dolphin,

D13805: Present error dialog when user tries to create directory named "." or ".."

tmarshall added a comment. How am I to provide my name and email? Just in a comment? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13805 To: tmarshall, #dolphin, #frameworks, ngraham Cc: tmarshall, bruns, ngraham, kde-frameworks-devel, michaelh, spoorun,

D13805: Present error dialog when user tries to create directory named "." or ".."

tmarshall marked an inline comment as done. tmarshall added inline comments. INLINE COMMENTS > bruns wrote in knewfilemenu.cpp:873 > Should be QMessageBox::Error in this case I get `newfilemenu.cpp:873:74: error: ‘Error’ is not a member of ‘QMessageBox’` `QMessageBox::Critical` seems to work

D13805: Present error dialog when user tries to create directory named "." or ".."

tmarshall updated this revision to Diff 36954. tmarshall marked 2 inline comments as done. tmarshall added a comment. Changed `QMessageBox::Warning` to `QMessageBox::Critical` and updated the error message. New: F5981803: image.png REPOSITORY

D13805: Present error dialog when user tries to create directory named "." or ".."

tmarshall updated this revision to Diff 36952. tmarshall added a comment. Fixed a type in the comment and improved the wording of the error message. New: F5981755: image.png REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D13805: Present error dialog when user tries to create directory named "." or ".."

tmarshall created this revision. tmarshall added a reviewer: Dolphin. tmarshall added a project: Dolphin. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. tmarshall requested review of this revision. REVISION SUMMARY BUG: