D28045: Lua: add # as additional deliminator to activate auto-completion with `#something`

2020-03-14 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH lua (branched from master) REVISION DETAIL

D28044: C: remove ' as digit separator

2020-03-14 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY This is not in C standard, but only in C++ REPOSITORY R216 Syntax Highlighting

D27714: C++: constinit keyword and std::format syntax for strings. Improvement printf format.

2020-02-27 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH cpp (branched from master) REVISION DETAIL

D24939: Meson: more built-in functions and add built-in member functions

2019-10-27 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:9181ad6fedae: Meson: more built-in functions and add built-in member functions (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24939?vs=68727=68838#toc REPOSITORY R216

D24939: Meson: more built-in functions and add built-in member functions

2019-10-24 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH meson (branched from master) REVISION DETAIL

D24578: Meson: Add a comment section for comment/uncomment with Kate

2019-10-12 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:1371441ef57b: Meson: Add a comment section for comment/uncomment with Kate (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24578?vs=67758=67823#toc REPOSITORY R216

D24578: Meson: Add a comment section for comment/uncomment with Kate

2019-10-11 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH meson (branched from master) REVISION DETAIL

D24326: Add syntax highlighting for RenPy (.rpy)

2019-10-05 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:4e278a1c3e47: Add syntax highlighting for RenPy (.rpy) (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24326?vs=67235=67358

D24326: Add syntax highlighting for RenPy (.rpy)

2019-10-02 Thread jonathan poelen
jpoelen updated this revision to Diff 67235. jpoelen added a comment. - Renpy: folding sensitive to indentation REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24326?vs=67094=67235 BRANCH renpy (branched from master) REVISION DETAIL

D24326: Add syntax highlighting for RenPy (.rpy)

2019-09-30 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY BUG: 381547 REPOSITORY R216 Syntax Highlighting BRANCH renpy (branched from

D24179: Fix skipOffset with dynamic RegExpr

2019-09-26 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:d6b1e02ad4da: Fix skipOffset with dynamic RegExpr (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24179?vs=66788=66928#toc REPOSITORY R216 Syntax Highlighting CHANGES

D24179: Fix skipOffset with dynamic RegExpr

2019-09-24 Thread jonathan poelen
jpoelen updated this revision to Diff 66788. jpoelen added a comment. - add a comment REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24179?vs=66724=66788 BRANCH d399388 (branched from master) REVISION DETAIL

D24180: Jam: fix identifier in a SubRule

2019-09-24 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:c409eb751b91: Jam: fix identifier in a SubRule (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24180?vs=66725=66789 REVISION

D24180: Jam: fix identifier in a SubRule

2019-09-23 Thread jonathan poelen
jpoelen created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH jam_check_ident (branched from master) REVISION DETAIL

D24179: Fix skipOffset with dynamic RegExpr

2019-09-23 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY The pattern used depends on the previous contexts so skipOffset cannot be computed

D24176: Add syntax definition for Perl6

2019-09-23 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:5e0343812c22: Add syntax definition for Perl6 (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24176?vs=66720=66721#toc REPOSITORY R216 Syntax Highlighting CHANGES

D24176: Add syntax definition for Perl6

2019-09-23 Thread jonathan poelen
jpoelen updated this revision to Diff 66720. jpoelen added a comment. Perl: increase version... over and over again :) REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24176?vs=66718=66720 BRANCH perl6 (branched from master) REVISION DETAIL

D24176: Add syntax definition for Perl6

2019-09-23 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY BUG: 392468 REPOSITORY R216 Syntax Highlighting BRANCH perl6 (branched from

D23513: Gettext: Add "Translated String" style and spellChecking attribute

2019-08-27 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:0f150cafac4b: Gettext: Add Translated String style and spellChecking attribute (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23513?vs=64782=64783#toc REPOSITORY R216

D23513: Gettext: Add "Translated String" style and spellChecking attribute

2019-08-27 Thread jonathan poelen
jpoelen updated this revision to Diff 64782. jpoelen added a comment. - increase version REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23513?vs=64775=64782 BRANCH po_spellcheck (branched from master) REVISION DETAIL

D23513: Gettext: Add "Translated String" style and spellChecking attribute

2019-08-27 Thread jonathan poelen
jpoelen edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23513 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns,

D23513: Gettext: Add "Translated String" style and spellChecking attribute

2019-08-27 Thread jonathan poelen
jpoelen edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23513 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, GB_2, domson, michaelh, ngraham, bruns,

D23513: Gettext: Add "Translated String" style and spellChecking attribute

2019-08-27 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY New style ("Translated String") for a string associated with msgstr and

D23416: Highlighting indexer: check kateversion

2019-08-24 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY Checks that files using are in version 5.53 and that contexts do not reference a

D23312: JSP: support of

2019-08-21 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:433e5d85979c: JSP: support of script and style ; use IncludeRule ##Java (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23312?vs=64183=64259#toc REPOSITORY R216 Syntax

D23312: JSP: support of

2019-08-20 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY BUG: 345003 REPOSITORY R216 Syntax Highlighting BRANCH jsp (branched from

D23278: LESS: import CSS keywords, new highlighting and some improvements

2019-08-20 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:63719f49867b: LESS: import CSS keywords, new highlighting and some improvements (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23278?vs=64078=64182#toc REPOSITORY

D23278: LESS: import CSS keywords, new highlighting and some improvements

2019-08-20 Thread jonathan poelen
jpoelen added a comment. The other files that use the include statement are also in version 5.53. If highlightingindexer adds a version check, it is also necessary to check that the included files are of the same or lower version. Ideally, this should also be done for IncludeRules.

D23278: LESS: import CSS keywords, new highlighting and some improvements

2019-08-19 Thread jonathan poelen
jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23278 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson,

D23278: LESS: import CSS keywords, new highlighting and some improvements

2019-08-19 Thread jonathan poelen
jpoelen created this revision. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. jpoelen requested review of this revision. REVISION SUMMARY New highlighting (same as CSS): - Value Keyword - Color - Number - Unit Improvements

D23245: New syntax: SASS. Some fixes for CSS and SCSS

2019-08-19 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:0edc0cb01ab7: New syntax: SASS. Some fixes for CSS and SCSS (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23245?vs=63987=64075#toc REPOSITORY R216 Syntax

D23245: New syntax: SASS. Some fixes for CSS and SCSS

2019-08-18 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY CSS, SCSS (CSS4): - number in scientific notation: `12.3e3` - hexadecimal

D23195: SCSS: fix interpolation (#{...}) and add the Interpolation color

2019-08-15 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY Only interpolation with variable (`#{$...}`) and beginning of the string

D23135: Gettext: fix "previous untranslated string" and other improvements/fixes

2019-08-15 Thread jonathan poelen
jpoelen added a comment. If it is better not to have a hard-coded color, wouldn't it be better to remove them once and for all? Without necessarily incrementing the version. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23135 To: jpoelen,

D14632: keyword rule: Spport for keywords inclusion from another language/file

2019-08-15 Thread jonathan poelen
jpoelen added a comment. I don't think using the original word delimiters is a good thing. Let's imagine that c.xml lists the functions of the libc and a language that allows them to be used as `ffi.C.printf` (luajit for the curious). The separators of the 2 languages are not the same and

D23134: fix additionalDeliminator attribute

2019-08-14 Thread jonathan poelen
jpoelen updated this revision to Diff 63771. jpoelen added a comment. - add unit test REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23134?vs=63683=63771 BRANCH fix_wordDelimiters (branched from master) REVISION DETAIL

D23137: C++: contracts are not in C++20

2019-08-13 Thread jonathan poelen
jpoelen updated this revision to Diff 63689. jpoelen added a comment. - increase version REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23137?vs=63686=63689 BRANCH cpp_no_contract (branched from master) REVISION DETAIL

D23137: C++: contracts are not in C++20

2019-08-13 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY For C ++ 23 or C ++ 26 with perhaps a syntax change REPOSITORY R216 Syntax

D23136: Jam: Fix local with variable without initilisation and highlight SubRule

2019-08-13 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH fix_jam (branched from master) REVISION DETAIL

D23135: Gettext: fix "previous untranslated string" and other improvements/fixes

2019-08-13 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY - fix #| (previous untranslated string) - fix hexadecimal entity - fix html tag

D23134: fix additionalDeliminator attribute

2019-08-13 Thread jonathan poelen
jpoelen added a comment. I don't understand why there's so much difference in what's displayed :/ REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D23134 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel,

D23134: fix additionalDeliminator attribute

2019-08-13 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY The initialization of the `Rule::m_wordDelimiter` cache was done before the

D23034: implicit fallthough if there is fallthoughContext

2019-08-09 Thread jonathan poelen
jpoelen updated this revision to Diff 63455. jpoelen added a comment. - don't modify the *.xml files to maintain the compatibility in older versions of KF5 - langauge.xsd: accept only 1 or true for fallthrough attribute REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D23034: implicit fallthough if there is fallthoughContext

2019-08-09 Thread jonathan poelen
jpoelen added a comment. I will hand over the original xml files, that seems preferable to me too. I did not see `fallthrough="false"` nor `fallthrough="0"`. But after checking, `brightscript.xml` uses` fallthroughContext` twice without `fallthrough`. in my opinion, it's an oblivion

D23034: implicit fallthough if there is fallthoughContext

2019-08-08 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY fallthrough="true" is redundant with fallthroughContext="xxx" and there is no reason

D23013: Latex: several fixes (math mode, nested verbatim, ...)

2019-08-08 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:75e233dc5792: Latex: several fixes (math mode, nested verbatim, ...) (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23013?vs=63378=63379#toc REPOSITORY R216 Syntax

D23013: Latex: several fixes (math mode, nested verbatim, ...)

2019-08-08 Thread jonathan poelen
jpoelen edited the summary of this revision. REPOSITORY R216 Syntax Highlighting BRANCH tex (branched from master) REVISION DETAIL https://phabricator.kde.org/D23013 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: nibags, kde-frameworks-devel, kwrite-devel, univerz,

D23013: Latex: several fixes (math mode, nested verbatim, ...)

2019-08-08 Thread jonathan poelen
jpoelen added a comment. The 410477 did not exist when I started my modifications, I add it in the list. REPOSITORY R216 Syntax Highlighting BRANCH tex (branched from master) REVISION DETAIL https://phabricator.kde.org/D23013 To: jpoelen, #framework_syntax_highlighting, dhaumann,

D23013: Latex: several fixes (math mode, nested verbatim, ...)

2019-08-08 Thread jonathan poelen
jpoelen updated this revision to Diff 63378. jpoelen added a comment. At first, I didn't have much change. But as I broke my teeth on one of the bugs and there were some problems here and there, I armed myself with a bulldozer :D REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST

D23014: Lua: fix color of end with several levels of condition and function nesting

2019-08-08 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:2b06bf42be04: Lua: fix color of end with several levels of condition and function nesting (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23014?vs=63376=63377#toc

D23014: Lua: fix color of end with several levels of condition and function nesting

2019-08-08 Thread jonathan poelen
jpoelen updated this revision to Diff 63376. jpoelen added a comment. increase the version number REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23014?vs=63320=63376 BRANCH lua (branched from master) REVISION DETAIL

D23015: Highlighting indexer: all warnings are fatal

2019-08-07 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH warning_as_error (branched from master) REVISION DETAIL

D23014: Lua: fix color of end with several levels of condition and function nesting

2019-08-07 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY if x then function foo() if x then end -- control (before:

D23013: Latex: several fixes (math mode, nested verbatim, ...)

2019-08-07 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY - nested { and macro identifier with math mode - add shortintertext, Cref, param

D21586: Add syntax definition for ninja build

2019-06-29 Thread jonathan poelen
jpoelen added a comment. After reflection (:D), I think the constraint is weak, the creation of new syntax is rare compared to the rest. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21586 To: jpoelen, #framework_syntax_highlighting, dhaumann,

D21586: Add syntax definition for ninja build

2019-06-08 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:a72b6b5e53ec: Add syntax definition for ninja build (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21586?vs=59240=59421

D21586: Add syntax definition for ninja build

2019-06-05 Thread jonathan poelen
jpoelen updated this revision to Diff 59240. jpoelen added a comment. I am confused, the generation of index.katesyntax fails because the list "variables" does not exist (there is no variable predefined in this context). We may be in a situation where a change of branch does not recompile

D21587: Lua: update for Lua54 and end of function as Keyword rather than Control

2019-06-04 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:602bbc7b7397: Lua: update for Lua54 and end of function as Keyword rather than Control (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE

D21508: Jam: various improvements and fixes

2019-06-04 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:6864c25f1d54: Jam: various improvements and fixes (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21508?vs=59150=59164 REVISION

D21585: C++: update for C++20

2019-06-04 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:9ba02971123d: C++: update for C++20 (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21585?vs=59156=59162 REVISION DETAIL

D21585: C++: update for C++20

2019-06-04 Thread jonathan poelen
jpoelen updated this revision to Diff 59156. jpoelen added a comment. oops, missing version increase REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21585?vs=59152=59156 BRANCH cpp2a (branched from master) REVISION DETAIL

D21587: Lua: update for Lua54 and end of function as Keyword rather than Control

2019-06-04 Thread jonathan poelen
jpoelen edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D21587 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, gennad, bmortimer, domson, michaelh,

D21587: Lua: update for Lua54 and end of function as Keyword rather than Control

2019-06-04 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Framework: Syntax Highlighting, Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY function foo() if x then end <--- Control

D21586: Add syntax definition for ninja build

2019-06-04 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Framework: Syntax Highlighting, Kate, Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH ninja (branched from

D21585: C++: update for C++20

2019-06-04 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Framework: Syntax Highlighting, Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY - new attributes: assert, ensures and expects - new

D21508: Jam: various improvements and fixes

2019-06-04 Thread jonathan poelen
jpoelen updated this revision to Diff 59150. jpoelen added a comment. - fix module - remove hard coded color REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21508?vs=58930=59150 BRANCH fix_jam (branched from master) REVISION DETAIL

D21508: Jam: various improvements and fixes

2019-06-01 Thread jonathan poelen
jpoelen added a comment. I left it because it goes well with dark or light themes, but I removed it. Is the policy the same for bold, underlined and italic as for color? Because a basic applied distinction between Comment and CommentTitle seems to me preferable. I imagine not, but I would

D21508: Jam: various improvements and fixes

2019-05-30 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY - fix `x=`: is a rule named `x=`, not a variable - fix `exe onx`: is a rule

D21421: Tcsh: fix operators and keywords

2019-05-30 Thread jonathan poelen
jpoelen added a comment. OK I understand. Initially I had not changed the version number of txsh.xml and it is based on the reference in `/usr/share/org.kde.syntax-highlighting/syntax/index.katesyntax` rather than in the repository. And the fact that the versions in the index file were

D21421: Tcsh: fix operators and keywords

2019-05-27 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:4d2329e3f63e: Tcsh: fix operators and keywords (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21421?vs=58696=58742 REVISION

D21421: Tcsh: fix operators and keywords

2019-05-27 Thread jonathan poelen
jpoelen added a comment. I forgot to ask about running the tests. Is it normal that system syntax files take precedence if we have an `index.katesyntax`? Currently I have to run the tests by setting the environment variable `XDG_DATA_DIRS`. REPOSITORY R216 Syntax Highlighting BRANCH

D21421: Tcsh: fix operators and keywords

2019-05-26 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann, cullmann. jpoelen added projects: Framework: Syntax Highlighting, Kate, Frameworks. jpoelen requested review of this revision. REVISION SUMMARY - missing `foreach` and `end` - fix folding with

D10621: Highlighting Indexer: list of suggestions

2019-01-09 Thread jonathan poelen
jpoelen added a comment. I agree that some rules are excessive or even false, but the last time I watched (it was several months ago now), some regexes suggested to be DetectString seemed to have writing errors (mainly `\\` count as 2 characters in xml) and some more or less useful

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-09-30 Thread jonathan poelen
jpoelen updated this revision to Diff 42628. jpoelen added a comment. - fix the recursion detection and handling of nested included keyword lists REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14632?vs=41872=42628 BRANCH kwinclude REVISION

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-09-17 Thread jonathan poelen
jpoelen added a comment. (I inadvertently edit the operators list in the previous commit) Finally, I added a parameter to `load()` and `loadHighlighting()` rather than a new function because there was a lot of code duplication. REPOSITORY R216 Syntax Highlighting REVISION DETAIL

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-09-17 Thread jonathan poelen
jpoelen updated this revision to Diff 41872. jpoelen added a comment. - restore operators list - lazy load keyword lists REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14632?vs=41298=41872 BRANCH kwinclude REVISION DETAIL

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-09-16 Thread jonathan poelen
jpoelen added a comment. `resolveIncludeKeywords()` would then use `loadKeywords()` instead of `load()` ? This should be enough. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14632 To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann Cc:

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-09-15 Thread jonathan poelen
jpoelen added a comment. Sorry to answer so late, I had trouble logging in. I think I misinterpreted the use of `includedDefinitions()`. For me, this function lists the languages ​included by the rules and which influence the colors. While the inclusion of a keyword list has no

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-09-09 Thread jonathan poelen
jpoelen updated this revision to Diff 41298. jpoelen added a comment. include rule in keyword list to import those from another file REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14632?vs=39138=41298 BRANCH kwinclude REVISION DETAIL

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

2018-08-19 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:3ebb3c09e512: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle) (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11470?vs=32861=40010#toc

D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting

2018-08-19 Thread jonathan poelen
jpoelen added a comment. Yes, my compilation folder was pointing to my fork on github from which I make the patches (as I do not have the right version for ECM, I have a script that does among other things a new CMakeLists.txt in another folder and adds symbolic links for project files).

D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting

2018-08-19 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:113ebe28645a: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting (authored by jpoelen). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14603?vs=39067=40004#toc REPOSITORY

D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting

2018-08-13 Thread jonathan poelen
jpoelen added a comment. Ok, i'm doing this in the week. REPOSITORY R216 Syntax Highlighting BRANCH scss REVISION DETAIL https://phabricator.kde.org/D14603 To: jpoelen, #framework_syntax_highlighting, dhaumann, vkrause, cullmann Cc: cullmann, kwrite-devel, dhaumann,

D11470: SQL: various improvements and fix if/case/loop/end detection with SQL (Oracle)

2018-08-13 Thread jonathan poelen
jpoelen added a comment. There have been changes in the xml files that will cause conflicts. I would look in the next few days. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D11470 To: jpoelen, #framework_syntax_highlighting, dhaumann, cullmann Cc:

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-08-06 Thread jonathan poelen
jpoelen added a comment. I just thought of `Definition::keywordLists()` which does not list the keywords used by this new syntax. - Should we add the lists used as and when parsing? - Move the functionality on the tag ``? (``, ` name##language `) - Other? REPOSITORY R216

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-08-06 Thread jonathan poelen
jpoelen edited the summary of this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14632 To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann Cc: kwrite-devel, vkrause, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns,

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-08-05 Thread jonathan poelen
jpoelen edited the summary of this revision. jpoelen edited the test plan for this revision. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14632 To: jpoelen, #framework_syntax_highlighting, cullmann, dhaumann Cc: kwrite-devel, vkrause,

D14632: keyword rule: Spport for keywords inclusion from another language/file

2018-08-05 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, cullmann, dhaumann. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. jpoelen requested review of this revision. REVISION

D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting

2018-08-04 Thread jonathan poelen
jpoelen added a comment. Yes, I can start tomorrow. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14603 To: jpoelen, #framework_syntax_highlighting, dhaumann, vkrause Cc: cullmann, kwrite-devel, dhaumann, kde-frameworks-devel,

D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting

2018-08-04 Thread jonathan poelen
jpoelen added a comment. I copied all the keywords in the css.xml file and it's a shame. I think that Keyword could refer to those of other files with `##` as for IncludeRules. REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14603 To: jpoelen,

D14603: SCSS: update syntax. CSS: fix Operator and Selector Tag highlighting

2018-08-04 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. jpoelen requested review of this revision. REPOSITORY R216

D14434: add functions to access keywords

2018-07-27 Thread jonathan poelen
jpoelen added a comment. This follows https://mail.kde.org/pipermail/kde-frameworks-devel/2018-July/066564.html REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14434 To: jpoelen, #framework_syntax_highlighting, dhaumann Cc: kde-frameworks-devel,

D14434: add functions to access keywords

2018-07-27 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: kwrite-devel. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting

D14282: CSS: fix test reference of the previous commit

2018-07-23 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:a82af177bc2f: CSS: fix test reference of the previous commit (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14282?vs=38217=38277

D14283: C++: fix standard floating-point literals

2018-07-23 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:7a2ae6be229b: C++: fix standard floating-point literals (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14283?vs=38218=38276

D14283: C++: fix standard floating-point literals

2018-07-22 Thread jonathan poelen
jpoelen created this revision. jpoelen added reviewers: Framework: Syntax Highlighting, dhaumann. Restricted Application added projects: Kate, Frameworks. Restricted Application added a subscriber: kwrite-devel. jpoelen requested review of this revision. REVISION SUMMARY BUG: 389693 REPOSITORY

D14282: CSS: fix test reference of the previous commit

2018-07-22 Thread jonathan poelen
jpoelen created this revision. jpoelen added a reviewer: dhaumann. Restricted Application added projects: Kate, Frameworks. jpoelen requested review of this revision. REPOSITORY R216 Syntax Highlighting BRANCH fix_cxx REVISION DETAIL https://phabricator.kde.org/D14282 AFFECTED FILES

D14137: CSS: update syntax and fix some errors

2018-07-16 Thread jonathan poelen
jpoelen added a comment. It is done. So much emotion :') REPOSITORY R216 Syntax Highlighting REVISION DETAIL https://phabricator.kde.org/D14137 To: jpoelen, dhaumann Cc: kwrite-devel, kde-frameworks-devel, michaelh, genethomas, kevinapavew, ngraham, bruns, demsking, cullmann, vkrause,

D14137: CSS: update syntax and fix some errors

2018-07-16 Thread jonathan poelen
This revision was automatically updated to reflect the committed changes. Closed by commit R216:423239c45ec5: CSS: update syntax and fix some errors (authored by jpoelen). REPOSITORY R216 Syntax Highlighting CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14137?vs=37815=37912

D14137: CSS: update syntax and fix some errors

2018-07-15 Thread jonathan poelen
jpoelen created this revision. jpoelen added a reviewer: dhaumann. jpoelen added projects: Frameworks, Framework: Syntax Highlighting. Restricted Application added a project: Kate. Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. jpoelen

  1   2   >