vonreth added a comment.
Looks good to me.
But just to be 1000% correct please delete the new operator.
REVISION DETAIL
https://phabricator.kde.org/D3091
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kfunk, #frameworks, brauch
Cc: vonreth,
brauch added a comment.
The user who originally reported the issue confirms that this patch fixes it.
REVISION DETAIL
https://phabricator.kde.org/D3091
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: kfunk, #frameworks, brauch
Cc: nalvarez, broulik
kfunk added a comment.
In https://phabricator.kde.org/D3091#57279, @nalvarez wrote:
> Meanwhile I'm skeptical of the need to "set it back". Is there any case
where such error dialog boxes would be desirable? It seems like their existence
is an ancient-app-compatibility thing. The
kfunk added a comment.
In https://phabricator.kde.org/D3091#57277, @broulik wrote:
> Can't really comment on this, though.
> While I'm a huge fan of RAII you don't seem to be returning early from that
function
RAII is not only useful for cases where you return early.
nalvarez added a comment.
Meanwhile I'm skeptical of the need to "set it back". Is there any case where
such error dialog boxes would be desirable? It seems like their existence is an
ancient-app-compatibility thing. The documentation for `SetErrorMode`
recommends setting
broulik added a comment.
Can't really comment on this, though.
While I'm a huge fan of RAII you don't seem to be returning early from that
function, can't you just set the value and set it back at the end without this
new class?
REVISION DETAIL
https://phabricator.kde.org/D3091
EMAIL
