D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

mmustac added a comment. I would not close the bug yet. Unfortunately I am busy at the moment so I can't tell you when I will find to take a deeper look at the main problem from the bug: Although we have support for the template directory now, it is still very difficult to display your

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

ngraham added a comment. @mmustac very nice! Should we consider 191632 to be resolved, or wait until you're implemented support for plain old non-`.desktop` files in `~/Templates`? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10363 To: mmustac, #frameworks, dfaure

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

This revision was automatically updated to reflect the committed changes. Closed by commit R241:de5ab5e74b4c: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu (authored by mmustac, committed by elvisangelaccio). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

mmustac added a comment. @dfaure Can you commit these changes as I don't have the access to ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10363 To: mmustac, #frameworks, dfaure Cc: kde-frameworks-devel, broulik, ngraham, michaelh, bruns

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10363 To: mmustac, #frameworks, dfaure Cc: kde-frameworks-devel, broulik, ngraham, michaelh, bruns

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

mmustac marked 5 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10363 To: mmustac, #frameworks, dfaure Cc: kde-frameworks-devel, broulik, ngraham, michaelh, bruns

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

mmustac updated this revision to Diff 35173. mmustac added a comment. Restricted Application added a subscriber: kde-frameworks-devel. Updated to the latest comments. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10363?vs=26753=35173 REVISION DETAIL

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

dfaure added a comment. In D10363#255790 , @mmustac wrote: > Kai mentioned he wants them directly underneath the "new folder" so I changed it. Ah OK, let's do that then. I was just wondering if it was an intentional change or not.

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

mmustac marked an inline comment as done. mmustac added a comment. No problem David, it's okay :) I will work on your suggestions and update this revision accordingly. > But actually, shouldn't we still have New Folder and New Text File at the top before everything else? Kai

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Hello, sorry for the delay in my review, I failed to react to the notification and then it scrolled out of view :/ INLINE COMMENTS > knewfilemenu.cpp:642 > QSet

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

mmustac marked 6 inline comments as done. mmustac added inline comments. INLINE COMMENTS > dfaure wrote in knewfilemenu.cpp:904 > the 2nd arg isn't necessary, just do line.mid(19) It is because we need to get rid of the " before and at the end of the path. REPOSITORY R241 KIO REVISION

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

mmustac updated this revision to Diff 26753. mmustac added a comment. Addressed the mentioned issues. F5698366: Screenshot_20180208_103832.png REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10363?vs=26702=26753

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

mmustac added a comment. @dfaure Thank you for your answer :-) As I am still at the beginnings I am really grateful for such constructive and valuable feedback like yours it helps me to become better and improve my code. Regarding your points: First of all I agree that a nice name

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Right, apart from the coding issues I found, the bigger issue is that this will not work, xdg templates are simple files I guess, not desktop files. In case you're wondering,

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

elvisangelaccio added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10363 To: mmustac, #frameworks, dfaure Cc: broulik, ngraham, michaelh

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

mmustac added a comment. @broulik Thanks :-) My idea was to add a submenu "own templates" to the menu but this would greatly exceed my knowledge. At the moment this is more try, error and debgugging, learning by doing ^^ Will try to improve this match further. REPOSITORY R241 KIO

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

broulik added a comment. Pretty cool! How about moving the custom ones to the top below Folder? Imho if the user went through the trouble of adding custom templates, he or she is most likely to use them most often? Perhaps also add a separator line? REPOSITORY R241 KIO REVISION DETAIL

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

mmustac edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D10363 To: mmustac, #frameworks Cc: michaelh, ngraham

D10363: [KIO] Add support for XDG_TEMPLATES_DIR in KNewFileMenu

mmustac created this revision. mmustac added a reviewer: Frameworks. Restricted Application added a project: Frameworks. mmustac requested review of this revision. REVISION SUMMARY This patch adds the support for templates in the XDG_TEMPLATES_DIR location which points in default to: [en]