chinmoyr abandoned this revision.
chinmoyr added a comment.
Not required right now
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10641
To: chinmoyr, dfaure
Cc: fvogt, #frameworks, michaelh, ngraham
dfaure added inline comments.
INLINE COMMENTS
> chinmoyr wrote in slavebase.cpp:147
> Now I feel stupid for doing this. Apart from that I am not even confident
> about this change because it involves changes in KAuth (Obviously I am not
> sure about them either). How about we drop this and the
chinmoyr added inline comments.
INLINE COMMENTS
> dfaure wrote in slavebase.cpp:147
> That looks like horrible API ;)
> A getter that optionally makes changes, based on a boolean... urgh ;)
>
> "Duplicating" a for loop isn't really duplication, go for a different method.
Now I feel stupid for
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> slavebase.cpp:147
>
> -bool hasTempAuth()
> +bool hasTempAuth(bool revoke = false)
> {
That looks like horrible API ;)
A getter that
chinmoyr removed a dependent revision: D10437: Update file ioslave's temporary
authorization list.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10641
To: chinmoyr, dfaure
Cc: fvogt, #frameworks, michaelh, kmorwinski
chinmoyr removed a dependency: D10568: Handle privilege operation confirmation
prompts in SlaveBase.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10641
To: chinmoyr, dfaure
Cc: fvogt, #frameworks, michaelh, kmorwinski
chinmoyr added a dependency: D10820: Send slave's polkit authorization status
to the host.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10641
To: chinmoyr, dfaure
Cc: fvogt, #frameworks, michaelh, kmorwinski
chinmoyr updated this revision to Diff 27996.
chinmoyr added a comment.
Removed other files which were included in previous commit by mistake
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10641?vs=27995=27996
BRANCH
master
REVISION DETAIL
chinmoyr updated this revision to Diff 27995.
chinmoyr retitled this revision from "Revoke temporary authorization of KIO
slave before sending it to klauncher" to "Revoke temporary authorization of KIO
slave before sending status to IdleSlave".
chinmoyr edited the summary of this revision.
