D11038: balooctl: Add pruneDb option to remove stale file index entries.

2018-03-07 Thread James Smith
smithjd updated this revision to Diff 28987. smithjd added a comment. - balooctl: Clarify the prune option description. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11038?vs=28747=28987 BRANCH master-purgeDb (branched from master) REVISION DETAIL

D11038: balooctl: Add pruneDb option to remove stale file index entries.

2018-03-07 Thread James Smith
smithjd added a comment. In D11038#220486 , @michaelh wrote: > In D11038#219353 , @smithjd wrote: > > > All mounts must be manually made available by the user before running this option, or all

D11038: balooctl: Add pruneDb option to remove stale file index entries.

2018-03-07 Thread Michael Heidelbach
michaelh requested changes to this revision. michaelh added a comment. This revision now requires changes to proceed. In D11038#219353 , @smithjd wrote: > All mounts must be manually made available by the user before running this option, or all

D11038: balooctl: Add pruneDb option to remove stale file index entries.

2018-03-07 Thread Michael Heidelbach
michaelh added a reviewer: michaelh. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11038 To: smithjd, #baloo, #frameworks, michaelh Cc: michaelh, ashaposhnikov, spoorun, nicolasfella, alexeymin

D11038: balooctl: Add pruneDb option to remove stale file index entries.

2018-03-05 Thread James Smith
smithjd marked 7 inline comments as done. smithjd added a comment. All mounts must be manually made available by the user before running this option, or all files on a previously available mount will be removed from the index. INLINE COMMENTS > michaelh wrote in transaction.cpp:271 > Can

D11038: balooctl: Add pruneDb option to remove stale file index entries.

2018-03-05 Thread James Smith
smithjd updated this revision to Diff 28747. smithjd added a comment. Review changes. REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11038?vs=28656=28747 BRANCH master-purgeDb (branched from master) REVISION DETAIL https://phabricator.kde.org/D11038

D11038: balooctl: Add pruneDb option to remove stale file index entries.

2018-03-05 Thread Michael Heidelbach
michaelh added a comment. Baloo is in bad need for something like this. Unfortunately in cannot be done so easily. We have to account for indexed net shares and removable drives which are only temporarily unavailable. Files on those should not be removed. And most likely some user

D11038: balooctl: Add pruneDb option to remove stale file index entries.

2018-03-04 Thread James Smith
smithjd created this revision. smithjd added reviewers: Baloo, Frameworks. Restricted Application added projects: Frameworks, Baloo. smithjd requested review of this revision. REPOSITORY R293 Baloo BRANCH master-purgeDb (branched from master) REVISION DETAIL