D11768: Add Desktop and Downloads to the default list of Places

ngraham added a comment. It was done in the interests of getting something in rather than nothing, since my initial larger list was controversial. I would favor adding Documents too, FWIW. Seems like others felt similarly. Wanna submit a patch? :) REPOSITORY R241 KIO REVISION DETAIL

D11768: Add Desktop and Downloads to the default list of Places

acrouthamel added a comment. Herald added a subscriber: kde-frameworks-devel. Hey Nate, is there a reason why Documents was not added with this patch? I always end up adding it. I was reading through D10245#201638 and the discussion seemed in favor

D11768: Add Desktop and Downloads to the default list of Places

ngraham closed this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff Cc: abetts, huoni, markg, fabiank, progwolff, broulik, michaelh, bruns

D11768: Add Desktop and Downloads to the default list of Places

ngraham removed a dependency: D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default. REPOSITORY R241 KIO BRANCH add-desktop-and-downloads (branched from master) REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview,

D11768: Add Desktop and Downloads to the default list of Places

ngraham edited the summary of this revision. REPOSITORY R241 KIO BRANCH add-desktop-and-downloads (branched from master) REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff Cc: abetts, huoni, markg, fabiank, progwolff,

D11768: Add Desktop and Downloads to the default list of Places

ngraham added a task: T8349: Improve Places panel usability and presentation. REPOSITORY R241 KIO BRANCH add-desktop-and-downloads (branched from master) REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff Cc: abetts,

D11768: Add Desktop and Downloads to the default list of Places

ngraham added a comment. Heh, thanks. Renato said he'd fix the tests soon, FWIW. REPOSITORY R241 KIO BRANCH add-desktop-and-downloads (branched from master) REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff Cc:

D11768: Add Desktop and Downloads to the default list of Places

markg accepted this revision. markg added a comment. This revision is now accepted and ready to land. Blocking it any longer seems rude to me :) REPOSITORY R241 KIO BRANCH add-desktop-and-downloads (branched from master) REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham,

D11768: Add Desktop and Downloads to the default list of Places

abetts added a comment. I would say remove search for images audio files and video and move them to the places location REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff Cc: abetts, huoni, markg,

D11768: Add Desktop and Downloads to the default list of Places

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff Cc: huoni, markg, fabiank, progwolff, broulik, michaelh, ngraham, bruns

D11768: Add Desktop and Downloads to the default list of Places

ngraham set the repository for this revision to R241 KIO. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff Cc: huoni, markg, fabiank, progwolff, broulik, michaelh, ngraham

D11768: Add Desktop and Downloads to the default list of Places

ngraham edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff Cc: huoni, markg, fabiank, progwolff, broulik, michaelh, ngraham

D11768: Add Desktop and Downloads to the default list of Places

progwolff accepted this revision. REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg, progwolff Cc: huoni, markg, fabiank, progwolff, broulik, michaelh, ngraham

D11768: Add Desktop and Downloads to the default list of Places

ngraham marked 2 inline comments as done. REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg Cc: huoni, markg, fabiank, progwolff, broulik, michaelh, ngraham

D11768: Add Desktop and Downloads to the default list of Places

huoni added a comment. FWIW, I run Arch, and never use Desktop View and therefore the Desktop folder. I //do// have `~/Desktop`, but I do not have the places entries by default. I definitely +1 this change, but it has to be robust and deal with any combination of pre-existing distro

D11768: Add Desktop and Downloads to the default list of Places

ngraham updated this revision to Diff 30891. ngraham added a comment. Only create user place bookmarks if their target directories already exist CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11768?vs=30799=30891 BRANCH add-desktop-and-downloads (branched from master) REVISION

D11768: Add Desktop and Downloads to the default list of Places

ngraham added a comment. I sent an email to Renato asking if he can resolve the test failures. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg, markg Cc: markg, fabiank, progwolff, broulik, michaelh, ngraham

D11768: Add Desktop and Downloads to the default list of Places

markg requested changes to this revision. markg added a comment. This revision now requires changes to proceed. I don't know why, but i already have this by default in my Dolphin... (ArchLinux user here, i don't think they add it explicitly as they try to stay as true to upstream as

D11768: Add Desktop and Downloads to the default list of Places

ngraham added a comment. In D11768#236365 , @fabiank wrote: > In D11768#236349 , @ngraham wrote: > > > In Neon and Kubuntu, ~/Desktop exists for a new user by default. Is this not the case in other

D11768: Add Desktop and Downloads to the default list of Places

fabiank added a comment. In D11768#236349 , @ngraham wrote: > In Neon and Kubuntu, ~/Desktop exists for a new user by default. Is this not the case in other distros? I'm not sure what is currently done, but I'm pretty sure in Chakra we

D11768: Add Desktop and Downloads to the default list of Places

progwolff added a comment. In D11768#236348 , @broulik wrote: > > Still, that folder exists by default > > Are you sure? It might be created by some weird startup script or something else. Also, a user can choose to change the location of

D11768: Add Desktop and Downloads to the default list of Places

ngraham added a comment. In Neon and Kubuntu, ~/Desktop exists for a new user by default. Is this not the case in other distros? I think a user who goes and figures out how to make Folder View point to a different folder than ~/Desktop is the kind of user who can figure out how to edit

D11768: Add Desktop and Downloads to the default list of Places

broulik added a comment. > Still, that folder exists by default Are you sure? It might be created by some weird startup script or something else. Also, a user can choose to change the location of the Desktop folder. Just wanting to make sure this change (which I'm totally in favor of,

D11768: Add Desktop and Downloads to the default list of Places

ngraham added inline comments. INLINE COMMENTS > broulik wrote in kfileplacesmodel.cpp:245 > Desktop KIO claims that this may return $HOME if the Desktop folder does not > exist, can you confirm/invalidate that? If I delete ~/Desktop, trying to access it via the Places entry gives me a red

D11768: Add Desktop and Downloads to the default list of Places

broulik added a comment. +1 INLINE COMMENTS > kfileplacesmodel.cpp:245 > + QStringLiteral("Desktop"), > I18N_NOOP2("KFile System Bookmarks", "Desktop"), > + >

D11768: Add Desktop and Downloads to the default list of Places

ngraham edited the test plan for this revision. ngraham set the repository for this revision to R241 KIO. Restricted Application added a project: Frameworks. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg Cc:

D11768: Add Desktop and Downloads to the default list of Places

ngraham edited the summary of this revision. ngraham added a dependency: D11767: Remove Recently Saved This Month and Recently Saved Last Month entries by default. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11768 To: ngraham, #dolphin, #gwenview, #frameworks, #vdg Cc:

D11768: Add Desktop and Downloads to the default list of Places

ngraham created this revision. ngraham added reviewers: Dolphin, Gwenview, Frameworks, VDG. ngraham requested review of this revision. REVISION SUMMARY Add Desktop and Downloads to the default list of places, for the following reasons: 1. The Desktop and Downloads folders are heavily used