D12156: implement reading of rating tag

This revision was automatically updated to reflect the committed changes. Closed by commit R286:0b0f2d2eb36d: implement reading of rating tag (authored by astippich). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12156?vs=35242=35938 REVISION DETAIL

D12156: implement reading of rating tag

mgallien accepted this revision. mgallien added a comment. This revision is now accepted and ready to land. I hope application developers will not complain about the need to support a second api to get ratings. I am still unsure this the best way to add this support. REPOSITORY R286

D12156: implement reading of rating tag

astippich updated this revision to Diff 35242. astippich added a comment. - update comments REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12156?vs=34398=35242 BRANCH rating REVISION DETAIL https://phabricator.kde.org/D12156 AFFECTED FILES

D12156: implement reading of rating tag

mgallien added a subscriber: cgilles. mgallien added a comment. @cgilles Are you somehow using KFileMetaData (seems correct if one looks at the Debian package dependencies) ? This diff is about adding a way to read ratings from "tags" native to a specific file format. This would be in

D12156: implement reading of rating tag

astippich added a comment. any comments on the previous discussion? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12156 To: astippich, mgallien, michaelh Cc: kde-frameworks-devel, #baloo, bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham

D12156: implement reading of rating tag

astippich updated this revision to Diff 34398. astippich added a comment. Restricted Application edited subscribers, added: Baloo, kde-frameworks-devel; removed: Frameworks. - rebase on master - implement rating tag for m4a REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D12156: implement reading of rating tag

astippich added a comment. I agree, there are several problems coming from the fact that we basically have two sources for the same property, which can potentially conflict. Btw, we already have the same issue with the comment property. In D12156#257888

D12156: implement reading of rating tag

mgallien added a comment. In D12156#254055 , @astippich wrote: > In D12156#252575 , @mgallien wrote: > > > If I have correctly understood the ideas behind the conception of Baloo, we should

D12156: implement reading of rating tag

bruns added a comment. In D12156#254055 , @astippich wrote: > In D12156#252575 , @mgallien wrote: > > > If I have correctly understood the ideas behind the conception of Baloo, we should probably

D12156: implement reading of rating tag

astippich added a comment. ping @mgallien REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12156 To: astippich, mgallien, michaelh Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun

D12156: implement reading of rating tag

astippich added a comment. In D12156#252575 , @mgallien wrote: > If I have correctly understood the ideas behind the conception of Baloo, we should probably prefer to store the rating with a "native" solution instead of the xattr one that is

D12156: implement reading of rating tag

bruns added a comment. In D12156#252575 , @mgallien wrote: > In D12156#249994 , @astippich wrote: > > > In D12156#249977 , @michaelh wrote: > > > > >

D12156: implement reading of rating tag

mgallien requested changes to this revision. mgallien added a comment. This revision now requires changes to proceed. In D12156#249994 , @astippich wrote: > In D12156#249977 , @michaelh wrote: > >

D12156: implement reading of rating tag

astippich added a comment. In D12156#249977 , @michaelh wrote: > In D12156#249971 , @astippich wrote: > > > In D12156#249951 , @michaelh wrote: > > >

D12156: implement reading of rating tag

michaelh added a comment. In D12156#249971 , @astippich wrote: > In D12156#249951 , @michaelh wrote: > > > It's for elisa I guess, could you please elaborate how POPM/RATING is going to be used

D12156: implement reading of rating tag

astippich added a comment. In D12156#249951 , @michaelh wrote: > It's for elisa I guess, could you please elaborate how POPM/RATING is going to be used and why xattr are not applicable? It will be used as a fallback when there is no

D12156: implement reading of rating tag

michaelh added a comment. It's for elisa I guess, could you please elaborate how POPM/RATING is going to be used and why xattr are not applicable? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12156 To: astippich, mgallien, michaelh Cc: bruns, #frameworks,

D12156: implement reading of rating tag

astippich added a comment. Those formulas didn't work with newly added tests with values from Winamp, Windows Media Player and MediaMonkey. I calculated a linear regression line and this one seems to work with some special case handling REPOSITORY R286 KFileMetaData REVISION DETAIL

D12156: implement reading of rating tag

astippich updated this revision to Diff 32591. astippich added a comment. - simplify REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12156?vs=32587=32591 BRANCH rating REVISION DETAIL https://phabricator.kde.org/D12156 AFFECTED FILES

D12156: implement reading of rating tag

astippich added a comment. code didn't get prettier, but that's the de-facto standard REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12156 To: astippich, mgallien, michaelh Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun

D12156: implement reading of rating tag

bruns added inline comments. INLINE COMMENTS > astippich wrote in taglibextractor.cpp:222-234 > The thing here is that the most common implementation don't allow half star > ratings. Only Mediamonkey does it and that diverges from the rest. Also, the > values are not distributed equidistantly,

D12156: implement reading of rating tag

astippich updated this revision to Diff 32587. astippich added a comment. - implement reading of half star ratings for mp3 and add tests REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12156?vs=31987=32587 BRANCH rating REVISION DETAIL

D12156: implement reading of rating tag

astippich added a comment. In D12156#249223 , @mgallien wrote: > Thanks. > Fix one issue and we should be good to go. > Another nice thing is that we should have a portable way to have ratings in Elisa that could be read or write somewhere

D12156: implement reading of rating tag

mgallien requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12156 To: astippich, mgallien, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, bruns

D12156: implement reading of rating tag

mgallien added a comment. Thanks. Fix one issue and we should be good to go. Another nice thing is that we should have a portable way to have ratings in Elisa that could be read or write somewhere else. INLINE COMMENTS > taglibextractor.cpp:222-234 > +if (temp == 0) { > +

D12156: implement reading of rating tag

astippich edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D12156 To: astippich, mgallien, michaelh Cc: #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin

D12156: implement reading of rating tag

astippich created this revision. astippich added reviewers: mgallien, michaelh. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. astippich requested review of this revision. REVISION SUMMARY allows to read the rating stored in the