This revision was automatically updated to reflect the committed changes.
Closed by commit R242:11f4e5b392ac: [Dialog] Handle dialog being minimized
gracefully (authored by broulik).
REPOSITORY
R242 Plasma Framework (Library)
CHANGES SINCE LAST UPDATE
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D12876
To: broulik, #plasma, mart
Cc: mart, ngraham, kde-frameworks-devel, michaelh, bruns
mart added inline comments.
INLINE COMMENTS
> broulik wrote in dialog.cpp:1371
> We don't know the previous state of the window with `windowState` (singular,
> pre-5.10 API) so we cannot restore a full screen or maximized state. Not sure
> if that is a usecase, though. Anyway, this new API
broulik added inline comments.
INLINE COMMENTS
> dialog.cpp:1371
> +// Bug 381242: Qt remembers minimize state and re-applies it when
> showing
> +setWindowStates(windowStates() & ~Qt::WindowMinimized);
> +#endif
We don't know the previous state of the window with `windowState`
broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
broulik requested review of this revision.
REVISION SUMMARY
Dialogs don't show up in task bar and also don't have
