D13018: Fix unit test for kfileplacesmodeltest

This revision was automatically updated to reflect the committed changes. Closed by commit R241:2c478f4e429b: Fix unit test for kfileplacesmodeltest (authored by Renato Araujo Oliveira Filho renato.ara...@kdab.com). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

D13018: Fix unit test for kfileplacesmodeltest

renatoo added a comment. In D13018#266694 , @bruns wrote: > Shouldn't this be handled by: > http://doc.qt.io/qt-5/qstandardpaths.html#setTestModeEnabled this is different "setTestModeEnabled" sets the XDG_* dirs but the KIO tests

D13018: Fix unit test for kfileplacesmodeltest

bruns added a comment. Shouldn't this be handled by: http://doc.qt.io/qt-5/qstandardpaths.html#setTestModeEnabled REVISION DETAIL https://phabricator.kde.org/D13018 To: renatoo, ngraham Cc: bruns, ngraham, maximilianocuria, elvisangelaccio, kde-frameworks-devel, michaelh

D13018: Fix unit test for kfileplacesmodeltest

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Much better, thanks for indulging me. :) Now onto `kfileplacesviewtest`... REVISION DETAIL https://phabricator.kde.org/D13018 To: renatoo, ngraham Cc: ngraham, maximilianocuria,

D13018: Fix unit test for kfileplacesmodeltest

renatoo added a comment. In D13018#266626 , @ngraham wrote: > I know you didn't change that, but it might be a nice enhancement (hint hint). :) In D13018#266626 , @ngraham wrote: > I

D13018: Fix unit test for kfileplacesmodeltest

renatoo updated this revision to Diff 34666. renatoo added a comment. Run tests in an empty home dir CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13018?vs=34646=34666 REVISION DETAIL https://phabricator.kde.org/D13018 AFFECTED FILES autotests/kfileplacesmodeltest.cpp To:

D13018: Fix unit test for kfileplacesmodeltest

ngraham added a comment. I know you didn't change that, but it might be a nice enhancement (hint hint). :) REVISION DETAIL https://phabricator.kde.org/D13018 To: renatoo, ngraham Cc: ngraham, maximilianocuria, elvisangelaccio, kde-frameworks-devel, michaelh, bruns

D13018: Fix unit test for kfileplacesmodeltest

renatoo added a comment. In D13018#266623 , @ngraham wrote: > Shouldn't that be a part of the test itself? I don't think it's reasonable to require that testers and testing platforms manually run that every time. I am not sure, this is

D13018: Fix unit test for kfileplacesmodeltest

ngraham added a comment. Shouldn't that be a part of the test itself? I don't think it's reasonable to require that testers and testing platforms manually run that every time. REVISION DETAIL https://phabricator.kde.org/D13018 To: renatoo, ngraham Cc: ngraham, maximilianocuria,

D13018: Fix unit test for kfileplacesmodeltest

renatoo added a comment. as maximilianocuria said, before run the tests you need to create a temporary home path: HOMETMP=$(mktemp -d) trap 'rm -rf $HOMETMP' EXIT export HOME="$HOMETMP" REVISION DETAIL https://phabricator.kde.org/D13018 To: renatoo, ngraham Cc: ngraham,

D13018: Fix unit test for kfileplacesmodeltest

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. `kiofilewidgets-kfileplacesmodeltest` still fails for me with this patch: grep 'FAIL! : KFilePlacesModelTest' -A 3 Testing/Temporary/LastTest.log FAIL! :

D13018: Fix unit test for kfileplacesmodeltest

renatoo added a comment. ok it should work now. REVISION DETAIL https://phabricator.kde.org/D13018 To: renatoo Cc: maximilianocuria, elvisangelaccio, kde-frameworks-devel, michaelh, ngraham, bruns

D13018: Fix unit test for kfileplacesmodeltest

renatoo updated this revision to Diff 34646. renatoo added a comment. Fixed code style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13018?vs=34645=34646 REVISION DETAIL https://phabricator.kde.org/D13018 AFFECTED FILES autotests/kfileplacesmodeltest.cpp To: renatoo Cc:

D13018: Fix unit test for kfileplacesmodeltest

renatoo updated this revision to Diff 34645. renatoo added a comment. Fixed all tests CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13018?vs=34644=34645 REVISION DETAIL https://phabricator.kde.org/D13018 AFFECTED FILES autotests/kfileplacesmodeltest.cpp To: renatoo Cc:

D13018: Fix unit test for kfileplacesmodeltest

renatoo updated this revision to Diff 34644. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13018?vs=34581=34644 REVISION DETAIL https://phabricator.kde.org/D13018 AFFECTED FILES autotests/kfileplacesmodeltest.cpp To: renatoo Cc: maximilianocuria, elvisangelaccio,

D13018: Fix unit test for kfileplacesmodeltest

maximilianocuria added a comment. In D13018#266137 , @elvisangelaccio wrote: > Hmm, still seems to fail here: > > $ ctest -R kfileplacesmodeltest > Test project /home/elvis/dev/kde/kio/local-build > Start 50:

D13018: Fix unit test for kfileplacesmodeltest

elvisangelaccio added a comment. Hmm, still seems to fail here: $ ctest -R kfileplacesmodeltest Test project /home/elvis/dev/kde/kio/local-build Start 50: kiofilewidgets-kfileplacesmodeltest 1/1 Test #50: kiofilewidgets-kfileplacesmodeltest ...***Failed0.60 sec

D13018: Fix unit test for kfileplacesmodeltest

renatoo updated this revision to Diff 34581. renatoo added a comment. Add missing url REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13018?vs=34580=34581 REVISION DETAIL https://phabricator.kde.org/D13018 AFFECTED FILES autotests/kfileplacesmodeltest.cpp

D13018: Fix unit test for kfileplacesmodeltest

renatoo created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. renatoo requested review of this revision. TEST PLAN Run "kiofilewidgets-kfileplacesmodeltest" make sure that "testRemoteUrls" is passing