D14893: [recentdocuments:/] Filter out files that can't be browsed with a file manager

ngraham added a task: T8349: Improve Places panel usability and presentation. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D14893 To: ngraham, broulik, #dolphin,

D14893: [recentdocuments:/] Filter out files that can't be browsed with a file manager

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R320:8606d4d97f3e: [recentdocuments:/] Filter out files that cant be browsed with a file manager (authored by ngraham).

D14893: [recentdocuments:/] Filter out files that can't be browsed with a file manager

elvisangelaccio added a comment. +1, lgtm REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D14893 To: ngraham, broulik, #dolphin, #frameworks Cc: elvisangelaccio, markg

D14893: [recentdocuments:/] Filter out files that can't be browsed with a file manager

ngraham added a comment. In D14893#311411 , @markg wrote: > It "looks" oke to me, but i don't know this code one bit. Give it a try, it's pretty easy to test with the test plan. REPOSITORY R320 KIO Extras REVISION DETAIL

D14893: [recentdocuments:/] Filter out files that can't be browsed with a file manager

ngraham updated this revision to Diff 40054. ngraham added a comment. Move comment REPOSITORY R320 KIO Extras CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14893?vs=39892=40054 BRANCH arcpatch-D14893 REVISION DETAIL https://phabricator.kde.org/D14893 AFFECTED FILES

D14893: [recentdocuments:/] Filter out files that can't be browsed with a file manager

ngraham marked an inline comment as done. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D14893 To: ngraham, broulik, #dolphin, #frameworks Cc: markg

D14893: [recentdocuments:/] Filter out files that can't be browsed with a file manager

markg added a comment. It "looks" oke to me, but i don't know this code one bit. INLINE COMMENTS > recentdocuments.cpp:82-83 > +if (urlInside.scheme() == "recentdocuments" > +// Filter out things that can't be viewed in a file > manager because they don't

D14893: [recentdocuments:/] Filter out files that can't be browsed with a file manager

ngraham created this revision. ngraham added reviewers: broulik, Dolphin, Frameworks. ngraham requested review of this revision. REVISION SUMMARY This is a more appropriate version of D13797: Only add actual documents to Recent Documents . Basically we