D15091: Compile python bindings with the same sipname used by PyQt

arojas planned changes to this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15091 To: arojas, #frameworks, bruns Cc: rdieter, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15091: Compile python bindings with the same sipname used by PyQt

rdieter added a comment. These 2 threads: https://www.riverbankcomputing.com/pipermail/pyqt/2018-August/040759.html https://www.riverbankcomputing.com/pipermail/pyqt/2018-August/040771.html REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15091 To:

D15091: Compile python bindings with the same sipname used by PyQt

arojas added a comment. In D15091#316243 , @rdieter wrote: > I was asking mostly because that's what pyqt upstream strongly suggested (to use all sip_flags) when I asked them. Oh, if upstream recommends it then I guess it should cause no

D15091: Compile python bindings with the same sipname used by PyQt

rdieter added a comment. I was asking mostly because that's what pyqt upstream strongly suggested (to use all sip_flags) when I asked them. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15091 To: arojas, #frameworks, bruns Cc: rdieter,

D15091: Compile python bindings with the same sipname used by PyQt

arojas added a comment. In D15091#316150 , @rdieter wrote: > Why are you simply not using all PYQT_CONFIGURATION["sip_flags"]? Not sure if we really want to do this. For instance, bindings would get tagged with the Qt version that PyQt

D15091: Compile python bindings with the same sipname used by PyQt

rdieter added a comment. Why are you simply not using all PYQT_CONFIGURATION["sip_flags"]? REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15091 To: arojas, #frameworks, bruns Cc: rdieter, kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15091: Compile python bindings with the same sipname used by PyQt

arojas added inline comments. INLINE COMMENTS > bruns wrote in run-sip.py:11 > Is there a gurantee `-n` and its arg are space separated? > > otherwise: > > import re > m = re.search('-n\s*(\S+)', PYQT_CONFIGURATION["sip_flags"]) > if m: > sipArgs = ['-n', m.group(1)] + sipArgs I

D15091: Compile python bindings with the same sipname used by PyQt

arojas marked an inline comment as done. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15091 To: arojas, #frameworks, bruns Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns

D15091: Compile python bindings with the same sipname used by PyQt

arojas updated this revision to Diff 40479. arojas added a comment. Use a regex to account for the case where -n an its arg are not space-separated REPOSITORY R240 Extra CMake Modules CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D15091?vs=40477=40479 REVISION DETAIL

D15091: Compile python bindings with the same sipname used by PyQt

bruns added inline comments. INLINE COMMENTS > run-sip.py:11 > +from PyQt5.Qt import PYQT_CONFIGURATION > +pyqt_sip_flags = PYQT_CONFIGURATION["sip_flags"].split(' ') > +index_n = pyqt_sip_flags.index('-n') Is there a gurantee `-n` and its arg are space separated? otherwise:

D15091: Compile python bindings with the same sipname used by PyQt

arojas created this revision. arojas added reviewers: Frameworks, bruns. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. arojas requested review of this revision. REVISION SUMMARY PyQt>=5.11 is compiled with the 'PyQt5.sip'