sitter added a comment.
I am somewhat indifferent. It certainly has caused some grief for various
reasons in various places, so it stands to reason that it should go. Also since
auto-init of kcrash is essentially not a thing for application code (what with
link-as-needed being a common
cfeck added a comment.
This seems to pull in QtGui dependency, but that's also dragged in by
KService (which also links to KF5::Crash) and KF5DBusAddons (which only needs
QtX11Extras, which unfortunately also needs QtGui).
Can the KCrash dependency be added to the slaves instead of to
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:d428fc8e6447: replace custom backtracing in SlaveBase
with KCrash (authored by sitter).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D15573?vs=41822=41887
REVISION
dfaure accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D15573
To: sitter, dfaure
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
sitter created this revision.
sitter added a reviewer: dfaure.
Herald added a project: Frameworks.
Herald added a subscriber: kde-frameworks-devel.
sitter requested review of this revision.
REVISION SUMMARY
as discussed on mailing list.
KCrash originally was automatically initialized, but
