D16165: Don't crash on invalid exiv2 data

This revision was automatically updated to reflect the committed changes. Closed by commit R286:5eee9ac75b7d: Dont crash on invalid exiv2 data (authored by poboiko). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16165?vs=43526=43736 REVISION DETAIL

D16165: Don't crash on invalid exiv2 data

astippich accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH dont-crash-invalid-exiv (branched from master) REVISION DETAIL https://phabricator.kde.org/D16165 To: poboiko, #baloo, #frameworks, astippich Cc: bruns, astippich,

D16165: Don't crash on invalid exiv2 data

bruns added a comment. In D16165#342975 , @poboiko wrote: > > Yeah, that's true. I guess that should be also not too hard to fix. > But there is two parts of the bug. The first one is what you mentioned, while the second is

D16165: Don't crash on invalid exiv2 data

poboiko added a comment. In D16165#342550 , @bruns wrote: > Unfortunately 375131 is quite vague, they all speak about "baloo" hanging, but as "baloo" is not a single process, it is impossible to tell for sure which process crashes or hangs. >

D16165: Don't crash on invalid exiv2 data

bruns added a comment. In D16165#342522 , @poboiko wrote: > In D16165#342433 , @bruns wrote: > > > These three should be CCBUG: (not test file, not able to confirm fixed), while 375131 should be

D16165: Don't crash on invalid exiv2 data

poboiko added a comment. In D16165#342433 , @bruns wrote: > These three should be CCBUG: (not test file, not able to confirm fixed), while 375131 should be BUG: (confirmed and fixed). Wait. Those three are about the very same crash I was

D16165: Don't crash on invalid exiv2 data

bruns added a comment. In D16165#342348 , @poboiko wrote: > In D16165#342156 , @astippich wrote: > > > I guess bugs > > 352856 > > 353848 > > 361259 > > will also be fixed by this? >

D16165: Don't crash on invalid exiv2 data

poboiko added a comment. In D16165#342156 , @astippich wrote: > I guess bugs > 352856 > 353848 > 361259 > will also be fixed by this? Yes, they should be. Thanks for the links! Added it to summary. REPOSITORY R286

D16165: Don't crash on invalid exiv2 data

poboiko updated this revision to Diff 43526. poboiko added a comment. Replaced `size()` by `count()`, which is more appropriate here REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D16165?vs=43506=43526 BRANCH dont-crash-invalid-exiv (branched from

D16165: Don't crash on invalid exiv2 data

poboiko edited the summary of this revision. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16165 To: poboiko, #baloo, #frameworks Cc: bruns, astippich, kde-frameworks-devel, ashaposhnikov, michaelh, spoorun, ngraham, abrahams

D16165: Don't crash on invalid exiv2 data

bruns added a comment. Can you enhance the Summary a little bit? It took me some time to notice `Exiv2::Value::toFloat()` is the same as `Exiv2::Value::toFloat(0)` (default argument), and accessing an inexisting element (i.e. n >= count()) triggers undefined behaviour, according to the

D16165: Don't crash on invalid exiv2 data

astippich added a comment. I guess bugs 352856 353848 361259 will also be fixed by this? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D16165 To: poboiko, #baloo, #frameworks Cc: astippich, kde-frameworks-devel, ashaposhnikov, michaelh, spoorun,

D16165: Don't crash on invalid exiv2 data

poboiko created this revision. poboiko added reviewers: Baloo, Frameworks. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. poboiko requested review of this revision. REVISION SUMMARY The file from bug 375131 crashes `baloo_file_extractor`. The problem