This revision was automatically updated to reflect the committed changes.
Closed by commit R39:cb63ec1ee30a: Only cal updateView() in visibleRange() when
endPos() is invalid. (authored by sars).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17243?vs=46937&
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
Then lets try that.
REPOSITORY
R39 KTextEditor
BRANCH
lessUpdateView
REVISION DETAIL
https://phabricator.kde.org/D17243
To: sars, cullmann, #kate, dhaumann
Cc: kwrite-devel, kde
sars added a comment.
OK, I have used this patch actively for a week now, and I have not noticed
any regression... ;)
I also now removed the temporary as it did not provide noticeable
improvements.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17243
To: s
sars updated this revision to Diff 46937.
sars edited the summary of this revision.
sars added a comment.
Remove unneeded temporary
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D17243?vs=46500&id=46937
BRANCH
lessUpdateView
REVISION DETAIL
https:/
cullmann added a comment.
Hmm, in principle the change might make sense, to avoid un-needed
recomputations.
Thought no idea how to see if that regresses something without just trying it.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17243
To: sars, cullmann,
sars added a comment.
Note: this is especially bad when the "on the fly spellchecking" is enabled
as visibleRange() is used to "optimize" and only highlight what is currently
visible. It is called multiple times.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D17
sars created this revision.
sars added reviewers: cullmann, Kate, dhaumann.
sars added a project: Kate.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
Herald added a project: Frameworks.
sars requested review of this revision.
REVISION SUMMARY
visibleRange() has a side-effect that
