D17342: team-port setting

This revision was automatically updated to reflect the committed changes. Closed by commit R282:d3ca739a37ab: team-port setting (authored by pranavgade, committed by jgrulich). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D17342?vs=46946=46949#toc REPOSITORY R282 NetworkManagerQt

D17342: team-port setting

jgrulich accepted this revision. jgrulich added a comment. This revision is now accepted and ready to land. I lived in assumption that "link-watchers" is NMVariantMapMap and not NMVariantMapList, that's why I suggested those changes. I'm sorry for that. I'll fix it locally here, you were

D17342: team-port setting

pranavgade updated this revision to Diff 46946. pranavgade marked an inline comment as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17342?vs=46940=46946 REVISION DETAIL https://phabricator.kde.org/D17342 AFFECTED FILES autotests/settings/CMakeLists.txt

D17342: team-port setting

jgrulich added inline comments. INLINE COMMENTS > teamportsettingtest.cpp:103 > +if (it.key() == QLatin1String(NM_SETTING_TEAM_PORT_LINK_WATCHERS)) { > +NMVariantMapList list = it_1.value().value(); > +NMVariantMapList list1 = > map1.value(it_1.key()).value();

D17342: team-port setting

jgrulich added a comment. Submit full patch, not only recent changes. REVISION DETAIL https://phabricator.kde.org/D17342 To: pranavgade, jgrulich Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D17342: team-port setting

pranavgade updated this revision to Diff 46940. pranavgade marked 2 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17342?vs=46905=46940 REVISION DETAIL https://phabricator.kde.org/D17342 AFFECTED FILES autotests/settings/CMakeLists.txt

D17342: team-port setting

jgrulich added inline comments. INLINE COMMENTS > teamportsettingtest.cpp:100 > + > +QVariantMap::const_iterator it_1 = map.constBegin(); > +while (it_1 != map.constEnd()) { This is again wrong, you want to go through "link-watchers" map, not through the whole map. >

D17342: team-port setting

pranavgade updated this revision to Diff 46905. pranavgade marked 4 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17342?vs=46896=46905 REVISION DETAIL https://phabricator.kde.org/D17342 AFFECTED FILES autotests/settings/CMakeLists.txt

D17342: team-port setting

jgrulich added inline comments. INLINE COMMENTS > teamportsettingtest.cpp:97 > + > +QVariantMap map0; > +map0.insert(QLatin1String(NM_SETTING_TEAM_PORT_LINK_WATCHERS), > QVariant::fromValue(linkWatchers)); Still weird, why don't you put link-watchers to the same map as above. You can

D17342: team-port setting

pranavgade updated this revision to Diff 46896. pranavgade marked 8 inline comments as done. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17342?vs=46830=46896 REVISION DETAIL https://phabricator.kde.org/D17342 AFFECTED FILES autotests/settings/CMakeLists.txt

D17342: team-port setting

jgrulich added inline comments. INLINE COMMENTS > teamportsettingtest.cpp:29 > + > +#if !NM_CHECK_VERSION(1, 12, 0) > +#define NM_SETTING_TEAM_PORT_CONFIG"config" Those defines are already in NM 1.10 > teamportsettingtest.cpp:62 > +<< (qint32)1 // queueId > +

D17342: team-port setting

pranavgade updated this revision to Diff 46830. pranavgade added a comment. add missing indents CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D17342?vs=46829=46830 REVISION DETAIL https://phabricator.kde.org/D17342 AFFECTED FILES autotests/settings/CMakeLists.txt

D17342: team-port setting

pranavgade created this revision. pranavgade added a reviewer: jgrulich. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. pranavgade requested review of this revision. REVISION SUMMARY Added team-port setting according to: