D18125: KateStatusBar: Add dictionary button

This revision was automatically updated to reflect the committed changes. Closed by commit R39:08d1d681ff8b: KateStatusBar: Add dictionary button (authored by loh.tar, committed by cullmann). REPOSITORY R39 KTextEditor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18125?vs=52307&id=

D18125: KateStatusBar: Add dictionary button

cullmann accepted this revision. cullmann added a comment. This revision is now accepted and ready to land. Thanks for taking care of the overhead by adding the new internal signal. I think this can now go in. I still would like to have the button configurable, but that is no reason to den

D18125: KateStatusBar: Add dictionary button

loh.tar updated this revision to Diff 52307. loh.tar added a comment. - Remove '-w_accents -variant_0' and such from dict-code to keep it small and clean - Fix to show correct dict when cursor is at end of a range - Add signal caretChangedRange to ViewPrivate, much less overhead this way t

D18125: KateStatusBar: Add dictionary button

loh.tar updated this revision to Diff 50763. loh.tar set the repository for this revision to R39 KTextEditor. loh.tar added a comment. - Apply nullptr check - Add non preferred dict to menu chose by user - Reorder actions - Remove gone "Spellcheck Selection" action REPOSITORY R39 KText

D18125: KateStatusBar: Add dictionary button

loh.tar added a comment. > m_dictionaryGroup->checkedAction() might be null. Oops! Thanks. > For the naming: Given we show the encodings with their short-names, too, I can live with de_DE or stuff like that. Is it OK to add some cutting like that? Currently is that extra stuff s

D18125: KateStatusBar: Add dictionary button

cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. I played with this patch now ;) First: to now have KWrite crash on start, one need to modify one line to: if (!m_dictionaryGroup->checkedAction() || (m_dictionaryGrou

D18125: KateStatusBar: Add dictionary button

loh.tar added a subscriber: cullmann. loh.tar added a comment. @cullmann @dhaumann A short not how to progress would be nice. - Keep codes as they are - Shorten codes as suggested - Replace codes by flags/ensign (no idea how) - Add (unneeded) label - Show (unneeded long) full name

D18125: KateStatusBar: Add dictionary button

loh.tar added a comment. I'm very much against such a label, and against the full name. "UTF-8" has also no label and that's good. The only stuff where a description label is needed are these line/column/word hints. Without a label are you almost lost to know which is what. However, i

D18125: KateStatusBar: Add dictionary button

ngraham added a comment. If we stay with `en_US`, I'd like to see a label so people know what it is. Otherwise, we should use the long name, because then it becomes obvious. So here are the two options I would approve of: - Dictionary: en_US v - American English v REVISION DETAIL ht

D18125: KateStatusBar: Add dictionary button

loh.tar updated this revision to Diff 49099. loh.tar added a comment. - Add missing signals to watch dict changes - Ensure button is set on first show Looks fixed, give it a try. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18125?vs=49078&id=49099 REVISION DETAIL https://

D18125: KateStatusBar: Add dictionary button

loh.tar added a comment. > Isn't en_US too cryptic? Well, yes. > I suggest to use the just added KLanguageName (see D10446 ). With this, you can get a nice name like "English (USA)". Alternatively, you may use QLocale("en_US").nativeLanguageName(

D18125: KateStatusBar: Add dictionary button

dhaumann added a comment. Isn't en_US too cryptic? I suggest to use the just added KLanguageName (see D10446 ). With this, you can get a nice name like "English (USA)". Alternatively, you may use QLocale("en_US").nativeLanguageName(), but I did not test th

D18125: KateStatusBar: Add dictionary button

loh.tar added a comment. The shown dictionary is sometimes "wrong" - Mark a word by double-click and choose a dictionary different from the default for that word - Click/move into the word -> The shown dictionary fit - Double-Click that word again -> The shown dictionary is the defaul

D18125: KateStatusBar: Add dictionary button

loh.tar created this revision. loh.tar added a reviewer: KTextEditor. Herald added projects: Kate, Frameworks. Herald added subscribers: kde-frameworks-devel, kwrite-devel. loh.tar requested review of this revision. REVISION SUMMARY ...to indicate the current dictionary and for the handy access