This revision was automatically updated to reflect the committed changes.
Closed by commit R39:f2e7a22be5e5: KateSpellCheckDialog: Remove action
Spellcheck Selection (authored by loh.tar, committed by cullmann).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
cullmann accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D18663
To: loh.tar, #ktexteditor, cullmann
Cc: cullmann, dhaumann, kwrite-devel, kde-frameworks-devel, #ktexteditor, hase,
michaelh,
cullmann added a comment.
;=) given ::spellcheck() has the same magic, I don't think we really need to
rename the function.
And spellcheckSelectionOrFromCursor is a bit strange, too.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D18663
To: loh.tar,
dhaumann added a comment.
In general I am ok eith this. Although it's a tiny bit less transparent to
the user.
INLINE COMMENTS
> spellcheckdialog.cpp:74
> {
> -spellcheck(m_view->cursorPosition());
> +if (m_view->selection()) {
> +spellcheckSelection();
I don't like the
loh.tar added a comment.
For my taste could be "Spelling (from cursor)" the only offered action
(logic). Always to check from the start is rarely useful, but I guess no one
like that idea.
The current patch should cause no harm, except that someone need to reassign
some shortcut or
loh.tar created this revision.
loh.tar added a reviewer: KTextEditor.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
loh.tar requested review of this revision.
REVISION SUMMARY
...and add logic to "Spelling.." and "Spelling (from cursor)"
