D20046: Verify mimetypes for all existing sample files, add some more

bcooksley added a comment. Can you please file a task on the #build.kde.org board so I can get this worked through with the FreeBSD folks? (It will likely require the package being updated in FreeBSD itself) REPOSITORY R286 KFileMetaData R

D20046: Verify mimetypes for all existing sample files, add some more

bruns added a subscriber: bcooksley. bruns added a comment. hexdump -n 11 -C autotests/samplefiles/test.AppImage 7f 45 4c 46 02 01 01 00 41 49 02 |.ELFAI.| grep -v comment /usr/share/mime/packages/freedesktop.org.xml | grep -B13 '*\.appimage'

D20046: Verify mimetypes for all existing sample files, add some more

astippich added a comment. This causes one test failure on FreeBSD: https://build.kde.org/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20FreeBSDQt5.12/51/ REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20046 To: bruns, #baloo, #frameworks, astippich, ngraha

D20046: Verify mimetypes for all existing sample files, add some more

bruns added inline comments. INLINE COMMENTS > astippich wrote in extractorcoveragetest.cpp:50 > Is it really audio/x-aifc? Taglibextractor the never actually got called. > Looks like we should also wire the new helper funciton into the extractor > tests, so that we make sure they support the r

D20046: Verify mimetypes for all existing sample files, add some more

This revision was automatically updated to reflect the committed changes. Closed by commit R286:67bcc588feca: Verify mimetypes for all existing sample files, add some more (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20046?vs=54785

D20046: Verify mimetypes for all existing sample files, add some more

astippich accepted this revision. astippich added inline comments. INLINE COMMENTS > extractorcoveragetest.cpp:50 > +m_knownFiles = { > +{ "test.aif", "audio/x-aifc"}, > +{ "test.ape", "audio/x-ape"}, Is it really audio/x-

D20046: Verify mimetypes for all existing sample files, add some more

ngraham accepted this revision. This revision is now accepted and ready to land. REPOSITORY R286 KFileMetaData BRANCH extractor_coverage REVISION DETAIL https://phabricator.kde.org/D20046 To: bruns, #baloo, #frameworks, astippich, ngraham, poboiko Cc: kde-frameworks-devel, gennad, domson,

D20046: Verify mimetypes for all existing sample files, add some more

bruns created this revision. bruns added reviewers: Baloo, Frameworks, astippich, ngraham, poboiko. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Check if the mimetypes for the existing mimetyp