D20312: get username from full name usernameFromFullname(QString fullname) -> QString

ahmedbilal abandoned this revision. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20312 To: ahmedbilal, #frameworks, kde-frameworks-devel, svuorela Cc: svuorela, aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

aacid added a comment. In the "Add Action..." combo you should have an "Abandon" option REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20312 To: ahmedbilal, #frameworks, kde-frameworks-devel, svuorela Cc: svuorela, aacid, kde-frameworks-devel, michaelh,

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

ahmedbilal added a comment. In D20312#446923 , @svuorela wrote: > In D20312#445122 , @ahmedbilal wrote: > > > > > > > > > @svuorela If system have user with same Real Name it would return

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

svuorela added a comment. In D20312#445122 , @ahmedbilal wrote: > > @svuorela If system have user with same Real Name it would return the username of first user. I think, this function should be in Okular instead because there

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

ahmedbilal added a comment. In D20312#444802 , @svuorela wrote: > I think unit tests would be nice. Including unit tests documenting the behavior for multiple users with the same full name. > > My systems have several users named "Sune

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

ahmedbilal added a comment. In D20312#444692 , @aacid wrote: > This code seems like it could live in Okular instead of kcoreaddons? I also want to add that code in Okular but doesn't it look strange to put User info functionality in

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

svuorela requested changes to this revision. svuorela added a comment. This revision now requires changes to proceed. I think unit tests would be nice. Including unit tests documenting the behavior for multiple users with the same full name. My systems have several users named "Sune

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

aacid added a comment. This code seems like it could live in Okular instead of kcoreaddons? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20312 To: ahmedbilal, #frameworks, kde-frameworks-devel Cc: aacid, kde-frameworks-devel, michaelh, ngraham, bruns

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

ahmedbilal added reviewers: Frameworks, kde-frameworks-devel. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20312 To: ahmedbilal, #frameworks, kde-frameworks-devel Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

ahmedbilal removed a reviewer: Okular. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20312 To: ahmedbilal, #okular Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

ahmedbilal removed a reviewer: okular-devel. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20312 To: ahmedbilal, #okular, okular-devel Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

ahmedbilal added reviewers: Okular, okular-devel. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20312 To: ahmedbilal, #okular, okular-devel Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

ahmedbilal added a comment. This helper function will be needed in places where we only have access to author/user's Full name. For Example, PDFs have Full Name in authors. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D20312 To: ahmedbilal Cc:

D20312: get username from full name usernameFromFullname(QString fullname) -> QString

ahmedbilal created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ahmedbilal requested review of this revision. REPOSITORY R244 KCoreAddons BRANCH usernameFromFullname REVISION DETAIL https://phabricator.kde.org/D20312 AFFECTED FILES