D20938: Add Mounts Backend

hallas added a comment. This patch has been superseeded by the wotk @bruns has done in D20995 - so closing this one :D REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20938 To: hallas, #frameworks, ngraham, elvisangelaccio,

D20938: Add Mounts Backend

hallas abandoned this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20938 To: hallas, #frameworks, ngraham, elvisangelaccio, broulik, bruns Cc: svuorela, nicolasfella, ivan, kde-frameworks-devel, michaelh, ngraham, bruns

D20938: Add Mounts Backend

ngraham added a comment. In D20938#460029 , @hallas wrote: > I have tried to modify the fstab backend to also show fuse mounts and a //very// simple prototype is this: > > diff --git a/src/solid/devices/backends/fstab/fstabhandling.cpp

D20938: Add Mounts Backend

hallas added a comment. I have tried to modify the fstab backend to also show fuse mounts and a //very// simple prototype is this: diff --git a/src/solid/devices/backends/fstab/fstabhandling.cpp b/src/solid/devices/backends/fstab/fstabhandling.cpp index 63130c6..3632b52 100644

D20938: Add Mounts Backend

hallas added a comment. In D20938#459628 , @bruns wrote: > In D20938#459627 , @hallas wrote: > > > In D20938#459218 , @bruns wrote: > > > > > Solid

D20938: Add Mounts Backend

bruns added a comment. In D20938#459627 , @hallas wrote: > In D20938#459218 , @bruns wrote: > > > Solid already has a working implementation for reading from /proc/mounts, the fstab backend. > >

D20938: Add Mounts Backend

hallas added a comment. In D20938#459218 , @bruns wrote: > Solid already has a working implementation for reading from /proc/mounts, the fstab backend. > > Contrary to this code, the fstab backend does not poll every second using a timer,

D20938: Add Mounts Backend

hallas added a comment. In D20938#459149 , @ivan wrote: > I'm torn between two approaches: > > - doing what you have done, maybe with a customization point - `fusermount -u` by default, something else for specific mount types; > -

D20938: Add Mounts Backend

bruns requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20938 To: hallas, #frameworks, ngraham, elvisangelaccio, broulik, bruns Cc: svuorela, nicolasfella, ivan, kde-frameworks-devel,

D20938: Add Mounts Backend

bruns added a comment. Solid already has a working implementation for reading from /proc/mounts, the fstab backend. Contrary to this code, the fstab backend does not poll every second using a timer, but correctly uses /proc/mounts changes notification via blocking read. The only

D20938: Add Mounts Backend

ivan added a comment. WRT implementation, I'd also add a link to KMountPoint (https://api.kde.org/frameworks/kio/html/classKMountPoint.html) which provides an interface to fstab/mtab so that Solid/FuseMounts plugin does not need to do any parsing by itself. It works with 'fuse.*'

D20938: Add Mounts Backend

svuorela added a comment. After reading the code a bit, I wonder - can't some of the parsing code be made testable (and tests added) - This likely also requires to get rid of the global static. - rather than poll /proc/mounts every second, I was wondering if one of the filesystem

D20938: Add Mounts Backend

ivan added a comment. @ngraham I guess that **is** the main point of this patch. I don't think that anyone is against that. :) REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20938 To: hallas, #frameworks, ngraham, elvisangelaccio, broulik, bruns Cc:

D20938: Add Mounts Backend

ngraham added a comment. BTW I for one would really like FUSE mounts to show up in the Places panel. See for example https://bugs.kde.org/show_bug.cgi?id=404828 REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20938 To: hallas, #frameworks, ngraham, elvisangelaccio,

D20938: Add Mounts Backend

ivan added a comment. I'm torn between two approaches: - doing what you have done, maybe with a customization point - `fusermount -u` by default, something else for specific mount types; - disabling the teardown operation The rationale for the second one: - The users which

D20938: Add Mounts Backend

hallas added a comment. In D20938#459076 , @ivan wrote: > Thanks for working on this. > > I'd probably call this `fusemounts` backend as it handles only FUSE mounts and nothing else. > > As for the //teardown// operation, some FUSE

D20938: Add Mounts Backend

ivan added a comment. Thanks for working on this. I'd probably call this `fusemounts` backend as it handles only FUSE mounts and nothing else. As for the //teardown// operation, some FUSE backends (cryfs >0.10) have their own unmount commands instead of `fusermount -u`. REPOSITORY

D20938: Add Mounts Backend

elvisangelaccio added reviewers: broulik, bruns. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D20938 To: hallas, #frameworks, ngraham, elvisangelaccio, broulik, bruns Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D20938: Add Mounts Backend

hallas added a comment. This commit is still work-in-progress, but I would really like to get some feedback to the approach. Does it make sense to add a new backend? Or should this functionality be merged with one of the other backends (I was considering the fstab backend)? REPOSITORY

D20938: Add Mounts Backend

hallas created this revision. hallas added reviewers: Frameworks, ngraham, elvisangelaccio. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hallas requested review of this revision. REVISION SUMMARY Adds a new devices backend providing information on Fuse