D20967: [UserMetaData] Add method to query which attributes are set

bruns added a comment. In D20967#480338 , @bcooksley wrote: > Please note that there are very few people involved with Windows builds (despite the number of projects that make use of them in general) so people may not always have the ability

D20967: [UserMetaData] Add method to query which attributes are set

bcooksley added a comment. Please note that there are very few people involved with Windows builds (despite the number of projects that make use of them in general) so people may not always have the ability to respond to every review request. That is why the CI system monitors the state of

D20967: [UserMetaData] Add method to query which attributes are set

bruns added a comment. #windows - thanks for ignoring every review request! REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: bcooksley, arrowd, #freebsd,

D20967: [UserMetaData] Add method to query which attributes are set

bcooksley added a comment. This change has unfortunately made MSVC unhappy - https://build.kde.org/view/Failing/job/Frameworks/job/kfilemetadata/job/kf5-qt5%20WindowsMSVCQt5.11/lastFailedBuild/ REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns,

D20967: [UserMetaData] Add method to query which attributes are set

This revision was automatically updated to reflect the committed changes. Closed by commit R286:bbb05dfe7f9f: [UserMetaData] Add method to query which attributes are set (authored by bruns). REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE

D20967: [UserMetaData] Add method to query which attributes are set

bruns added a comment. FreeBSD and WIndows folks had their chance to speak up - Windows will just have to wait for the CI ... FreeBSD has been reviewed, @arrowd - Thanks! REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns,

D20967: [UserMetaData] Add method to query which attributes are set

astippich accepted this revision. astippich added a comment. This revision is now accepted and ready to land. for the linux part REPOSITORY R286 KFileMetaData BRANCH master REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns, #baloo, #frameworks, astippich, ngraham Cc:

D20967: [UserMetaData] Add method to query which attributes are set

bruns marked 6 inline comments as done. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: arrowd, #freebsd, #windows, kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun,

D20967: [UserMetaData] Add method to query which attributes are set

bruns updated this revision to Diff 59509. bruns added a comment. initialize pos REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20967?vs=59505=59509 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20967 AFFECTED FILES

D20967: [UserMetaData] Add method to query which attributes are set

arrowd added a comment. Now the test passes! INLINE COMMENTS > xattr_p.h:194 > +{ > +int pos; > +QList entries; variable 'pos' is uninitialized REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns, #baloo, #frameworks, astippich, ngraham

D20967: [UserMetaData] Add method to query which attributes are set

bruns updated this revision to Diff 59505. bruns added a comment. add and use split helper for BSD REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20967?vs=59502=59505 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20967 AFFECTED

D20967: [UserMetaData] Add method to query which attributes are set

bruns added a comment. In D20967#477318 , @arrowd wrote: > PASS : UserMetaDataWriterTest::initTestCase() > QDEBUG : UserMetaDataWriterTest::test() extattr_list size: 14 > QDEBUG : UserMetaDataWriterTest::test() extattr_list size: 14

D20967: [UserMetaData] Add method to query which attributes are set

arrowd added a comment. In D20967#477314 , @bruns wrote: > Apparently, the usermetadatawritertest was not executed on *BSD before, can you check if the test succeeds on the old code? Yep, it works on master. The output with

D20967: [UserMetaData] Add method to query which attributes are set

bruns added inline comments. INLINE COMMENTS > xattr_p.h:206 > +#endif > + > +if (size == 0) { @arrowd - please add a `qDebug() << "extattr_list size:" << size;` here > xattr_p.h:232 > +const ssize_t r = extattr_list_file(encodedPath, > EXTATTR_NAMESPACE_USER, data.data(),

D20967: [UserMetaData] Add method to query which attributes are set

bruns added a comment. Apparently, the usermetadatawritertest was not executed on *BSD before, can you check if the test succeeds on the old code? Please submit a PR with the Linux -> UNIX change, and make this one a dependency of it. REPOSITORY R286 KFileMetaData REVISION DETAIL

D20967: [UserMetaData] Add method to query which attributes are set

arrowd added a comment. It compiles now, but the test fails: * Start testing of UserMetaDataWriterTest * Config: Using QtTest library 5.12.2, Qt 5.12.2 (x86_64-little_endian-lp64 shared (dynamic) release build; by Clang 8.0.0 (tags/RELEASE_800/final 356365))

D20967: [UserMetaData] Add method to query which attributes are set

bruns updated this revision to Diff 59502. bruns added a comment. update since REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20967?vs=59500=59502 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20967 AFFECTED FILES

D20967: [UserMetaData] Add method to query which attributes are set

bruns marked 2 inline comments as done. bruns added inline comments. INLINE COMMENTS > arrowd wrote in xattr_p.h:231 > Ditto. > > Also, `size` should be `r`, probably, see below. Why ditto? REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns,

D20967: [UserMetaData] Add method to query which attributes are set

bruns updated this revision to Diff 59500. bruns added a comment. fix BSD code REPOSITORY R286 KFileMetaData CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D20967?vs=57390=59500 BRANCH master REVISION DETAIL https://phabricator.kde.org/D20967 AFFECTED FILES

D20967: [UserMetaData] Add method to query which attributes are set

arrowd added inline comments. INLINE COMMENTS > xattr_p.h:204 > +#elif defined(Q_OS_FREEBSD) || defined(Q_OS_NETBSD) > +const ssize_t size = extattr_list_file(encodedPath, > EXTATTR_NAMESPACE_USER, attributeName, nullptr, 0); > +#endif error: use of undeclared identifier

D20967: [UserMetaData] Add method to query which attributes are set

bruns added subscribers: Windows, FreeBSD. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: #freebsd, #windows, kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun,

D20967: [UserMetaData] Add method to query which attributes are set

bruns added a comment. Ping! REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: kde-frameworks-devel, LeGast00n, domson, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams

D20967: [UserMetaData] Add method to query which attributes are set

bruns added a dependent revision: D21004: [UserMetaData] Shortcut attribute queries for the common case. REPOSITORY R286 KFileMetaData REVISION DETAIL https://phabricator.kde.org/D20967 To: bruns, #baloo, #frameworks, astippich, ngraham Cc: kde-frameworks-devel, gennad, domson,

D20967: [UserMetaData] Add method to query which attributes are set

bruns created this revision. bruns added reviewers: Baloo, Frameworks, astippich, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Many files have no UserMetaData attributes set at all,