This revision was automatically updated to reflect the committed changes.
Closed by commit R39:066004396d57: fix vi mode unit test (authored by cullmann).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D23225?vs=63944=63973#toc
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
cullmann added a comment.
Jonathan, could you take a look? Thanks.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D23225
To: verner, cullmann
Cc: dfaure, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh,
ngraham, bruns, demsking, cullmann, sars,
cullmann reopened this revision.
This revision is now accepted and ready to land.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D23225
To: verner, cullmann
Cc: dfaure, kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh,
ngraham, bruns, demsking,
dfaure added a comment.
The unittest doesn't seem to pass on CI:
https://build.kde.org/job/Frameworks/job/ktexteditor/job/kf5-qt5%20SUSEQt5.12/149/testReport/junit/projectroot.autotests.src/vimode/vimode_emulatedcommandbar/
FAIL! : EmulatedCommandBarTest::EmulatedCommandBarTests()
This revision was automatically updated to reflect the committed changes.
Closed by commit R39:622bd6c94803: Allow 0 in line ranges in vim mode.
(authored by verner, committed by cullmann).
REPOSITORY
R39 KTextEditor
CHANGES SINCE LAST UPDATE
cullmann accepted this revision.
cullmann added a comment.
This revision is now accepted and ready to land.
Seems reasonable, thanks for taking care ;=)
I you use the vi mode, we have more open vi mode bugs that need some love:
verner added a reviewer: cullmann.
REPOSITORY
R39 KTextEditor
REVISION DETAIL
https://phabricator.kde.org/D23225
To: verner, cullmann
Cc: kwrite-devel, kde-frameworks-devel, LeGast00n, domson, michaelh, ngraham,
bruns, demsking, cullmann, sars, dhaumann
verner created this revision.
Herald added projects: Kate, Frameworks.
Herald added subscribers: kde-frameworks-devel, kwrite-devel.
verner requested review of this revision.
REVISION SUMMARY
Vim numbers lines starting from 1. However, in command ranges such as, e.g.,
0,$s/foo/bar/g
it
