D24684: Use ECMGenerateExportHeader to manage deprecated API better

This revision was automatically updated to reflect the committed changes. Closed by commit R241:aa5b0d89b2ed: Use ECMGenerateExportHeader to manage deprecated API better (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D24684?vs=68210=68257#toc REPOSITORY R241 KIO

D24684: Use ECMGenerateExportHeader to manage deprecated API better

dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. OK it's very likely that KIOCORE_NO_DEPRECATED didn't work anyway, as I found out in other frameworks where I tried enabling this kind of thing. REPOSITORY R241 KIO BRANCH

D24684: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added inline comments. INLINE COMMENTS > dfaure wrote in global.h:105 > LOL 3.4 was long ago ;) > > good find :) Thankfully phabricator and its locate-file, go-to-version-before-commit & tags listing for commit was helpful here to good degrees, so that usually tool < 1 min to find

D24684: Use ECMGenerateExportHeader to manage deprecated API better

kossebau edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24684 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24684: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. In D24684#549785 , @dfaure wrote: > The commit log says KIOKIOFILEWIDGETS with KIO duplicated, that's a typo in the commit log, but only there, right? Typo indeed, fixed. INLINE COMMENTS > dfaure wrote in

D24684: Use ECMGenerateExportHeader to manage deprecated API better

kossebau edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24684 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24684: Use ECMGenerateExportHeader to manage deprecated API better

dfaure added inline comments. INLINE COMMENTS > global.cpp:99 > > -#ifndef KIOCORE_NO_DEPRECATED > KIOCORE_EXPORT QTime KIO::calculateRemaining(KIO::filesize_t totalSize, > KIO::filesize_t processedSize, KIO::filesize_t speed) Isn't some ifdef still needed for this deprecated method? >

D24684: Use ECMGenerateExportHeader to manage deprecated API better

dfaure added a comment. The commit log says KIOKIOFILEWIDGETS with KIO duplicated, that's a typo in the commit log, but only there, right? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24684 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2,

D24684: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. Ping... would be happy if this one could get reviewed ASAP, so we have the patches for all of KF modules in and can enable the group KF_* macros, so people can conveniently use -DKF_DISABLE_DEPRECATED_BEFORE_AND_AT=0Xxx in their projects :) REPOSITORY R241

D24684: Use ECMGenerateExportHeader to manage deprecated API better

kossebau updated this revision to Diff 68210. kossebau added a comment. update to latest master and new deprecated API REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24684?vs=68021=68210 BRANCH useECMGenerateExportHeader REVISION DETAIL

D24684: Use ECMGenerateExportHeader to manage deprecated API better

kossebau edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24684 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24684: Use ECMGenerateExportHeader to manage deprecated API better

dfaure added a comment. The commit log talks about KCalendarCore instead of KIO :) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D24684 To: kossebau, #frameworks, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D24684: Use ECMGenerateExportHeader to manage deprecated API better

kossebau updated this revision to Diff 68021. kossebau added a comment. update to latest master REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24684?vs=68018=68021 BRANCH useECMGenerateExportHeader REVISION DETAIL https://phabricator.kde.org/D24684

D24684: Use ECMGenerateExportHeader to manage deprecated API better

kossebau added a comment. No support for EXCLUDE_DEPRECATED_BEFORE_AND_AT here as well, that needs another round of work. Thus the removal of all the KIOWIDGETS_NO_DEPRECATED from the source files, no *_BUILD_DEPRECATED_SINCE there to properly replace them for now. So patch solely

D24684: Use ECMGenerateExportHeader to manage deprecated API better

kossebau created this revision. kossebau added reviewers: Frameworks, dfaure. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. kossebau requested review of this revision. REVISION SUMMARY Allows - projects linking to KCalendarCore to hide deprecated API