D26484: Popup menu again to reposition it

trmdi updated this revision to Diff 73273. trmdi added a comment. - use the flag approach and add DropJob::menuPopup() REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26484?vs=73175=73273 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26484

D26484: Popup menu again to reposition it

trmdi added inline comments. INLINE COMMENTS > elvisangelaccio wrote in dropjob.cpp:415 > `QCursor::pos()` should be avoided as it's not reliable on wayland. > > The whole "popup() again" here looks like a workaround to me. Can't this be > fixed on the plasma side? > Can't this be fixed on

D26484: Popup menu again to reposition it

trmdi added inline comments. INLINE COMMENTS > elvisangelaccio wrote in dropjob.cpp:415 > `QCursor::pos()` should be avoided as it's not reliable on wayland. > > The whole "popup() again" here looks like a workaround to me. Can't this be > fixed on the plasma side? I'm having a plan to make

D26484: Popup menu again to reposition it

elvisangelaccio added inline comments. INLINE COMMENTS > dropjob.cpp:415 > +// popup again to update position. BUG: 415917 > +menu->popup(window ? window->mapToGlobal(m_relativePos) : > QCursor::pos()); > } `QCursor::pos()` should be avoided as it's not reliable on

D26484: Popup menu again to reposition it

trmdi added a comment. In D26484#591782 , @dfaure wrote: > Sorry I have no idea about the calling side in plasma. It sounds buggy indeed, if those are all calls on the same DropJob instance. Yes, you could check it here:

D26484: Popup menu again to reposition it

dfaure requested changes to this revision. dfaure added a comment. This revision now requires changes to proceed. Sorry I have no idea about the calling side in plasma. It sounds buggy indeed, if those are all calls on the same DropJob instance. INLINE COMMENTS > dropjob.cpp:409 >

D26484: Popup menu again to reposition it

trmdi added a comment. @mart @dfaure I have some question. 1, Should `DropJob::setApplicationActions()` be called only one time? 2, I see this when I drop multiple file types at once to the desktop (e.g. 2 jpg and 1 zip), the `DropJob::setApplicationActions()` is called 3 times as

D26484: Popup menu again to reposition it

trmdi retitled this revision from "Add a new parameter for delaying showing menu" to "Popup menu again to reposition it". REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26484 To: trmdi, #frameworks, davidedmundson, elvisangelaccio, mart, dfaure Cc: broulik,