D26983: Enable adding place as first child

gvgeo added a comment. In D26983#629925 , @ngraham wrote: > That's not how this works; reviewers being slow is not a good reason to abandon a patch. If you've lost interest in it, you can ask someone else can take it over, but just throwing

D26983: Enable adding place as first child

ngraham added a comment. That's not how this works; reviewers being slow is not a good reason to abandon a patch. If you've lost interest in it, you can ask someone else can take it over, but just throwing away the work is pretty sad. REPOSITORY R241 KIO REVISION DETAIL

D26983: Enable adding place as first child

gvgeo abandoned this revision. gvgeo added a comment. Thanks for your help @meven, but I 'll close this patch now. It doesn't seem to be high in priorities. And to be honest among other reasons, after I found how problematic the code is, I'm not so keen on building on top of it.

D26983: Enable adding place as first child

gvgeo edited the summary of this revision. REPOSITORY R241 KIO BRANCH after (branched from master) REVISION DETAIL https://phabricator.kde.org/D26983 To: gvgeo, #frameworks, meven, broulik, dfaure, ngraham Cc: ngraham, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, bruns

D26983: Enable adding place as first child

gvgeo added inline comments. INLINE COMMENTS > kfileplacesmodel.cpp:1059 > { > -KBookmark bookmark = KFilePlacesItem::createBookmark(d->bookmarkManager, > - text, url, iconName); > +KBookmark bookmark = KFilePlacesItem::createBookmark(d->bookmarkManager, > text,

D26983: Enable adding place as first child

ngraham accepted this revision. ngraham added inline comments. INLINE COMMENTS > kfileplacesmodel.cpp:1059 > { > -KBookmark bookmark = KFilePlacesItem::createBookmark(d->bookmarkManager, > - text, url, iconName); > +KBookmark bookmark =

D26983: Enable adding place as first child

gvgeo added a comment. ping #frameworks REPOSITORY R241 KIO BRANCH after (branched from master) REVISION DETAIL https://phabricator.kde.org/D26983 To: gvgeo, #frameworks, meven, broulik, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack,

D26983: Enable adding place as first child

gvgeo edited the test plan for this revision. REPOSITORY R241 KIO BRANCH after (branched from master) REVISION DETAIL https://phabricator.kde.org/D26983 To: gvgeo, #frameworks, meven, broulik, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26983: Enable adding place as first child

gvgeo added a comment. ping REPOSITORY R241 KIO BRANCH after (branched from master) REVISION DETAIL https://phabricator.kde.org/D26983 To: gvgeo, #frameworks, meven, broulik, dfaure Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D26983: Enable adding place as first child

gvgeo added a comment. After some digging, I found that KBookmarkGroup has more items that the KFilePlacesModel. It is impossible to make `KBookmark` move at the end of a `BookmarkGroup`, if the item is not in the `KFilePlacesModel`. I don't see a better solution than the current

D26983: Enable adding place as first child

gvgeo updated this revision to Diff 74749. gvgeo edited the test plan for this revision. gvgeo added a comment. This revision is now accepted and ready to land. The last index is incorrect, and I can't find a way to get the proper one. Restoring first revision, which keeps the functionality

D26983: Enable adding place as first child

gvgeo edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26983 To: gvgeo, #frameworks, meven, broulik, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26983: Enable adding place as first child

gvgeo edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26983 To: gvgeo, #frameworks, meven, broulik, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26983: Enable adding place as first child

gvgeo edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26983 To: gvgeo, #frameworks, meven, broulik, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26983: Enable adding place as first child

gvgeo planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26983 To: gvgeo, #frameworks, meven, broulik, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26983: Enable adding place as first child

meven added a comment. Before: Adding a place as first child will place it at the end. What is after ? How do I test this exactly ? REPOSITORY R241 KIO BRANCH after (branched from master) REVISION DETAIL https://phabricator.kde.org/D26983 To: gvgeo, #frameworks, meven,

D26983: Enable adding place as first child

gvgeo updated this revision to Diff 74690. gvgeo added a comment. This revision is now accepted and ready to land. count -1 REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26983?vs=74689=74690 BRANCH after (branched from master) REVISION DETAIL

D26983: Enable adding place as first child

gvgeo planned changes to this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D26983 To: gvgeo, #frameworks, meven, broulik, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26983: Enable adding place as first child

gvgeo updated this revision to Diff 74689. gvgeo added a comment. Revert style edit REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26983?vs=74688=74689 BRANCH after (branched from master) REVISION DETAIL https://phabricator.kde.org/D26983 AFFECTED FILES

D26983: Enable adding place as first child

gvgeo marked 3 inline comments as done. REPOSITORY R241 KIO BRANCH after (branched from master) REVISION DETAIL https://phabricator.kde.org/D26983 To: gvgeo, #frameworks, meven, broulik, dfaure Cc: kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham, bruns

D26983: Enable adding place as first child

gvgeo retitled this revision from "[WIP]Enable adding place as first child" to "Enable adding place as first child". REPOSITORY R241 KIO BRANCH after (branched from master) REVISION DETAIL https://phabricator.kde.org/D26983 To: gvgeo, #frameworks, meven, broulik, dfaure Cc: