D27204: Fix the KNSQuick Dialog's close title and basic layout

2020-02-07 Thread Dan Leinir Turthra Jensen
This revision was automatically updated to reflect the committed changes. Closed by commit R304:fd5b37818e6a: Fix the KNSQuick Dialog's close title and basic layout (authored by leinir). REPOSITORY R304 KNewStuff CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27204?vs=75151&id=75165

D27204: Fix the KNSQuick Dialog's close title and basic layout

2020-02-07 Thread Dan Leinir Turthra Jensen
leinir added a comment. In D27204#607325 , @ngraham wrote: > LGTM and fixes all the bugs! Thanks. Thanks! :D > If it lands quickly, I wonder if it would be worth it to try and squeeze this into Frameworks 5.67 so all the peop

D27204: Fix the KNSQuick Dialog's close title and basic layout

2020-02-07 Thread Nathaniel Graham
ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM and fixes all the bugs! Thanks. If it lands quickly, I wonder if it would be worth it to try and squeeze this into Frameworks 5.67 so all the people using this dialog in Plasma 5

D27204: Fix the KNSQuick Dialog's close title and basic layout

2020-02-07 Thread Dan Leinir Turthra Jensen
leinir edited the test plan for this revision. leinir added reviewers: Frameworks, ngraham. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D27204 To: leinir, #frameworks, ngraham Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27204: Fix the KNSQuick Dialog's close title and basic layout

2020-02-07 Thread Dan Leinir Turthra Jensen
leinir created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. leinir requested review of this revision. REVISION SUMMARY This resolves several issues found in the KNSQuick Dialog component. Specifically it puts a background in the dialog