D27245: Ki18n: Convert license headers to SPDX statements

This revision was automatically updated to reflect the committed changes. Closed by commit R249:10971279a3e7: Ki18n: Convert license headers to SPDX statements (authored by cordlandwehr). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27245?vs=75592&id=78740 RE

D27245: Ki18n: Convert license headers to SPDX statements

cgiboudeaux accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27245 To: cordlandwehr, cgiboudeaux Cc: kossebau, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngra

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr marked 4 inline comments as done. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D27245 To: cordlandwehr Cc: kossebau, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr added a comment. Regarding the removal of the COPYING.LIB file, I would prefer to wait and remove all of them in all repositories in one run. It will be a trivial script to review. My main argument is that I did not yet remove them in other pull requests, so for consistency I

D27245: Ki18n: Convert license headers to SPDX statements

cgiboudeaux added a comment. In D27245#619834 , @cordlandwehr wrote: > So, how to move forward with this change? The two open discussion points are: > > - How to handle COPYING files? --> IMO this is a general question that I want to addres

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr added a comment. Ping :) REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D27245 To: cordlandwehr Cc: kossebau, cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr added a comment. So, how to move forward with this change? The two open discussion points are: - How to handle COPYING files? --> IMO this is a general question that I want to address in a global change when we updated all the license headers. For this I created a task to tr

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr added a comment. In D27245#614915 , @kossebau wrote: > What about the `COPYING.LIB` file (containing LGLP 2.1 text) in the root directory? Could that not be removed given the new copy `LICENSES/LGPL-2.1-only.txt`? > Or are both c

D27245: Ki18n: Convert license headers to SPDX statements

kossebau added a comment. What about the `COPYING.LIB` file (containing LGLP 2.1 text) in the root directory? Could that not be removed given the new copy `LICENSES/LGPL-2.1-only.txt`? Or are both copies required? If so, why? Similar question also for any other repo. REPOSITORY R249 KI1

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr added a comment. Link to issue on reuse-tool tracker regarding empty lines in LGPL-3.0-only license text: https://github.com/fsfe/reuse-tool/issues/178 REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D27245 To: cordlandwehr Cc: cgiboudeaux, kde-frameworks-

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr added inline comments. INLINE COMMENTS > cgiboudeaux wrote in LGPL-3.0-only.txt:15-17 > well, the SPDX text doesn't have these extra lines: > https://spdx.org/licenses/LGPL-3.0-only.html#licenseText Just tested again with the reuse tool and it actually provides the license with the

D27245: Ki18n: Convert license headers to SPDX statements

cgiboudeaux added inline comments. INLINE COMMENTS > cordlandwehr wrote in LGPL-3.0-only.txt:15-17 > Actually, I have no idea. But according to the REUSE specification, the > license files must no be changed and used exactly as provided by SPDX. > All license files, except the LicenseRef files,

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr marked an inline comment as done. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D27245 To: cordlandwehr Cc: cgiboudeaux, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr updated this revision to Diff 75592. cordlandwehr added a comment. Remove unneeded whitespace REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27245?vs=75591&id=75592 BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27245 AFFECTED FI

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr updated this revision to Diff 75591. cordlandwehr added a comment. Unify license comment header style REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27245?vs=75246&id=75591 BRANCH spdx REVISION DETAIL https://phabricator.kde.org/D27245 AFF

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr added inline comments. INLINE COMMENTS > cgiboudeaux wrote in LGPL-3.0-only.txt:15-17 > why are there so many empty lines? Actually, I have no idea. But according to the REUSE specification, the license files must no be changed and used exactly as provided by SPDX. All license file

D27245: Ki18n: Convert license headers to SPDX statements

cgiboudeaux added a comment. some headers have 3 leading whitespaces, some 4. Can you clarify? INLINE COMMENTS > LGPL-3.0-only.txt:15-17 > + > + > + why are there so many empty lines? > gettext.h:2 > /* Convenience header for conditional use of GNU . > - Copyright (C) 1995-1998, 20

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr added a task: T11550: Add SPDX License markers. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D27245 To: cordlandwehr Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27245: Ki18n: Convert license headers to SPDX statements

cordlandwehr created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. cordlandwehr requested review of this revision. REVISION SUMMARY Convert license statements to SPDX and add license text files in LICENSES folder as required by the REUSE sp