D27497: Fix code generation for entries with min/max

meven added inline comments. INLINE COMMENTS > test_properties_minmax.h.ref:43 > +Q_PROPERTY(int bar READ bar WRITE setBar NOTIFY barChanged) > +Q_PROPERTY(bool isBarImmutable CONSTANT) > +/** This is incorrrect since D27496 , too bad this was

D27497: Fix code generation for entries with min/max

This revision was automatically updated to reflect the committed changes. Closed by commit R237:d218b93a5350: Fix code generation for entries with min/max (authored by hchain). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27497?vs=76368=76371 REVISION

D27497: Fix code generation for entries with min/max

hchain updated this revision to Diff 76368. hchain added a comment. add bugzilla REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27497?vs=76317=76368 REVISION DETAIL https://phabricator.kde.org/D27497 AFFECTED FILES

D27497: Fix code generation for entries with min/max

ervin accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27497 To: hchain, meven, crossi, ervin, bport, tcanabrava Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27497: Fix code generation for entries with min/max

ervin edited the summary of this revision. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27497 To: hchain, meven, crossi, ervin, bport, tcanabrava Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27497: Fix code generation for entries with min/max

hchain updated this revision to Diff 76317. hchain added a comment. const, change method name, reformat code REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27497?vs=75987=76317 REVISION DETAIL https://phabricator.kde.org/D27497 AFFECTED FILES

D27497: Fix code generation for entries with min/max

ervin added a comment. A few smallish issues only, otherwise LGTM. INLINE COMMENTS > KConfigSourceGenerator.cpp:316 > { > - stream() << " " << itemPath(entry, cfg()) << " = " > +QString innerItemVarStr(innerItemVar(entry, cfg())); > +if (!entry->signalList.isEmpty()) { I'd const

D27497: Fix code generation for entries with min/max

ervin requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D27497 To: hchain, meven, crossi, ervin, bport, tcanabrava Cc: kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27497: Fix code generation for entries with min/max

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Seems good to me INLINE COMMENTS > test_param_minmax.h.ref:25 > + { > +qDebug() << "setFoo: value " << v << " is less than the minimum > value of 0.01"; > +v = 0.01;

D27497: Fix code generation for entries with min/max

hchain updated this revision to Diff 75987. hchain added a comment. Add reference files for other tests that were impacted REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27497?vs=75985=75987 REVISION DETAIL https://phabricator.kde.org/D27497 AFFECTED

D27497: Fix code generation for entries with min/max

hchain updated this revision to Diff 75985. hchain added a comment. Reduce number of lines in generated test code REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27497?vs=75983=75985 REVISION DETAIL https://phabricator.kde.org/D27497 AFFECTED FILES

D27497: Fix code generation for entries with min/max

hchain updated this revision to Diff 75983. hchain added a comment. Yet more style fixes REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27497?vs=75982=75983 REVISION DETAIL https://phabricator.kde.org/D27497 AFFECTED FILES

D27497: Fix code generation for entries with min/max

hchain updated this revision to Diff 75982. hchain added a comment. Fix Style/whitespace REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27497?vs=75978=75982 REVISION DETAIL https://phabricator.kde.org/D27497 AFFECTED FILES

D27497: Fix code generation for entries with min/max

bport added inline comments. INLINE COMMENTS > test_param_minmax.kcfg:17 > + > \ No newline at end of file Add a new line > test_param_minmax.kcfgc:4 > +Mutators=true > \ No newline at end of file add a new line > test_param_minmax_main.cpp:28 > +return 0; > +} Missing new line at end

D27497: Fix code generation for entries with min/max

hchain created this revision. hchain added reviewers: meven, crossi, ervin, bport, tcanabrava. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. hchain requested review of this revision. REVISION SUMMARY - When GenerateProperties and Mutators are activated,