D27540: Status indicator for individual widgets in KCModule

ervin added a comment. In D27540#615160 , @ervin wrote: > In D27540#615156 , @ngraham wrote: > > > Please add screenshots to the Test Plan section for patches that change the UI. :) Also it would

D27540: Status indicator for individual widgets in KCModule

ervin edited the test plan for this revision. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg Cc: iasensio, davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27540: Status indicator for individual widgets in KCModule

ervin updated this revision to Diff 76362. ervin added a comment. Handle visibility of the tracked widget, setters become slots, and add plural to "indicatorWidgets". REPOSITORY R265 KConfigWidgets CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27540?vs=76089=76362 REVISION

D27540: Status indicator for individual widgets in KCModule

ervin added a comment. In D27540#615091 , @davidre wrote: > The editmarks should probably respect the visibility of the associated widget. In this picture I use a invisble lineedit to manage the settings of the QButtonGroup beneath

D27540: Status indicator for individual widgets in KCModule

ervin added a comment. In D27540#615132 , @davidre wrote: > They stick around because as you said the settings differ from the defaults. Right, so "not a bug" (as in that's what's the patch is intended to do so far). > The pen for

D27540: Status indicator for individual widgets in KCModule

ervin added a comment. In D27540#615156 , @ngraham wrote: > Please add screenshots to the Test Plan section for patches that change the UI. :) Also it would be nice to indicate how someone can test this. Which apps? System Settings? Where? How?

D27540: Status indicator for individual widgets in KCModule

ngraham added a comment. Please add screenshots to the Test Plan section for patches that change the UI. :) Also it would be nice to indicate how someone can test this. Which apps? System Settings? Where? How? REPOSITORY R265 KConfigWidgets REVISION DETAIL

D27540: Status indicator for individual widgets in KCModule

davidre added a comment. In D27540#615129 , @ervin wrote: > In D27540#615105 , @davidre wrote: > > > In D27540#615092 , @ervin wrote: > > > > > In

D27540: Status indicator for individual widgets in KCModule

ervin added a comment. In D27540#615105 , @davidre wrote: > In D27540#615092 , @ervin wrote: > > > In D27540#615061 , @davidre wrote: > > > > > How

D27540: Status indicator for individual widgets in KCModule

davidre added a reviewer: VDG. REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport, #vdg Cc: davidre, kde-frameworks-devel, LeGast00n, cblack, GB_2, michaelh, ngraham, bruns

D27540: Status indicator for individual widgets in KCModule

davidre added a comment. In D27540#615092 , @ervin wrote: > In D27540#615061 , @davidre wrote: > > > How does it look? Will this be opt in for other users of KConfigDialogManager? > > > I'd

D27540: Status indicator for individual widgets in KCModule

davidre added a comment. The editmarks should probably respect the visibility of the associated widget. In this picture I use a invisble lineedit to manage the settings of the QButtonGroup beneath (QButtonGroup isn't supported by KCOnfigDialogManager) F8117874: grafik.png

D27540: Status indicator for individual widgets in KCModule

ervin added a comment. In D27540#615091 , @davidre wrote: > The editmarks should probably respect the visibility of the associated widget. In this picture I use a invisble lineedit to manage the settings of the QButtonGroup beneath

D27540: Status indicator for individual widgets in KCModule

ervin added a comment. In D27540#615061 , @davidre wrote: > How does it look? Will this be opt in for other users of KConfigDialogManager? I'd say you should try it. ;-) I really need wider feedback on how it behaves in different

D27540: Status indicator for individual widgets in KCModule

ervin added inline comments. INLINE COMMENTS > meven wrote in kconfigdialogmanager_p.h:60 > I would have named those with s : indicatorWidgets, knownWidgets, buddyWidgets Not gonna rename those though, I'm merely moving code around (apart from indicatorWidget I could at least rename that one

D27540: Status indicator for individual widgets in KCModule

davidre added a comment. How does it look? Will this be opt in for other users of KConfigDialogManager? REPOSITORY R265 KConfigWidgets REVISION DETAIL https://phabricator.kde.org/D27540 To: ervin, ngraham, davidedmundson, meven, crossi, bport Cc: davidre, kde-frameworks-devel,

D27540: Status indicator for individual widgets in KCModule

meven added inline comments. INLINE COMMENTS > kconfigdialogmanager_p.h:60 > +QHash buddyWidget; > +QHash indicatorWidget; > +QSet allExclusiveGroupBoxes; I would have named those with s : indicatorWidgets, knownWidgets, buddyWidgets > settingsstatusindicator_p.h:41 > +bool

D27540: Status indicator for individual widgets in KCModule

ervin created this revision. ervin added reviewers: ngraham, davidedmundson, meven, crossi, bport. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. ervin requested review of this revision. REVISION SUMMARY Extend KConfigDialogManager internals to insert a