D27804: smb: add hack to support spaces in workgroup names

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R320:f40191a147c9: smb: add hack to support spaces in workgroup names (authored by sitter). CHANGED PRIOR TO COMMIT

D27804: smb: add hack to support spaces in workgroup names

sitter added a comment. Yep. I'm 100% certain of this. The library in fact has no API that returns a complete URL or anything near a complete URL. It's using dirent-inspired API to let us iterate/stat paths and only ever returns paths relative to whatever input it got, from those paths we

D27804: smb: add hack to support spaces in workgroup names

thiago added a comment. In D27804#621988 , @sitter wrote: > In D27804#621970 , @thiago wrote: > > > Still want to see that round-trip. > > > But why? Converting an smbcUrl to a QUrl would

D27804: smb: add hack to support spaces in workgroup names

sitter added a comment. In D27804#621988 , @sitter wrote: > In D27804#621970 , @thiago wrote: > > > Still want to see that round-trip. > > > But why? Converting an smbcUrl to a QUrl would

D27804: smb: add hack to support spaces in workgroup names

sitter added a comment. In D27804#621970 , @thiago wrote: > Still want to see that round-trip. But why? Converting an smbcUrl to a QUrl would literally be useless code. REPOSITORY R320 KIO Extras REVISION DETAIL

D27804: smb: add hack to support spaces in workgroup names

thiago added a comment. Still want to see that round-trip. INLINE COMMENTS > smburltest.cpp:112 > +// % character - run through .url() to simulate behavior of our > listDir() > + > QCOMPARE(SMBUrl(QUrl(QUrl("smb://?kio-workgroup=HAX%MAX").url())).toSmbcUrl(), > +

D27804: smb: add hack to support spaces in workgroup names

sitter updated this revision to Diff 76934. sitter added a comment. extend test coverage to % character in wg and umlaut in wg. I've also changed the construction in browse.cpp to use QUrlQuery so it does not trip over potential hash or question marks in the workgroup libsmbc is

D27804: smb: add hack to support spaces in workgroup names

thiago added a comment. Looks good, but testing should be extended. I suggest: 1. A workgroup with non-US-ASCII characters in the name, if that's permitted 2. A workgroup with % in the name: the URL should have "%25" 3. Roundtrip checking. The test only does toSmbcUrl(), so please

D27804: smb: add hack to support spaces in workgroup names

sitter created this revision. sitter added a reviewer: ngraham. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. sitter requested review of this revision. REVISION SUMMARY workgroup names are as best I can tell always still netbios names