D27923: [FileIndexScheduler] Cleanup firstRun handling

ngraham added a comment. In D27923#627611 , @bruns wrote: > In D27923#627606 , @ngraham wrote: > > > Maybe next we should make `baloo_file` get killed automatically when indexing is disabled. ;)

D27923: [FileIndexScheduler] Cleanup firstRun handling

This revision was automatically updated to reflect the committed changes. Closed by commit R293:ea77c412324e: [FileIndexScheduler] Cleanup firstRun handling (authored by bruns). REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27923?vs=77580=77641 REVISION

D27923: [FileIndexScheduler] Cleanup firstRun handling

bruns added a comment. In D27923#627606 , @ngraham wrote: > Maybe next we should make `baloo_file` get killed automatically when indexing is disabled. ;) baloo_file **is** stopped when you disable indexing, so I don't know what you are

D27923: [FileIndexScheduler] Cleanup firstRun handling

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Good stuff. Maybe next we should make `baloo_file` get killed automatically when indexing is disabled. ;) REPOSITORY R293 Baloo BRANCH submit REVISION DETAIL

D27923: [FileIndexScheduler] Cleanup firstRun handling

bruns updated this revision to Diff 77580. bruns added a comment. fix deprecation REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27923?vs=77309=77580 BRANCH submit REVISION DETAIL https://phabricator.kde.org/D27923 AFFECTED FILES

D27923: [FileIndexScheduler] Cleanup firstRun handling

bruns marked 2 inline comments as done. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D27923 To: bruns, #baloo, ngraham Cc: broulik, kde-frameworks-devel, hurikhan77, lots0logs, LeGast00n, cblack, fbampaloukas, GB_2, domson, ashaposhnikov, michaelh, astippich, spoorun,

D27923: [FileIndexScheduler] Cleanup firstRun handling

bruns updated this revision to Diff 77309. bruns added a comment. Mark as @deprecated since 5.69 whitespace REPOSITORY R293 Baloo CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27923?vs=77190=77309 BRANCH submit REVISION DETAIL https://phabricator.kde.org/D27923 AFFECTED

D27923: [FileIndexScheduler] Cleanup firstRun handling

broulik added inline comments. INLINE COMMENTS > indexerstate.h:41 > Unavailable, > + Startup, > }; Indentation > indexerconfig.cpp:112 > > +// KF6 TODO: remove > bool IndexerConfig::firstRun() const Please mark them as deprecated in the header file REPOSITORY R293 Baloo

D27923: [FileIndexScheduler] Cleanup firstRun handling

bruns created this revision. bruns added reviewers: Baloo, ngraham. Herald added projects: Frameworks, Baloo. Herald added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY firstRun is an internal state of baloo, there is no need to write it to the