D28599: [configview] Simplify code / workaround Qt5.15 crash

2020-04-06 Thread David Edmundson
davidedmundson updated this revision to Diff 79469. davidedmundson added a comment. setContextProprerties REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28599?vs=79423=79469 BRANCH master REVISION DETAIL

D28599: [configview] Simplify code / workaround Qt5.15 crash

2020-04-06 Thread David Edmundson
This revision was automatically updated to reflect the committed changes. Closed by commit R242:0417bf61d53a: [configview] Simplify code / workaround Qt5.15 crash (authored by davidedmundson). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D28599: [configview] Simplify code / workaround Qt5.15 crash

2020-04-05 Thread Aleix Pol Gonzalez
apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. LGTM INLINE COMMENTS > configview.cpp:137 > > + > q->engine()->rootContext()->setContextProperty(QStringLiteral("plasmoid"), > applet.data()->property("_plasma_graphicObject").value());

D28599: [configview] Simplify code / workaround Qt5.15 crash

2020-04-05 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. davidedmundson requested review of this revision. REVISION SUMMARY QQmlComponent::beginCreate and completeCreate are useful if you