D29136: Use non-deprecated KDEInstallDir

dfaure added a comment. (to remove some confusion: the previous comment had the wrong link and should have said "Abandoned in favour of https://phabricator.kde.org/D29299"; -- but now it's reopened anyway, as an alternative to D29299 ) REPOSITORY R249 K

D29136: Use non-deprecated KDEInstallDir

heikobecker reclaimed this revision. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D29136 To: heikobecker Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, bruns

D29136: Use non-deprecated KDEInstallDir

heikobecker abandoned this revision. heikobecker added a comment. Abandoned in favour of https://phabricator.kde.org/D29136 REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D29136 To: heikobecker Cc: kossebau, kde-frameworks-devel, LeGast00n, cblack, michaelh, ngraham, b

D29136: Use non-deprecated KDEInstallDir

kossebau added a comment. In D29136#660358 , @heikobecker wrote: > > Where would you see "that the macro already used KDEInstallDirs before"? When it comes to "LOCALE_INSTALL_DIR", that is set to a default is not set when calling the macro. Ide

D29136: Use non-deprecated KDEInstallDir

heikobecker added a comment. > Where would you see "that the macro already used KDEInstallDirs before"? When it comes to "LOCALE_INSTALL_DIR", that is set to a default is not set when calling the macro. Ideally would be documented though. (my first approach would be to also allow a soft depe

D29136: Use non-deprecated KDEInstallDir

kossebau added a comment. I understand the desire for pragmatic solution, but I am too old now and have seen too many places where being pragmatic at one point resulted in tightly coupled systems which later prevented progress. When it comes to build dependencies, forcing users of a produc

D29136: Use non-deprecated KDEInstallDir

heikobecker added a comment. In D29136#660270 , @kossebau wrote: > using kdeinstalldirs variables needs to ensure that KDEInstallDirs has been included before, also introduces ahard dependency on ECM for any users of KI18n. While 99% of apps us

D29136: Use non-deprecated KDEInstallDir

kossebau added a comment. Just came by, have to get back later, but first comment: using kdeinstalldirs variables needs to ensure that KDEInstallDirs has been included before, also introduces ahard dependency on ECM for any users of KI18n. While 99% of apps using KI18n might do this, by de

D29136: Use non-deprecated KDEInstallDir

heikobecker updated this revision to Diff 81035. heikobecker added a comment. Added missing parentheses REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29136?vs=81033&id=81035 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29136 AFFECTED FIL

D29136: Use non-deprecated KDEInstallDir

heikobecker created this revision. Herald added a project: Frameworks. Herald added a subscriber: kde-frameworks-devel. heikobecker requested review of this revision. REVISION SUMMARY I noticed that when installeding marble, which sets KDE_INSTALL_DIRS_NO_DEPRECATED, which then invalidates a p