bport abandoned this revision.
bport added a comment.
Follow up on gitlab
https://invent.kde.org/kde/kwayland-server/-/merge_requests/1
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D29231
To: bport, zzag, davidedmundson, apol
Cc: romangg, crossi,
ngraham added a dependent revision: D29272: Add support to keyboard shortcuts
inhibitor.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D29231
To: bport, zzag, davidedmundson, apol
Cc: romangg, crossi, kde-frameworks-devel, LeGast00n, cblack, michaelh,
ngraham, bruns
davidedmundson added inline comments.
INLINE COMMENTS
> zzag wrote in keyboard_shortcuts_inhibit_interface.cpp:21
> You've probably meant Q_DECL_HIDDEN, right?
>
> On an unrelated note: there are valid arguments against nested private
> classes so it would be really nice if we revisit this
zzag added inline comments.
INLINE COMMENTS
> davidedmundson wrote in keyboard_shortcuts_inhibit_interface.cpp:21
> Q_DECL_PRIVATE
You've probably meant Q_DECL_HIDDEN, right?
On an unrelated note: there are valid arguments against nested private classes
so it would be really nice if we
davidedmundson added a comment.
Let's wait for the new kwaylandserver repo before pushing.
But ++, looks good.
INLINE COMMENTS
> keyboard_shortcuts_inhibit_interface.cpp:21
> +
> +class KeyboardShortcutsInhibitorInterface::Private : public
>
crossi added a comment.
some code style related comments
INLINE COMMENTS
> test_keyboard_shortcuts_inhibitor_interface.cpp:109
> +m_manager = m_display.createKeyboardShortcutsInhibitManager(this);
> + QVERIFY(m_serverCompositor->isValid());
> +connect(m_serverCompositor,
bport retitled this revision from "[WIP] Add keyboard_shortcuts_inhibit
protocol" to "Add keyboard_shortcuts_inhibit protocol".
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D29231
To: bport, zzag, davidedmundson, apol
Cc: romangg, crossi, kde-frameworks-devel,
