This revision was automatically updated to reflect the committed changes.
Closed by commit R304:00aa6b29644b: Make it possible to use QXmlStreamReader to
read a KNS registry file (authored by apol).
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.
In https://phabricator.kde.org/D6067#114528, @apol wrote:
> In https://phabricator.kde.org/D6067#114498, @leinir wrote:
>
> > On a similar note to handling comments, how does it now
apol added a comment.
In https://phabricator.kde.org/D6067#114498, @leinir wrote:
> On a similar note to handling comments, how does it now handle
unknown/garbage tags? While it won't affect the cache code, it would
potentially affect other things (ocs is not guaranteed to be perfectly
leinir added a comment.
On a similar note to handling comments, how does it now handle
unknown/garbage tags? While it won't affect the cache code, it would
potentially affect other things (ocs is not guaranteed to be perfectly formed,
and it's one of the ways the framework's retained
apol updated this revision to Diff 15176.
apol added a comment.
More testing, fix issues
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6067?vs=15172=15176
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6067
AFFECTED FILES
apol updated this revision to Diff 15172.
apol added a comment.
Adds test, better parsing when there's comments, addresses comments by dfaure
REPOSITORY
R304 KNewStuff
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6067?vs=15096=15172
BRANCH
master
REVISION DETAIL
dfaure added inline comments.
INLINE COMMENTS
> entryinternal.cpp:443
> +{
> +Q_ASSERT(xml->tokenType()==QXmlStreamReader::StartElement);
> +QStringRef ret;
missing spaces around ==
> entryinternal.cpp:446
> +const auto token = xml->readNext();
> +if
apol created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
It's more efficient, especially in memory
TEST PLAN
tests pass, discover kns test passes, discover works
REPOSITORY
R304 KNewStuff
BRANCH
master
REVISION DETAIL
