chinmoyr updated this revision to Diff 25222.
chinmoyr edited the summary of this revision.
chinmoyr added a comment.
Summary update
Fixed windows build
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6832?vs=24598=25222
BRANCH
master
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:596ef4ccf1d7: Integrate new file ioslave in KIO job
(authored by chinmoyr).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6832?vs=25222=25223#toc
REPOSITORY
R241 KIO
CHANGES SINCE LAST
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Please keep in mind that we should remove one of the two flags before the end
of the month, after people tested this as much as possible ;)
I admit that it sucks a bit that I don't
chinmoyr added a comment.
ping
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6832
To: chinmoyr, dfaure, #frameworks
Cc: mreeves, #frameworks
chinmoyr updated this revision to Diff 24598.
chinmoyr added a comment.
1.Reassigned flag values for NoPrivilegeExecution and PrivilegeExecution. I
strongly feel that the latter won't be needed anymore.
2.Setting meta-data for unit test in the job itself (in
tryAskPrivilegeOpConfirmation).
chinmoyr updated this revision to Diff 24597.
chinmoyr added a comment.
1.Reassigned flag values for NoPrivilegeExecution and PrivilegeExecution. I
strongly feel that the latter won't be needed anymore.
2.Setting meta-data for unit test in the job itself (in
tryAskPrivilegeOpConfirmation).
chinmoyr updated this revision to Diff 20486.
chinmoyr added a comment.
minox changes
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6832?vs=20454=20486
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6832
AFFECTED FILES
src/core/job.cpp
src/core/job_base.h
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> job_base.h:311
> + *
> + * @since 5.39
> + **/
You can use @since 5.40 everywhere...
> job_base.h:317
> + * When set, notifies the slave
chinmoyr updated this revision to Diff 20454.
chinmoyr added a comment.
Added `NoPrivilegeExecution` flag to opt-out privilege execution.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6832?vs=18702=20454
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6832
dfaure accepted this revision.
This revision is now accepted and ready to land.
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D6832
To: chinmoyr, dfaure, #frameworks
Cc: #frameworks
chinmoyr updated this revision to Diff 18702.
chinmoyr added a comment.
- Return an enum (PrivilegeOperationStatus) instead of bool for confirmation
status.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6832?vs=18018=18702
BRANCH
master
REVISION DETAIL
dfaure added inline comments.
INLINE COMMENTS
> simplejob.cpp:346
> +bool confirmed = tryAskPrivilegeOpConfirmation();
> +m_slave->send(MSG_PRIVILEGE_EXEC, QByteArray(confirmed ? "1" : "0"));
> +}
Check that this is consistent with SlaveBase...
REVISION DETAIL
chinmoyr updated this revision to Diff 18018.
chinmoyr added a comment.
- Fixed the issues pointed out.
- Check for UnitTesting key in metadata while showing the confirmation dialog.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6832?vs=17222=18018
BRANCH
master
REVISION
dfaure requested changes to this revision.
dfaure added a comment.
This revision now requires changes to proceed.
Looks good, apart from a few minor things.
INLINE COMMENTS
> job.cpp:276
> +// Whether or not sub-jobs have PrivilegeExecution flag set
> doesn't matter.
> +
chinmoyr updated this revision to Diff 17222.
chinmoyr added a comment.
1. Separated enums, vars and functions
2. Removed hardcoding
3. Use the new signal privilegeOperationRequested
4. Removed public methods added in previous revision. Instead of them d_func
is used (which should have
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> job.cpp:345
> +m_confirmationAsked = true;
> +return status == 5;
> +}
This hardcoded 5 is awful, please use SlaveBase::Continue instead.
>
chinmoyr added a dependent revision: D6833: Add support for PrivilegeExecution
in KIO jobs.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6832
To: chinmoyr, dfaure, #frameworks
Cc: #frameworks
chinmoyr added reviewers: dfaure, Frameworks.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6832
To: chinmoyr, dfaure, #frameworks
Cc: #frameworks
chinmoyr added a task: T6561: Polkit support in KIO.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6832
To: chinmoyr
Cc: #frameworks
chinmoyr removed a task: T6561: Polkit support in KIO.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6832
To: chinmoyr
Cc: #frameworks
chinmoyr added a task: T6561: Polkit support in KIO.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D6832
To: chinmoyr
Cc: #frameworks
chinmoyr created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
REVISION SUMMARY
1. Adds a new job flag, PrivilegeExecution, to be used from applications side.
2. Adds code for confirmation dialog to be shown when the
22 matches
Mail list logo
