This revision was automatically updated to reflect the committed changes.
Closed by commit R246:2141e4215747: Dont export internal helper
executables (authored by vkrause).
REPOSITORY
R246 Sonnet
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7008?vs=17409=24726
REVISION DETAIL
sitter added a comment.
In https://phabricator.kde.org/D7008#185897, @apol wrote:
> Or as @dfaure says, don't install at all, because I don't see who uses
this. Or remove altogether?
The helpers are used by sonnet at build time, so to cross compile sonnet you
need the helpers
vkrause added a comment.
In https://phabricator.kde.org/D7008#185897, @apol wrote:
> Or as @dfaure says, don't install at all, because I don't see who uses
this. Or remove altogether?
That works for me on Yocto, but in general this seems wrong, as target-sonnet
will need to use
apol added a comment.
Or as @dfaure says, don't install at all, because I don't see who uses this.
Or remove altogether?
REPOSITORY
R246 Sonnet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7008
To: vkrause, #frameworks, cordlandwehr, apol
Cc: apol, sitter, sandsmark,
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
This patch is correct, EXPORT is only useful if the target is used within
cmake, AFAIU.
Furthermore, we should modify sonnet to install these applications into
LIBEXEC rather than bin,
habacker added a comment.
In https://phabricator.kde.org/D7008#133779, @sitter wrote:
>
> I think @apol wrote the initial implementation of this magic and can
probably answer questions better than me though :)
I guess no. He also did not provide a working example see
sitter added a subscriber: apol.
sitter added a comment.
In https://phabricator.kde.org/D7008#133756, @habacker wrote:
> In https://phabricator.kde.org/D7008#133755, @sitter wrote:
>
> > In https://phabricator.kde.org/D7008#133644, @sitter wrote:
> >
> > >
sitter added a comment.
In https://phabricator.kde.org/D7008#133764, @vkrause wrote:
> I assume installation is done for cross-compilation, yes. For Yocto this
wouldn't even be necessary though, we manually inject the host executables into
the -dev packages there, for this it only
vkrause added a comment.
I assume installation is done for cross-compilation, yes. For Yocto this
wouldn't even be necessary though, we manually inject the host executables into
the -dev packages there, for this it only matters that they are built, not that
they are installed (see
habacker added a comment.
In https://phabricator.kde.org/D7008#133755, @sitter wrote:
> In https://phabricator.kde.org/D7008#133644, @sitter wrote:
>
> >
https://phabricator.kde.org/source/kconfig/browse/master/KF5ConfigConfig.cmake.in;023e3ecfe985e09f786134fc28793d24383998f8$11
sitter added a comment.
In https://phabricator.kde.org/D7008#133644, @sitter wrote:
>
https://phabricator.kde.org/source/kconfig/browse/master/KF5ConfigConfig.cmake.in;023e3ecfe985e09f786134fc28793d24383998f8$11
when not xcompiling the targets are fairly useless and don't need to get
habacker added a comment.
In https://phabricator.kde.org/D7008#133644, @sitter wrote:
> (kind of off topic: This code should really be changed to use the
`KF5_HOST_TOOLING` we use elsewhere
You can show me a working example of this KF5_HOST_TOOLING support ?
REPOSITORY
R246
sitter added subscribers: habacker, sandsmark, sitter.
sitter added a comment.
As per the if below the proposed change it is used for cross compiling.
Subscribing original author and committer.
(kind of off topic: This code should really be changed to use the
`KF5_HOST_TOOLING` we
dfaure added a comment.
Why are those executables even installed? For crosscompiling maybe? I'm
confused about how that would work. One would build sonnet for host, install
it, and then build sonnet for target, importing targets from the host build?
Isn't that "import" what this commit
vkrause created this revision.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
Exporting the executables will make the cmake config file check for their
presence when used, which isn't really necessary, and is actually a problem
for cross-compilation, where the helper
15 matches
Mail list logo
