Re: KCoreAddons forward headers

2013-12-30 Thread Alex Merry
On 30/12/13 00:26, Aleix Pol wrote: No, it creates a variable called KCoreAddons_HEADERS which is passed to the install() command. ECM_GENERATE_HEADERS doesn't install anything, we decided to do it like that to minimize the magic factor. Please take a look at the function documentation, in

Re: KCoreAddons forward headers

2013-12-30 Thread David Faure
On Monday 30 December 2013 01:26:52 Aleix Pol wrote: On Sun, Dec 29, 2013 at 8:10 PM, David Faure fa...@kde.org wrote: On Sunday 29 December 2013 16:18:23 Christoph Cullmann wrote: On Friday 27 December 2013 19:36:57 Aleix Pol wrote: Hi, Here's a patch adding CamelCase headers to

Re: KCoreAddons forward headers

2013-12-30 Thread Aleix Pol
On Mon, Dec 30, 2013 at 11:42 AM, David Faure fa...@kde.org wrote: On Monday 30 December 2013 01:26:52 Aleix Pol wrote: On Sun, Dec 29, 2013 at 8:10 PM, David Faure fa...@kde.org wrote: On Sunday 29 December 2013 16:18:23 Christoph Cullmann wrote: On Friday 27 December 2013 19:36:57

Re: KCoreAddons forward headers

2013-12-30 Thread David Faure
On Monday 30 December 2013 14:59:51 Aleix Pol wrote: It only has the lowercase headers, uppercase headers are installed from another command: install(DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/KCoreAddons DESTINATION ${INCLUDE_INSTALL_DIR} COMPONENT Devel ) Ah, right. Sounds good to me as it is,

Re: KCoreAddons forward headers

2013-12-29 Thread David Faure
On Friday 27 December 2013 19:36:57 Aleix Pol wrote: Hi, Here's a patch adding CamelCase headers to KCoreAddons (attached). If we agree that it's the proper way of doing it, I'll proceed to do it on the rest of modules. Looks good to me. I like the fact that we can't forget to add

Re: KCoreAddons forward headers

2013-12-29 Thread Christoph Cullmann
On Friday 27 December 2013 19:36:57 Aleix Pol wrote: Hi, Here's a patch adding CamelCase headers to KCoreAddons (attached). If we agree that it's the proper way of doing it, I'll proceed to do it on the rest of modules. Looks good to me. I like the fact that we can't forget to add

Re: KCoreAddons forward headers

2013-12-29 Thread David Faure
On Sunday 29 December 2013 16:18:23 Christoph Cullmann wrote: On Friday 27 December 2013 19:36:57 Aleix Pol wrote: Hi, Here's a patch adding CamelCase headers to KCoreAddons (attached). If we agree that it's the proper way of doing it, I'll proceed to do it on the rest of

Re: KCoreAddons forward headers

2013-12-29 Thread Aleix Pol
On Sun, Dec 29, 2013 at 8:10 PM, David Faure fa...@kde.org wrote: On Sunday 29 December 2013 16:18:23 Christoph Cullmann wrote: On Friday 27 December 2013 19:36:57 Aleix Pol wrote: Hi, Here's a patch adding CamelCase headers to KCoreAddons (attached). If we agree that it's the

KCoreAddons forward headers

2013-12-27 Thread Aleix Pol
Hi, Here's a patch adding CamelCase headers to KCoreAddons (attached). If we agree that it's the proper way of doing it, I'll proceed to do it on the rest of modules. Cheers! Aleix diff --git a/CMakeLists.txt b/CMakeLists.txt index 389245c..ba6644a 100644 --- a/CMakeLists.txt +++