Re: Review Request 113821: Don't install kpagedialog_p.h

2013-11-13 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113821/#review43572 --- Ship it! I don't spot anything wrong. - Vishesh Handa On

Re: Review Request 113821: Don't install kpagedialog_p.h

2013-11-13 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113821/#review43573 --- tier4/kcmutils/src/kcmultidialog.cpp

Re: Review Request 113821: Don't install kpagedialog_p.h

2013-11-13 Thread Aleix Pol Gonzalez
On Nov. 13, 2013, 11:53 a.m., David Edmundson wrote: tier4/kcmutils/src/kcmultidialog.cpp, line 262 http://git.reviewboard.kde.org/r/113821/diff/1/?file=213192#file213192line262 I don't think this is right. If we copy a KCMultiDialog instance, we wouldn't copy the

Re: Review Request 113821: Don't install kpagedialog_p.h

2013-11-13 Thread David Edmundson
On Nov. 13, 2013, 11:53 a.m., David Edmundson wrote: tier4/kcmutils/src/kcmultidialog.cpp, line 262 http://git.reviewboard.kde.org/r/113821/diff/1/?file=213192#file213192line262 I don't think this is right. If we copy a KCMultiDialog instance, we wouldn't copy the

Re: Review Request 113821: Don't install kpagedialog_p.h

2013-11-13 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113821/#review43603 --- This review has been submitted with commit

Re: Review Request 113821: Don't install kpagedialog_p.h

2013-11-13 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113821/ --- (Updated Nov. 13, 2013, 3:43 p.m.) Status -- This change has been