Re: Review Request 123443: Make it possible to call a put job from an IODevice

2015-04-26 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123443/ --- (Updated April 26, 2015, 11:43 p.m.) Status -- This change has been

Re: Review Request 123443: Make it possible to call a put job from an IODevice

2015-04-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123443/#review79517 --- Ship it! Ship It! - David Faure On April 22, 2015, 4:13

Re: Review Request 123443: Make it possible to call a put job from an IODevice

2015-04-25 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123443/#review79515 --- I love the idea (QIODevice rocks). But I wonder about the

Re: Review Request 123443: Make it possible to call a put job from an IODevice

2015-04-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123443/ --- (Updated April 22, 2015, 6:13 p.m.) Review request for KDE Frameworks.

Re: Review Request 123443: Make it possible to call a put job from an IODevice

2015-04-22 Thread Emmanuel Pescosta
On April 22, 2015, 9 a.m., Emmanuel Pescosta wrote: src/widgets/accessmanager.cpp, line 255 https://git.reviewboard.kde.org/r/123443/diff/1/?file=362233#file362233line255 IMO you should always verify if the data is readable, because not all lib users are trustworthy (assert isn't

Re: Review Request 123443: Make it possible to call a put job from an IODevice

2015-04-22 Thread Emmanuel Pescosta
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123443/#review79325 --- src/widgets/accessmanager.cpp (line 255)

Re: Review Request 123443: Make it possible to call a put job from an IODevice

2015-04-22 Thread Aleix Pol Gonzalez
On April 22, 2015, 9 a.m., Emmanuel Pescosta wrote: src/widgets/accessmanager.cpp, line 255 https://git.reviewboard.kde.org/r/123443/diff/1/?file=362233#file362233line255 IMO you should always verify if the data is readable, because not all lib users are trustworthy (assert isn't