Re: Review Request 129405: KCollapsibleGroupBox: don't hide widgets, override focus policy instead

2016-11-15 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129405/ --- (Updated Nov. 15, 2016, 4:27 p.m.) Status -- This change has been

Re: Review Request 129405: KCollapsibleGroupBox: don't hide widgets, override focus policy instead

2016-11-15 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129405/#review100839 --- Fix it, then Ship it! src/kcollapsiblegroupbox.cpp

Re: Review Request 129405: KCollapsibleGroupBox: don't hide widgets, override focus policy instead

2016-11-15 Thread Heiko Tietze
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129405/#review100856 --- Ship it! Looks good from the usability POV, hidden items

Re: Review Request 129405: KCollapsibleGroupBox: don't hide widgets, override focus policy instead

2016-11-15 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129405/ --- (Updated Nov. 15, 2016, 11:06 a.m.) Review request for KDE Frameworks,

Re: Review Request 129405: KCollapsibleGroupBox: don't hide widgets, override focus policy instead

2016-11-15 Thread Heiko Tietze
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129405/#review100850 --- Picture, or it didn't happen :-) (before/after would be

Re: Review Request 129405: KCollapsibleGroupBox: don't hide widgets, override focus policy instead

2016-11-15 Thread Elvis Angelaccio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129405/ --- (Updated Nov. 15, 2016, 9:53 a.m.) Review request for KDE Frameworks,