Re: Review Request 114716: Separate author name from email addres in KAboutData::processCommandLine

2014-01-01 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114716/#review46555 --- This review has been submitted with commit

Re: Review Request 114716: Separate author name from email addres in KAboutData::processCommandLine

2014-01-01 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114716/ --- (Updated Jan. 1, 2014, 6:55 p.m.) Status -- This change has been

Re: Review Request 114716: Separate author name from email addres in KAboutData::processCommandLine

2013-12-30 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114716/#review46435 --- Ship it! Ship It! - David Faure On Dec. 29, 2013, 11:50

Re: Review Request 114716: Separate author name from email addres in KAboutData::processCommandLine

2013-12-29 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114716/#review46352 --- The kde4 code (kcmdlineargs.cpp) was doing this:

Re: Review Request 114716: Separate author name from email addres in KAboutData::processCommandLine

2013-12-29 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114716/ --- (Updated Dec. 29, 2013, 11:50 p.m.) Review request for KDE Frameworks.

Re: Review Request 114716: Separate author name from email addres in KAboutData::processCommandLine

2013-12-29 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114716/#review46422 --- Ship it! Ship It! - Aleix Pol Gonzalez On Dec. 29, 2013,

Review Request 114716: Separate author name from email addres in KAboutData::processCommandLine

2013-12-28 Thread David Gil Oliva
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114716/ --- Review request for KDE Frameworks. Repository: kcoreaddons Description

Re: Review Request 114716: Separate author name from email addres in KAboutData::processCommandLine

2013-12-28 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/114716/#review46342 --- src/lib/kaboutdata.cpp

Re: Review Request 114716: Separate author name from email addres in KAboutData::processCommandLine

2013-12-28 Thread David Gil Oliva
On Dec. 29, 2013, 1:05 a.m., Albert Astals Cid wrote: src/lib/kaboutdata.cpp, line 969 https://git.reviewboard.kde.org/r/114716/diff/1/?file=227634#file227634line969 Not related to your patch, but i wonder if we need a \n here too? I don't think so. The output of kgeography